Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual into lp:ubuntu-ui-toolkit/staging

[Cris Dywan]

Allow manual orientation changes through OrientationHelper.orientation

Autopilot tests for orientation issues in both text input and popovers/ dialogs:
env APP_ID=uitl LANGUAGE=en ./run_tests.sh ubuntuuitoolkit.tests.components.test_textinput.InsertModeTextInputTestCase.test_rotate_portrait -v
env APP_ID=uitl LANGUAGE=en ./run_tests.sh ubuntuuitoolkit.tests.components.test_popover.PopoverOpenTestCase.test_popover_rotate_portrait -v

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1177
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1613/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2056/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/340/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/343/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/340/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2054/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1613/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1178
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1628/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2098/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/355/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/358/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/355/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2096/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1628/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1179
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1629/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2101/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/356/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/359/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/356/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2099/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1629/rebuild

review: Needs Fixing (continuous-integration)

[Tim Peeters (tpeeters)]

If someone would be setting OrientationHelper.orientationAngle, that will break because it became read-only here.

[Tim Peeters (tpeeters)]

22 + // Functions to allow Autopilot to handle orientation
23 + objectName: "MainViewBaseStyledItem"
24 + function setOrientation(newOrientation) {
25 + if (newOrientation == 'Landscape')
26 + UbuntuApplication.orientation = Qt.LandscapeOrientation
27 + else if (newOrientation == 'Portrait')
28 + UbuntuApplication.orientation = Qt.PortraitOrientation
29 + else
30 + UbuntuApplication.orientation = newOrientation
31 + }
32 + function getOrientation() {
33 + return UbuntuApplication.orientation
34 + }

Could this be implemented in autopilot without adding the JS functions here? Ca we get to the UbuntuApplication in AP?

[Tim Peeters (tpeeters)]

46 - property int orientationAngle: automaticOrientation ? Screen.angleBetween(Screen.primaryOrientation, Screen.orientation) : 0
47 + readonly property int orientationAngle: automaticOrientation
48 + ? Screen.angleBetween(Screen.primaryOrientation, UbuntuApplication.orientation)
49 + : 0

This breaks API. Perhaps we should split up OrientationHelper in an 1.0 version an 1.3 version.

Was there any use case for setting the value previously? And did you check that apps don't set the orientationAngle?

review: Needs Fixing

[Tim Peeters (tpeeters)]

53 - onOrientationAngleChanged: { automaticOrientation ? stableOrientationAngleTimer.restart() : d.tryUpdateState(); }
54 + onOrientationAngleChanged: automaticOrientation ? stableOrientationAngleTimer.restart()
55 + : d.tryUpdateState();

why did you remove the { }?

Personally I would use the old-fashioned if-then-else ;) but that's a matter of taste I guess.

[Tim Peeters (tpeeters)]

63 - /*
64 - The attached property Screen.orientation is only valid inside Item or
65 - derived components. Inside Object it evaluates to 0 with no error.
66 - Also be aware that some apps eg. webbrowser-app set window.contentOrientation
67 - and thus can hide failure to update it from this code.
68 - See http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick-window2-screen.html
69 - */

(why) is this comment no longer valid?

The link would require an update though.

[Tim Peeters (tpeeters)]

nevermind that^ comment. Got it.

> 63 - /*
> 64 - The attached property Screen.orientation is only valid inside
> Item or
> 65 - derived components. Inside Object it evaluates to 0 with no
> error.
> 66 - Also be aware that some apps eg. webbrowser-app set
> window.contentOrientation
> 67 - and thus can hide failure to update it from this code.
> 68 - See http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick-
> window2-screen.html
> 69 - */
>
> (why) is this comment no longer valid?
>
> The link would require an update though.

[Tim Peeters (tpeeters)]

107 - automaticOrientation: stateWrapper.rootItem && stateWrapper.rootItem.automaticOrientation ?
108 - stateWrapper.rootItem.automaticOrientation : false
109 + rotation: stateWrapper.automaticOrientation
110 + ? Screen.angleBetween(Screen.primaryOrientation, UbuntuApplication.orientation) : 0
111 anchorToKeyboard: true
112
113 LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
114 @@ -180,6 +179,7 @@
115 Item {
116 id: stateWrapper
117 property Item rootItem: QuickUtils.rootItem(popupBase)
118 + property bool automaticOrientation: rootItem && rootItem.automaticOrientation ? rootItem.automaticOrientation : false

This change doesn't really make it prettier. Does the automaticOrientation have anything to do with the stateWrapper, or is it only a convenient internal place where you can put the property?

[Tim Peeters (tpeeters)]

130 - parent: QuickUtils.rootItem(handler.main)
131 + // Parent to the contentsItem to be able to inherit rotation
132 + parent: {
133 + var mainView = QuickUtils.rootItem(handler.main);
134 + // Check in case the root isn't a MainView
135 + return mainView.contentsItem ? mainView.contentsItem[0] : mainView;
136 + }

Can you add a comment explaining what you expect to be mainView.contentsItem[0]? It seems that can be anything that the developer added inside the MainView.

review: Needs Fixing

[Tim Peeters (tpeeters)]

201 +/*!
202 + * \qmlproperty Qt.ScreenOrientation Application::orientation
203 + * \internal
204 + * The current orientation of the application - can be overridden manually for testing.
205 + */

Why is the component name here Application and not UbuntuApplication? (same question would apply to Applcation::applicationName documentation)?

And why is it internal? Don't we want this to be documented? (again, same question for applicationName).

[Tim Peeters (tpeeters)]

214 +void UCApplication::setOrientation(Qt::ScreenOrientation orientation) {
215 + if (m_orientation == -1) {
216 + // we're now in manual override mode
217 + disconnect(QGuiApplication::primaryScreen(), &QScreen::orientationChanged,
218 + this, &UCApplication::orientationChanged);
219 + }
220 +
221 + if (m_orientation != orientation) {
222 + m_orientation = orientation;
223 + Q_EMIT orientationChanged(orientation);
224 + }
225 +}

You want to re-connect when the orientation is set to -1. Also, document that you can set it to -1 to make it follow the Qt value.

[Tim Peeters (tpeeters)]

276 + def _set_orientation(self, orientation):
277 + self.select_single(
278 + objectName='MainViewBaseStyledItem').slots.setOrientation(
279 + orientation)
280 + # Short delay to ensure introspection is uptodate
281 + time.sleep(1)
282 +
283 + @property
284 + def _orientation(self):
285 + return self.select_single(
286 + objectName='MainViewBaseStyledItem').orientation

Since we are using _orientation outside of the CPOs themselves (in tests/components), perhaps we should expose it properly? So no _-prefix?

Also, we should also test the property in tests/custom_proxy_objects/test_mainview.py.

review: Needs Fixing

[Tim Peeters (tpeeters)]

281 + time.sleep(1)

When changing orientation, there can be an animation going on because of the orientation change. It is better to have a proper wait for that (similar to waitForAnimation() in _header.py)?

[Tim Peeters (tpeeters)]

324 + # Give rendering a chance to finish
325 + time.sleep(2)

Here you would call the proper waitForOrientationChange() function that I suggested above.

Anyway I think if you physically rotate a device, the rotation animation is more than 2ms.

[Tim Peeters (tpeeters)]

311 + scenarios = [
312 + ('Popover', dict(button='button', popover='popover')),
313 + ('Small dialog', dict(button='button_small', popover='dialog_small')),
314 + ('Huge dialog', dict(button='button_huge', popover='dialog_huge')),
315 + ]

I prefer buttonName, popoverName etc to name the variables, to make the code that follows more clear (the first time I read popover = self.main_view.select_single(objectName=self.popover), I got confused).

review: Needs Fixing

[Tim Peeters (tpeeters)]

 + def _rotate(self, orientation):

I don't know if there is a policy on this, but I noticed that in the other python component tests, we don't prefix functions with _.

[Tim Peeters (tpeeters)]

330 + def test_popover_rotate_landscape(self):
331 + self._rotate('Landscape')
332 +
333 + def test_popover_rotate_portrait(self):
334 + self._rotate('Portrait')

Minor detail: test_rotate_to_landscape() and test_rotate_to_portrait() have my preference. You already are inside a popover testcase. And adding _to makes the function read like a proper sentence.

[Tim Peeters (tpeeters)]

304 +class PopoverOpenTestCase(tests.QMLFileAppTestCase):

you are not testing opening of a Popover, but its rotation.

review: Needs Fixing

[Tim Peeters (tpeeters)]

440 + def _rotate(self, orientation):

other functions (like select_cursor() in the same class) don't use the _ prefix.

454 + def test_rotate_landscape(self):
455 + self._rotate('Landscape')
456 +
457 + def test_rotate_portrait(self):
458 + self._rotate('Portrait')
459

same as above, I would prefer test_rotate_to_landscape etc.

[Tim Peeters (tpeeters)]

> env APP_ID=uitl LANGUAGE=en ./run_tests.sh >ubuntuuitoolkit.tests.components.test_textinput.InsertModeTextInputTestCase.test_rotate_portrait -v

This works on my desktop without the APP_ID. Is that because I'm on desktop?
Where does the uitl id come from? Is that something common for all our tests?

[Cris Dywan (kalikiana)]

> 201 +/*!
> 202 + * \qmlproperty Qt.ScreenOrientation Application::orientation
> 203 + * \internal
> 204 + * The current orientation of the application - can be overridden
> manually for testing.
> 205 + */
>
> Why is the component name here Application and not UbuntuApplication? (same
> question would apply to Applcation::applicationName documentation)?
>
> And why is it internal? Don't we want this to be documented? (again, same
> question for applicationName).

That whole object is internal API that exists for things we can't implement in QML.

[Cris Dywan (kalikiana)]

> 214 +void UCApplication::setOrientation(Qt::ScreenOrientation orientation)
> {
> 215 + if (m_orientation == -1) {
> 216 + // we're now in manual override mode
> 217 + disconnect(QGuiApplication::primaryScreen(),
> &QScreen::orientationChanged,
> 218 + this, &UCApplication::orientationChanged);
> 219 + }
> 220 +
> 221 + if (m_orientation != orientation) {
> 222 + m_orientation = orientation;
> 223 + Q_EMIT orientationChanged(orientation);
> 224 + }
> 225 +}
>
> You want to re-connect when the orientation is set to -1. Also, document that
> you can set it to -1 to make it follow the Qt value.

I don't see a use case for that. As the documentation says you can override it for testing, and if you do that it makes no sense to go back to physical orientation.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1180
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1632/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2106
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/359
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/362
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/362/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/359
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1854
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2104
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2104/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19389

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1632/rebuild

review: Needs Fixing (continuous-integration)

[Cris Dywan (kalikiana)]

> > env APP_ID=uitl LANGUAGE=en ./run_tests.sh >ubuntuuitoolkit.tests.components
> .test_textinput.InsertModeTextInputTestCase.test_rotate_portrait -v
>
>
> This works on my desktop without the APP_ID. Is that because I'm on desktop?
> Where does the uitl id come from? Is that something common for all our tests?

I use it to get rid of some of the error spam which you get despite the fact that it is indeed neither required nor usually set on the desktop.

[Cris Dywan (kalikiana)]

> 324 + # Give rendering a chance to finish
> 325 + time.sleep(2)
>
> Here you would call the proper waitForOrientationChange() function that I
> suggested above.
>
> Anyway I think if you physically rotate a device, the rotation animation is
> more than 2ms.

I added a rotating.wait_for. But it's not apparently enough for AP to update its coordinate space when the animation is in fact finished. So I left a sleep(1), not sure what else I could check for here. The one for the cursor is in fact unnecessary, though, so I removed it.

[Cris Dywan (kalikiana)]

I addressed all the naming suggestions, made the set_orientation function public and added a test for it. Note there's no actual way to verify rotation and as such absent from the cpo test because one of the orientations is always a no-op depending on the primary orientation and the real tests don't need to be aware of it… after having written this I actually convinced myself that this isn't acceptable… I'll have to look into a way to address this.

[Leo Arias (elopio)]

I left some comments.

[Tim Peeters (tpeeters)]

9 + // Function provided here because Autopilot can't change property

Is the function that you refer to getOrientation(), which you removed in a later commit?

[Tim Peeters (tpeeters)]

264 + def set_orientation(self, orientation):
265 + self.select_single(
266 + objectName='MainViewBaseStyledItem').slots.setOrientation(
267 + orientation)
268 + self.select_single('OrientationHelper').rotating.wait_for(False)
269 + # Short delay to ensure introspection is uptodate
270 + time.sleep(1)

I wonder if the problem here is that when you do the wait_for, perhaps the value of the property was not updated to be True yet? In that case it is better to add the sleep(1) before the wait_for.

[Tim Peeters (tpeeters)]

In two occasions, you use select_single('OrientationHelper').

I think it is better to use an objectName for selecting the OrientationHelper. In the past we had problems some times (with versioning or custom subclasses of components) when using the type.

[Tim Peeters (tpeeters)]

118 + do {
119 + orientationHelper = orientationHelper.parent;
120 + } while (orientationHelper && !orientationHelper.automaticOrientation && orientationHelper != null);

isn't orientationHelper != null already implied by orientationHelper? Anyway it would be weird to put the != null in the end.

Also, if you are looking for orientationHelper, you should be checking orientationHelper.hasOwnProperty("automaticOrientation"), not the value of automaticOrientation.

review: Needs Fixing

[Cris Dywan (kalikiana)]

> 9 + // Function provided here because Autopilot can't change
> property
>
> Is the function that you refer to getOrientation(), which you removed in a
> later commit?

There still is a function right below the comment…

[Tim Peeters (tpeeters)]

looks good!

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1186
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1655/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2198/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/382/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/385/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/382/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2196/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1655/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

<elopio> kalikiana: FOLLOW_SCREAM_ORIENTATION
<elopio> is it really scream?
<kalikiana> erm
<kalikiana> well, timp asked me to fix the typo in SCREEM…
<kalikiana> ^_^'
<kalikiana> brainfart…
<elopio> other than that, lgt.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-autolanding/885/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-autolanding/193/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-autolanding/192/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-autolanding/192/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1191
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1657/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2201/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/384/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/387/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/384/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2199/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1657/rebuild

review: Needs Fixing (continuous-integration)

[Tim Peeters (tpeeters)]

Found 1 license problems:
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.orientation.qml UNKNOWN *No copyright*

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-autolanding/888/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-autolanding/196
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-autolanding/195
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-autolanding/195/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-autolanding/195

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1192
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1665/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2218
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/392
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/395
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/395/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/392
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1947
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2216
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2216/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19599

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1665/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1193. By Cris Dywan on 2015-04-15

Only test non-default orientation for clear results

Otherwise some properties may not change if nothing did rotate.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1193
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1673/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2251
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/400
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/403
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/403/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/400
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1976
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2249
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2249/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19656

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1673/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1194. By Cris Dywan on 2015-04-17

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1195. By Cris Dywan on 2015-04-20

Take Component-based popover rootItem from the caller

1196. By Cris Dywan on 2015-04-20

FakeCursor parent should fallback to toplevel

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1195
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1684/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2341/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/411/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/414/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/411/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2339/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1684/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1197. By Cris Dywan on 2015-04-20

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1197
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1686/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2348/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/413/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/416/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/413/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2346/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1686/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1198. By Cris Dywan on 2015-04-20

Put back accidentally removed "import os"

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1198
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1687/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2357
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/414
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/417
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/417/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/414
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2066
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2355
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2355/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19811

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1687/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1199. By Cris Dywan on 2015-05-12

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1199
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1752/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2730
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/480
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/482
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/482/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/479
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2358
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2728
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2728/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20400

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1752/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1200. By Cris Dywan on 2015-05-13

Empty commit

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1200
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1762/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2790
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/490
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/492
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/492/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/489
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2403
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2788
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2788/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20476

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1762/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1201. By Cris Dywan on 2015-05-21

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1201
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1782/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2910/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/510/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/512/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/509/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2908/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1782/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1202. By Cris Dywan on 2015-05-21

Update components.api

1203. By Cris Dywan on 2015-05-21

Undo accidental changes

1204. By Cris Dywan on 2015-05-21

Move all orientation tests to 1.3

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1204
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1785/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2919/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/513/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/515/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/512/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2917/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1785/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1205. By Cris Dywan on 2015-05-22

Revert bogus components.api changes

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1205
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1790/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2938
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/518
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/520
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/520/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/517
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2517
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2936
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2936/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20731

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1790/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1206. By Cris Dywan on 2015-06-01

Normalize rotation angle in tests

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1206
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1823/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3030
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/551
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/553
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/553/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/550
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2576
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3028
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3028/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20868

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1823/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1207. By Cris Dywan on 2015-06-02

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1208. By Cris Dywan on 2015-06-02

Use Popups 1.3 in test_popover.qml

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1207
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1833/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3046
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/561
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/563
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/563/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/560
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2585
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3044
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3044/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20893

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1833/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1208
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1839/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3053
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/567
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/569
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/569/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/566
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2589
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3051
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3051/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20900

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1839/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1209. By Cris Dywan on 2015-06-02

Assert focus after tapping TextField in popover tests

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1209
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1842/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3057
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/570
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/572
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/572/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/569
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2591
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3055
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3055/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20907

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1842/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1210. By Cris Dywan on 2015-06-03

Anchor Column in test_textinput.textfield.qml to the top

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1210
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1854/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3074
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/582
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/584
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/584/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/581
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2599
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3072
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3072/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20927

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1854/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1211. By Cris Dywan on 2015-06-05

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1211
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1861/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3099
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/589
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/591
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/591/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/588
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2611
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3097
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3097/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20990

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1861/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1212. By Cris Dywan on 2015-06-10

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1212
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1874/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/602
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/604
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/604/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/601
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2653
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3152
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3152/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21117

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1874/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1213. By Cris Dywan on 2015-06-11

Use Eventually and wait_ instead of time.sleep

1214. By Cris Dywan on 2015-06-11

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1214
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1879/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3170/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/607/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/609/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/606/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3168/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1879/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1215. By Cris Dywan on 2015-06-12

Make flake8 happy once again

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1215
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1884/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3190
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/612
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/614
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/614/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/611
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2681
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3188
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3188/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21172

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1884/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual]

1216. By Cris Dywan on 2015-06-18

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1216
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1921/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3255
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/649
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/651
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/651/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/648
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2718
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3253
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3253/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21302

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1921/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1216. By Cris Dywan on 2015-06-18

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1215. By Cris Dywan on 2015-06-12

Make flake8 happy once again

1214. By Cris Dywan on 2015-06-11

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1213. By Cris Dywan on 2015-06-11

Use Eventually and wait_ instead of time.sleep

1212. By Cris Dywan on 2015-06-10

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1211. By Cris Dywan on 2015-06-05

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1210. By Cris Dywan on 2015-06-03

Anchor Column in test_textinput.textfield.qml to the top

1209. By Cris Dywan on 2015-06-02

Assert focus after tapping TextField in popover tests

1208. By Cris Dywan on 2015-06-02

Use Popups 1.3 in test_popover.qml

1207. By Cris Dywan on 2015-06-02

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

=== modified file 'modules/Ubuntu/Components/1.3/MainView.qml'
--- modules/Ubuntu/Components/1.3/MainView.qml	2015-05-11 12:50:00 +0000
+++ modules/Ubuntu/Components/1.3/MainView.qml	2015-06-18 17:57:10 +0000
@@ -33,6 +33,7 @@
     default property alias contentsItem: contents.data
     OrientationHelper {
         id: canvas
+        objectName: 'canvas'
 
         automaticOrientation: false
         anchorToKeyboard: mainView.anchorToKeyboard

=== modified file 'modules/Ubuntu/Components/1.3/MainViewBase.qml'
--- modules/Ubuntu/Components/1.3/MainViewBase.qml	2015-05-21 10:50:35 +0000
+++ modules/Ubuntu/Components/1.3/MainViewBase.qml	2015-06-18 17:57:10 +0000
@@ -64,6 +64,25 @@
                 mainView.theme.name = "Ubuntu.Components.Themes.%1".arg(autoThemeName);
             }
         }
+
+        // Function provided here because Autopilot can't change property
+        // Also UbuntuApplication is not accessible via introspection
+        objectName: "MainViewBaseStyledItem"
+        function setOrientation(newOrientation) {
+            // Rotation can only happen if it was enabled; prevent false positives
+            if (!mainView.automaticOrientation)
+                return;
+            if (newOrientation == 'landscape')
+                UbuntuApplication.orientation = Qt.LandscapeOrientation;
+            else if (newOrientation == 'portrait')
+                UbuntuApplication.orientation = Qt.PortraitOrientation;
+        }
+        property string orientation: {
+            if (UbuntuApplication.orientation == Qt.LandscapeOrientation)
+                return 'landscape';
+            else if (UbuntuApplication.orientation == Qt.PortraitOrientation)
+                return 'portrait';
+        }
     }
 
     active: true

=== modified file 'modules/Ubuntu/Components/1.3/OrientationHelper.qml'
--- modules/Ubuntu/Components/1.3/OrientationHelper.qml	2015-04-25 08:54:58 +0000
+++ modules/Ubuntu/Components/1.3/OrientationHelper.qml	2015-06-18 17:57:10 +0000
@@ -83,7 +83,7 @@
 
       Calculates the current orientation angle.
      */
-    property int orientationAngle: automaticOrientation ? Screen.angleBetween(Screen.primaryOrientation, Screen.orientation) : 0
+    property int orientationAngle: automaticOrientation ? Screen.angleBetween(Screen.primaryOrientation, UbuntuApplication.orientation) : 0
     // Screen.primaryOrientation and Screen.orientation can change one right after the other,
     // causing orientationAngle to momentarily change. To avoid responding to such
     // intermediate states, wait for its value to stabilize before rotating to it.
@@ -102,15 +102,9 @@
     width: parent ? (d.flipDimensions ? d.availableParentHeight : parent.width) : 0
     height: parent ? (d.flipDimensions ? parent.width : d.availableParentHeight) : 0
 
-    /*
-      The attached property Screen.orientation is only valid inside Item or
-      derived components. Inside Object it evaluates to 0 with no error.
-      Also be aware that some apps eg. webbrowser-app set window.contentOrientation
-      and thus can hide failure to update it from this code.
-      See http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick-window2-screen.html
-    */
     Item {
         id: d
+        objectName: 'd'
 
         property real availableParentHeight: {
             if (!orientationHelper.parent)
@@ -138,7 +132,7 @@
          */
         function applyOrientation() {
             if (windowActive && window)
-                window.contentOrientation = Screen.orientation
+                window.contentOrientation = UbuntuApplication.orientation
         }
 
         onWindowActiveChanged: {

=== modified file 'modules/Ubuntu/Components/1.3/TextCursor.qml'
--- modules/Ubuntu/Components/1.3/TextCursor.qml	2015-06-10 17:23:51 +0000
+++ modules/Ubuntu/Components/1.3/TextCursor.qml	2015-06-18 17:57:10 +0000
@@ -295,7 +295,16 @@
     Item {
         id: fakeCursor
         objectName: positionProperty + "FakeCursor"
-        parent: QuickUtils.rootItem(handler.main)
+        // Parent to OrientationHelper to inherit rotation
+        parent: {
+            var orientationHelper = handler.main;
+            do {
+                if (!orientationHelper.parent)
+                    break;
+                orientationHelper = orientationHelper.parent;
+            } while (orientationHelper && !orientationHelper.hasOwnProperty('automaticOrientation'));
+            return orientationHelper;
+        }
         width: cursorItem.width
         height: cursorItem.height
         Component.onCompleted: caret.parent = fakeCursor

=== modified file 'modules/Ubuntu/Components/Popups/1.2/popupUtils.js'
--- modules/Ubuntu/Components/Popups/1.2/popupUtils.js	2015-04-30 08:32:44 +0000
+++ modules/Ubuntu/Components/Popups/1.2/popupUtils.js	2015-06-18 17:57:10 +0000
@@ -31,7 +31,7 @@
     if (popup.createObject) {
         // popup is a component and can create an object
         popupComponent = popup;
-        rootObject = QuickUtils.rootItem(popup);
+        rootObject = (caller !== undefined) ? QuickUtils.rootItem(caller) : QuickUtils.rootItem(null);
     } else if (typeof popup === "string") {
         popupComponent = Qt.createComponent(popup);
         rootObject = (caller !== undefined) ? QuickUtils.rootItem(caller) : QuickUtils.rootItem(null);

=== modified file 'modules/Ubuntu/Components/Popups/1.3/PopupBase.qml'
--- modules/Ubuntu/Components/Popups/1.3/PopupBase.qml	2015-04-29 08:55:31 +0000
+++ modules/Ubuntu/Components/Popups/1.3/PopupBase.qml	2015-06-18 17:57:10 +0000
@@ -15,6 +15,7 @@
  */
 
 import QtQuick 2.4
+import QtQuick.Window 2.0
 import Ubuntu.Components 1.3
 
 /*!
@@ -47,14 +48,12 @@
       */
     property PropertyAnimation fadingAnimation: PropertyAnimation{duration: 0}
 
-    // without specifying width and height below, some width calculations go wrong in Sheet.
-    // I guess popupBase.width is not correctly set initially
-    width: parent ? parent.width : undefined
-    height: parent ? parent.height : undefined
-
+    // No need for transitioning, take rotation directly
+    automaticOrientation: false
+    transitionEnabled: false
     // copy value of automaticOrientation from root object (typically a MainView)
-    automaticOrientation: stateWrapper.rootItem && stateWrapper.rootItem.automaticOrientation ?
-                          stateWrapper.rootItem.automaticOrientation : false
+    rotation: stateWrapper.rootItem && stateWrapper.rootItem.automaticOrientation
+     ? Screen.angleBetween(Screen.primaryOrientation, UbuntuApplication.orientation) : 0
     anchorToKeyboard: true
 
     LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft

=== modified file 'modules/Ubuntu/Components/plugin/plugin.cpp'
--- modules/Ubuntu/Components/plugin/plugin.cpp	2015-05-26 17:54:51 +0000
+++ modules/Ubuntu/Components/plugin/plugin.cpp	2015-06-18 17:57:10 +0000
@@ -272,12 +272,5 @@
     // register icon provider
     engine->addImageProvider(QLatin1String("theme"), new UnityThemeIconProvider);
 
-    // Necessary for Screen.orientation (from import QtQuick.Window 2.0) to work
-    QGuiApplication::primaryScreen()->setOrientationUpdateMask(
-            Qt::PortraitOrientation |
-            Qt::LandscapeOrientation |
-            Qt::InvertedPortraitOrientation |
-            Qt::InvertedLandscapeOrientation);
-
     registerWindowContextProperty();
 }

=== modified file 'modules/Ubuntu/Components/plugin/ucapplication.cpp'
--- modules/Ubuntu/Components/plugin/ucapplication.cpp	2014-10-02 10:14:51 +0000
+++ modules/Ubuntu/Components/plugin/ucapplication.cpp	2015-06-18 17:57:10 +0000
@@ -19,10 +19,15 @@
 #include "ucapplication.h"
 
 #include <QtCore/QCoreApplication>
+#include <QtGui/QGuiApplication>
+#include <QWindow>
 #include <QDebug>
 #include <QtQml/QQmlContext>
 #include <QtQml/QQmlEngine>
 #include <QtCore/QStandardPaths>
+#include <QScreen>
+
+const int FOLLOW_SCREEN_ORIENTATION = -1;
 
 /*!
  * \qmltype UbuntuApplication
@@ -33,11 +38,20 @@
  *
  * UbuntuApplication is a context property in QML.
  */
-UCApplication::UCApplication(QObject* parent) : QObject(parent), m_context(0)
+UCApplication::UCApplication(QObject* parent) : QObject(parent), m_context(0), m_orientation(FOLLOW_SCREEN_ORIENTATION)
 {
     // Make sure we receive application name changes from C++ modules
     connect(QCoreApplication::instance(), &QCoreApplication::applicationNameChanged,
             this, &UCApplication::applicationNameChanged);
+
+    // Follow primary screen orientation changes
+    QGuiApplication::primaryScreen()->setOrientationUpdateMask(
+            Qt::PortraitOrientation |
+            Qt::LandscapeOrientation |
+            Qt::InvertedPortraitOrientation |
+            Qt::InvertedLandscapeOrientation);
+    connect(QGuiApplication::primaryScreen(), &QScreen::orientationChanged,
+            this, &UCApplication::orientationChanged);
 }
 
 void UCApplication::setContext(QQmlContext* context) {
@@ -73,3 +87,29 @@
     QCoreApplication::setOrganizationDomain(applicationName);
 }
 
+/*!
+ * \qmlproperty Qt.ScreenOrientation Application::orientation
+ * \internal
+ * The current orientation of the application - can be overridden manually for testing.
+ */
+Qt::ScreenOrientation UCApplication::orientation() {
+    if (m_orientation == FOLLOW_SCREEN_ORIENTATION) {
+        return QGuiApplication::primaryScreen()->orientation();
+    } else {
+        return static_cast<Qt::ScreenOrientation>(m_orientation);
+    }
+}
+
+void UCApplication::setOrientation(Qt::ScreenOrientation orientation) {
+    if (m_orientation == FOLLOW_SCREEN_ORIENTATION) {
+        // we're now in manual override mode
+        disconnect(QGuiApplication::primaryScreen(), &QScreen::orientationChanged,
+                this, &UCApplication::orientationChanged);
+    }
+
+    if (m_orientation != orientation) {
+        m_orientation = orientation;
+        Q_EMIT orientationChanged(orientation);
+    }
+}
+

=== modified file 'modules/Ubuntu/Components/plugin/ucapplication.h'
--- modules/Ubuntu/Components/plugin/ucapplication.h	2013-10-18 08:56:39 +0000
+++ modules/Ubuntu/Components/plugin/ucapplication.h	2015-06-18 17:57:10 +0000
@@ -28,6 +28,7 @@
 {
     Q_OBJECT
     Q_PROPERTY(QString applicationName READ applicationName WRITE setApplicationName NOTIFY applicationNameChanged)
+    Q_PROPERTY(Qt::ScreenOrientation orientation READ orientation WRITE setOrientation NOTIFY orientationChanged)
 
 private:
     Q_DISABLE_COPY(UCApplication)
@@ -42,16 +43,20 @@
 
     // getter
     QString applicationName();
+    Qt::ScreenOrientation orientation();
 
     // setter
     void setContext(QQmlContext* context);
     void setApplicationName(const QString& applicationName);
+    void setOrientation(Qt::ScreenOrientation orientation);
 
 private:
     QQmlContext* m_context;
+    int m_orientation;
 
 Q_SIGNALS:
     void applicationNameChanged();
+    void orientationChanged(Qt::ScreenOrientation orientation);
 };
 
 #endif // UBUNTU_COMPONENTS_I18N_H

=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py'
--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py	2015-04-14 21:02:06 +0000
+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py	2015-06-18 17:57:10 +0000
@@ -56,6 +56,19 @@
 
         return False
 
+    def set_orientation(self, orientation):
+        self.select_single(
+            objectName='MainViewBaseStyledItem').slots.setOrientation(
+                orientation)
+        orientationHelper = self.select_single(objectName='canvas')
+        orientationHelper.select_single(
+            objectName='d').flipDimensions.wait_for(True)
+
+    @property
+    def orientation(self):
+        return self.select_single(
+            objectName='MainViewBaseStyledItem').orientation
+
     def get_header(self):
         """Return the AppHeader custom proxy object of the MainView."""
         try:

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_popover.py'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_popover.py	2015-04-14 21:02:06 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_popover.py	2015-06-18 17:57:10 +0000
@@ -18,9 +18,53 @@
 
 import os
 
+from autopilot.matchers import Eventually
+from testtools.matchers import Equals
 from ubuntuuitoolkit import tests
 
 
+class PopoverRotateTestCase(tests.QMLFileAppTestCase):
+
+    path = os.path.abspath(__file__)
+    dir_path = os.path.dirname(path)
+    test_qml_file_path = os.path.join(
+        dir_path, 'test_popover.qml')
+
+    scenarios = [
+        ('Popover', dict(buttonName='button', popoverName='popover')),
+        ('Small dialog', dict(buttonName='button_small',
+                              popoverName='dialog_small')),
+        ('Huge dialog', dict(buttonName='button_huge',
+                             popoverName='dialog_huge')),
+    ]
+
+    def setUp(self):
+        super(PopoverRotateTestCase, self).setUp()
+
+    def rotate(self, orientation):
+        self.main_view.set_orientation(orientation)
+        self.assertThat(self.main_view.orientation,
+                        Eventually(Equals(orientation)))
+
+    def open_popover(self):
+        button = self.main_view.select_single(objectName=self.buttonName)
+        self.pointing_device.click_object(button)
+
+    def assert_popover_orientation(self):
+        popover = self.main_view.wait_select_single(
+            objectName=self.popoverName)
+        self.assertEqual(popover.rotation, self.main_view.select_single(
+            'OrientationHelper').rotation)
+
+    def test_rotate(self):
+        if self.main_view.orientation == 'portrait':
+            self.rotate('landscape')
+        else:
+            self.rotate('portrait')
+        self.open_popover()
+        self.assert_popover_orientation()
+
+
 class DialogScrollTestCase(tests.QMLFileAppTestCase):
 
     path = os.path.abspath(__file__)

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_popover.qml'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_popover.qml	2015-03-03 13:20:06 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_popover.qml	2015-06-18 17:57:10 +0000
@@ -15,18 +15,30 @@
  */
 
 import QtQuick 2.0
-import Ubuntu.Components 1.1
-import Ubuntu.Components.Popups 1.0
+import Ubuntu.Components 1.3
+import Ubuntu.Components.Popups 1.3
+import Ubuntu.Test 1.0
 
 MainView {
-    width: units.gu(48)
-    height: units.gu(60)
+    id: root
+    width: units.gu(60)
+    height: units.gu(40)
     objectName: "mainView"
 
+    automaticOrientation: true
+
     Page {
         title: "Popover"
 
         Column {
+            anchors.top: parent.top
+            anchors.bottom: parent.bottom
+
+            Button {
+                objectName: "button"
+                text: "Pop over"
+                onClicked: PopupUtils.open(popoverComponent)
+            }
             Button {
                 objectName: "button_small"
                 text: "Small"
@@ -37,15 +49,54 @@
                 text: "Huge"
                 onClicked: PopupUtils.open(hugeDialogComponent)
             }
+            Button {
+                text: "Landscape"
+                onClicked: UbuntuApplication.orientation = Qt.LandscapeOrientation;
+            }
+            Button {
+                text: "Portrait"
+                onClicked: UbuntuApplication.orientation = Qt.PortraitOrientation;
+            }
+        }
+
+        Component {
+            id: popoverComponent
+            Popover {
+                objectName: "popover"
+                Column {
+                    Button {
+                        text: "Just a button"
+                        onClicked: {
+                            if (UbuntuApplication.orientation === Qt.LandscapeOrientation) {
+                                UbuntuApplication.orientation = Qt.PortraitOrientation;
+                            } else {
+                                UbuntuApplication.orientation = Qt.LandscapeOrientation
+                            }
+                        }
+                    }
+                }
+            }
         }
 
         Component {
             id: smallDialogComponent
             Dialog {
+                id: smallDialog
                 objectName: "dialog_small"
-                Column {
+                Row {
                     Button {
                         text: "Just a button"
+                        onClicked: {
+                            if (UbuntuApplication.orientation === Qt.LandscapeOrientation) {
+                                UbuntuApplication.orientation = Qt.PortraitOrientation;
+                            } else {
+                                UbuntuApplication.orientation = Qt.LandscapeOrientation
+                            }
+                        }
+                    }
+                    Button {
+                        text: "close"
+                        onClicked: PopupUtils.close(smallDialog)
                     }
                 }
             }

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml	2015-05-29 17:35:52 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml	2015-06-18 17:57:10 +0000
@@ -15,7 +15,7 @@
  */
 
 import QtQuick 2.0
-import Ubuntu.Components 1.2
+import Ubuntu.Components 1.3
 
 MainView {
     id: root

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py	2015-06-03 15:09:52 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py	2015-06-18 17:57:10 +0000
@@ -174,6 +174,32 @@
         self.assertTrue(popover.globalRect.y > 0,
                         '%s <= 0' % popover.globalRect.y)
 
+    def rotate(self, orientation):
+        self.main_view.set_orientation(orientation)
+
+    def open_context_menu(self):
+        self.pointing_device.click_object(self.textfield)
+        cursor = self.select_cursor('cursorPosition')
+        self.pointing_device.click_object(cursor)
+
+    def assert_context_menu_orientation(self):
+        popover = self.main_view.get_text_input_context_menu(
+            'text_input_contextmenu')
+        self.assertEqual(popover.rotation, self.main_view.select_single(
+            'OrientationHelper').rotation)
+
+    def test_rotate(self):
+        # https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1443358
+        if self.test_qml_file_path != self.textfield_qml_file_path:
+            self.skipTest('FIXME: Header behavior breaks some rotation cases')
+
+        if self.main_view.orientation == 'portrait':
+            self.rotate('landscape')
+        else:
+            self.rotate('portrait')
+        self.open_context_menu()
+        self.assert_context_menu_orientation()
+
     def test_header_undisturbed_by_text_handlers(self):
         # Verify that handlers aren't accidentally placed at absolute 0/0
         self.pointing_device.click_object(self.textfield)

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml	2015-03-10 16:29:24 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml	2015-06-18 17:57:10 +0000
@@ -15,13 +15,15 @@
  */
 
 import QtQuick 2.0
-import Ubuntu.Components 1.2
+import Ubuntu.Components 1.3
 
 MainView {
     width: units.gu(48)
     height: units.gu(60)
     objectName: "mainView"
 
+    automaticOrientation: true
+
     Page {
         title: "Textarea"
         head.backAction: Action {

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml	2015-03-10 16:29:24 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml	2015-06-18 17:57:10 +0000
@@ -15,13 +15,15 @@
  */
 
 import QtQuick 2.0
-import Ubuntu.Components 1.2
+import Ubuntu.Components 1.3
 
 MainView {
-    width: units.gu(48)
-    height: units.gu(60)
+    width: units.gu(60)
+    height: units.gu(40)
     objectName: "mainView"
 
+    automaticOrientation: true
+
     Page {
         title: "Textfield"
         head.backAction: Action {
@@ -31,11 +33,17 @@
         }
 
         Column {
+            anchors.top: parent.top
+            spacing: units.gu(2)
+
             TextField {
                 objectName: "textfield"
                 placeholderText: "Type here"
                 width: units.gu(35)
             }
+            Label {
+                text: i18n.tr("Text fields are awesome")
+            }
         }
     }
 }

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml'
--- tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml	2015-03-10 16:29:24 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml	2015-06-18 17:57:10 +0000
@@ -15,7 +15,7 @@
  */
 
 import QtQuick 2.0
-import Ubuntu.Components 1.2
+import Ubuntu.Components 1.3
 import Ubuntu.Components.Themes.Ambiance 1.1
 
 MainView {
@@ -23,6 +23,8 @@
     height: units.gu(60)
     objectName: "mainView"
 
+    automaticOrientation: true
+
     Page {
         title: "Textfield"
         head.backAction: Action {

=== added file 'tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.orientation.qml'
--- tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.orientation.qml	1970-01-01 00:00:00 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.orientation.qml	2015-06-18 17:57:10 +0000
@@ -0,0 +1,29 @@
+/*
+ * Copyright 2015 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.3
+import Ubuntu.Components 1.3
+
+MainView {
+    width: units.gu(48)
+    height: units.gu(60)
+    objectName: "mainView"
+    automaticOrientation: true
+
+    Page {
+        title: i18n.tr('Orientation')
+    }
+}

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py'
--- tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py	2015-04-14 21:02:06 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py	2015-06-18 17:57:10 +0000
@@ -15,6 +15,7 @@
 # along with this program. If not, see <http://www.gnu.org/licenses/>.
 
 from unittest import mock
+import os
 
 import ubuntuuitoolkit
 from ubuntuuitoolkit import tests
@@ -75,6 +76,37 @@
             str(error), 'The MainView has no Tabs.')
 
 
+class MainViewOrientationTestCase(tests.QMLFileAppTestCase):
+
+    path = os.path.abspath(__file__)
+    dir_path = os.path.dirname(path)
+    test_qml_file_path = os.path.join(
+        dir_path, 'test_main_view.orientation.qml')
+
+    def test_set_orientation(self):
+        if self.main_view.orientation == 'portrait':
+            self.rotate('landscape')
+            self.assert_main_view_orientation('landscape')
+        else:
+            self.rotate('portrait')
+            self.assert_main_view_orientation('portrait')
+
+    def rotate(self, orientation):
+        self.main_view.set_orientation(orientation)
+
+    def normalizedAngle(self, angle):
+        # Same orientation maps to different angles on different devices
+        if angle in [-90, 270]:
+            return 90
+        return angle
+
+    def assert_main_view_orientation(self, orientation):
+        helper = self.main_view.select_single('OrientationHelper')
+        self.assertEqual(self.normalizedAngle(helper.rotation),
+                         self.normalizedAngle(helper.orientationAngle))
+        self.assertEqual(self.main_view.orientation, orientation)
+
+
 class MainView12TestCase(tests.QMLStringAppTestCase):
 
     test_qml = ("""