Ubuntu UI Toolkit

Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual

  1. orientationManual
  2. Merge into staging
Revision history for this message
Tim Peeters (tpeeters) wrote :

118 + do {
119 + orientationHelper = orientationHelper.parent;
120 + } while (orientationHelper && !orientationHelper.automaticOrientation && orientationHelper != null);

isn't orientationHelper != null already implied by orientationHelper? Anyway it would be weird to put the != null in the end.

Also, if you are looking for orientationHelper, you should be checking orientationHelper.hasOwnProperty("automaticOrientation"), not the value of automaticOrientation.

review: Needs Fixing

« Back to merge proposal