Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual

Revision history for this message
Cris Dywan (kalikiana) wrote :

I addressed all the naming suggestions, made the set_orientation function public and added a test for it. Note there's no actual way to verify rotation and as such absent from the cpo test because one of the orientations is always a no-op depending on the primary orientation and the real tests don't need to be aware of it… after having written this I actually convinced myself that this isn't acceptable… I'll have to look into a way to address this.

« Back to merge proposal