Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual

Revision history for this message
Cris Dywan (kalikiana) wrote :

> 324 + # Give rendering a chance to finish
> 325 + time.sleep(2)
>
> Here you would call the proper waitForOrientationChange() function that I
> suggested above.
>
> Anyway I think if you physically rotate a device, the rotation animation is
> more than 2ms.

I added a rotating.wait_for. But it's not apparently enough for AP to update its coordinate space when the animation is in fact finished. So I left a sleep(1), not sure what else I could check for here. The one for the cursor is in fact unnecessary, though, so I removed it.

« Back to merge proposal