Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual

Revision history for this message
Tim Peeters (tpeeters) wrote :

nevermind that^ comment. Got it.

> 63 - /*
> 64 - The attached property Screen.orientation is only valid inside
> Item or
> 65 - derived components. Inside Object it evaluates to 0 with no
> error.
> 66 - Also be aware that some apps eg. webbrowser-app set
> window.contentOrientation
> 67 - and thus can hide failure to update it from this code.
> 68 - See http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick-
> window2-screen.html
> 69 - */
>
> (why) is this comment no longer valid?
>
> The link would require an update though.

« Back to merge proposal