Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/orientationManual

Revision history for this message
Tim Peeters (tpeeters) wrote :

264 + def set_orientation(self, orientation):
265 + self.select_single(
266 + objectName='MainViewBaseStyledItem').slots.setOrientation(
267 + orientation)
268 + self.select_single('OrientationHelper').rotating.wait_for(False)
269 + # Short delay to ensure introspection is uptodate
270 + time.sleep(1)

I wonder if the problem here is that when you do the wait_for, perhaps the value of the property was not updated to be True yet? In that case it is better to add the sleep(1) before the wait_for.

« Back to merge proposal