Merge lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash | ||||
Merge into: | lp:ubuntu-filemanager-app | ||||
Diff against target: |
196 lines (+47/-4) 7 files modified
src/plugin/folderlistmodel/diriteminfo.cpp (+19/-0) src/plugin/folderlistmodel/diriteminfo.h (+6/-0) src/plugin/folderlistmodel/iorequestworker.cpp (+7/-0) src/plugin/folderlistmodel/location.cpp (+0/-1) src/plugin/folderlistmodel/location.h (+0/-1) src/plugin/folderlistmodel/networklistworker.cpp (+10/-1) src/plugin/folderlistmodel/networklistworker.h (+5/-1) |
||||
To merge this branch: | bzr merge lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Needs Fixing | |
Renato Araujo Oliveira Filho (community) | Disapprove | ||
Carlos Jose Mazieri | Needs Information | ||
Review via email: mp+314870@code.launchpad.net |
Commit message
Make sure that NetworkListWorker get invalidated if the parent DirItemInfo was destroyed.
App was crashing because DirItemInfo was destroyed and NetworkListWorker was trying to use an invalid pointer.
To post a comment you must log in.
Unmerged revisions
- 588. By Renato Araujo Oliveira Filho
-
Remove unused code.
Check for parent before use it. - 587. By Renato Araujo Oliveira Filho
-
Fix grammar.
- 586. By Renato Araujo Oliveira Filho
-
Remove extra debug messages.
- 585. By Renato Araujo Oliveira Filho
-
Fixed memory leak;
Make sure that works are deleted.
- 584. By Renato Araujo Oliveira Filho
-
Avoid crash when aborting a network operation.
Clear parent pointer on worker if parent get destroyed.
Can you explain how this change addresses the issue?