Code review comment for lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash

Arto Jalkanen (ajalkane) wrote :

I'm a bit dumbfounded that this kind of Qt metaprogramming would be necessary for solving a problem as basic as what we have here. At the minimum I think this code would need to be commented, because if anyone stumbles upon this code in the future it'd be a big WTF moment without clarifying comments. Comments should explain what it fixes, why it had to be done this way.

« Back to merge proposal