Code review comment for lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash

Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

Renato,

The check in line 61 is necessary.

The 'parentItemInfo' keeps the information from the parent, which can be: directory/share/host/workgroup.

When the 'mainItemInfo' is root like "smb://" there is no 'parentItemInfo', it can be null.

Another reason it might be used in my regression tests (I am not sure if it is), you can use if you want its in "src/plugin/test_folderlistmodel/regression/regression_folderlilstmodel.pro"

« Back to merge proposal