Code review comment for lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash

> I'm a bit dumbfounded that this kind of Qt metaprogramming would be necessary
> for solving a problem as basic as what we have here. At the minimum I think
> this code would need to be commented, because if anyone stumbles upon this
> code in the future it'd be a big WTF moment without clarifying comments.
> Comments should explain what it fixes, why it had to be done this way.

The Qt metaprogramming make things easy here. Avoid big changes. Without that we will need to keep a list of child objects on the parent and invalidate all the children when parent get destroyed.

Instead of that I am keep all the changes on child object and keeping track of parent life. Any suggestion are welcome.

« Back to merge proposal