Ubuntu File Manager App

Code review comment for lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash

  1. fix-network-crash
  2. Merge into trunk
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Renato,
>
> Can you please test that proposal of that NetworkListWorker creating its own
> instance of the parent item?
>
> There is a proposal https://code.launchpad.net/~carlos-mazieri/ubuntu-
> filemanager-app//fix-network-crash-1609051
>
> Also renamed "parent" to "parentItemInfo".

Thanks, Carlos will be a pleasure test that.

But as mentioned before if the parent get destroyed the operation will not be canceled and will be executed until the end. (In my opinion this is a wast of resources, but if you are ok with that)

Based on that information I do not think you need to check for (m_parentItemInfo != 0) in line 61. Since m_parentItemInfo will never be null.

Reply

« Back to merge proposal