Merge lp:~james-page/charms/trusty/rabbitmq-server/network-splits into lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next
Proposed by
James Page
Status: | Merged |
---|---|
Merged at revision: | 80 |
Proposed branch: | lp:~james-page/charms/trusty/rabbitmq-server/network-splits |
Merge into: | lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next |
Diff against target: |
144 lines (+39/-9) 5 files modified
Makefile (+3/-3) config.yaml (+9/-0) hooks/rabbitmq_server_relations.py (+19/-4) test-requirements.txt (+2/-0) unit_tests/test_rabbitmq_server_relations.py (+6/-2) |
To merge this branch: | bzr merge lp:~james-page/charms/trusty/rabbitmq-server/network-splits |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Liam Young (community) | Approve | ||
Cory Johns | Pending | ||
Tim Van Steenburgh | Pending | ||
James Page | Pending | ||
Review Queue | automated testing | Pending | |
Review via email: mp+247384@code.launchpad.net |
This proposal supersedes a proposal from 2014-07-24.
Description of the change
Add support for separate 'access-network' configuration.
To post a comment you must log in.
Hi James,
Thanks for this. Code review looks good, but I'm unsure how to do a functional test of this, can you provide instructions?
Also, there are some charm-proof warnings to clean up:
W: config.yaml: option access-network does not have the keys: default
W: config.yaml: option key does not have the keys: default
W: config.yaml: option source does not have the keys: default
Thanks!