Code review comment for lp:~james-page/charms/trusty/rabbitmq-server/network-splits

Revision history for this message
James Page (james-page) wrote :

charm proof is wrong - sorry I've discussed this numerous times with Marco - not providing a default value is a perfectly acceptable situation and is used extensively in my charms - Marco did at least drop this to a warning rather than an error but I'm not re-writing all of my charms to comply with a policy that I believe is wrong in this case.

review: Needs Resubmitting

« Back to merge proposal