Juju Charms Collection
rabbitmq-server package

Code review comment for lp:~james-page/charms/trusty/rabbitmq-server/network-splits

  1. Trusty Tahr (14.04)
  2. network-splits
  3. Merge into trunk
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

Hi James,

Thanks for this. Code review looks good, but I'm unsure how to do a functional test of this, can you provide instructions?

Also, there are some charm-proof warnings to clean up:

W: config.yaml: option access-network does not have the keys: default
W: config.yaml: option key does not have the keys: default
W: config.yaml: option source does not have the keys: default

Thanks!

review: Needs Fixing

« Back to merge proposal