Code review comment for lp:~james-page/charms/trusty/rabbitmq-server/network-splits

Revision history for this message
James Page (james-page) wrote :

Hi Tim

https://code.launchpad.net/~openstack-charmers/+junk/network-splits contains some helpers for testing; however basically you need servers with more than one configured network interface.

RE the charm proof warning; not touching those - not having a default key is intentional 'unset' being a valid state. The code works on the fact that a config-get on unset keys returns None in JSON.

review: Needs Resubmitting

« Back to merge proposal