Code review comment for lp:~james-page/charms/trusty/rabbitmq-server/network-splits

Revision history for this message
Cory Johns (johnsca) wrote :

James,

I believe that Tim's point was that the policy was that you still need to provide a default value, even if that value is an empty string. No warnings on `charm proof` is listed on the policy: https://juju.ubuntu.com/docs/authors-charm-policy.html

Also, my understanding of the "Resubmit" status was that the review was rejected and would need to be resubmitted to be approved; is that not the case?

review: Needs Fixing

« Back to merge proposal