Merge lp:~diegosarmentero/ubuntu-system-settings/check-hash into lp:ubuntu-system-settings

[Diego Sarmentero]

- Check click hash

To test this branch in the device you can set the environment variable URL_APPS to http://localhost:8000/iteminfo/ (best to do it in /etc/environments and restart). Then execute the python script added in this branch, and open System Updates to see an update on the calculator, which should fail because of the invalid hash

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1054
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1582/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5337
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3850
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/774
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5049
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6589
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6589/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13944
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4163
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4163/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1582/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

Thanks, that looks fine to me but do you have any hint on how to test the change?

review: Needs Information

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1055
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1616/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5618/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3976/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/808/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6870/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4303/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1616/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1058
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1619/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5626/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3982/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/811/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6878/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4309/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1619/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1055
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1620/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5628/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3984/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/812/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6880/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4311/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1620/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1059
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1622/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5669
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3993
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/814
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5346
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6921
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6921/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14337
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3362
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4320
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4320/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1622/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1060
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1625/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5680
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3997
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/817
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5352
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6932
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6932/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14347
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3366
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4324
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4324/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1625/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1061
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1626/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5685
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4000
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/818
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5356
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6937
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6937/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14351
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3369
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4327
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4327/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1626/rebuild

review: Approve (continuous-integration)

[lp:~diegosarmentero/ubuntu-system-settings/check-hash]

1055. By Diego Sarmentero on 2014-10-16

fixing click update sign flow

1056. By Diego Sarmentero on 2014-10-16

remove unnecesary use of secondary urls

1057. By Diego Sarmentero on 2014-10-16

[ jonas-drange ]
* [wifi/phone] dynamically chooses what SIM to use when there's only
  one present. (LP: #1375832)
[ Iain Lane ]
* [storage/about] Use a QSharedPointer to manage freeing of the
  counter which we use to display all of the collected sizes at once.
  If the measuring process was cancelled, we were freeing it multiple
  times - once for each outstanding size measurement. This led to a
  crash. (LP: #1375988)
* [security-privacy] Link with gobject, uses symbols from this
  library. Prevents "[…]libUbuntuSecurityPrivacyPanel.so contains an
  unresolvable reference to symbol
  g_signal_handlers_disconnect_matched: it's probably a plugin"
  warnings.
[ jonas-drange ]
* [cellular] react to application.state changes and update potential
  out-of-date default SIM settings (LP: #1364103)
* [wifi] let removed networks update the previous network model so
  that we can reuse the model (and not pop the pagestack twice,
  causing this ux issue) (LP: #1370389)
[ Sebastien Bacher ]
* [location] use a flickable so the list can be scrolled (LP:
  #1374017)
* [security] get localized application names from the trust-store (LP:
  #1374018)
[ Ken VanDine ]
* Fixed handling of the Downloading/Installing label based on actual
  state. . Forward updateProgress signals for system updates. Layout
  fixes (LP: #1312587)
* Use new splash screen (LP: #1376242)
* Improved tracking download states
* Use new target_build_number from system-image-dbus to determine
  visibility of the update notification (LP: #1355803)
[ CI bot ]
* Resync trunk
[ Sebastien Bacher ]
* [storage] use libclick rather than calling the command line (LP:
  #1368967)
* [storage] tweaks to the disk informations, limit the free space to
  the user available one (excluding the system partitions), don't list
  the external mounts, that's described in the design and is going to
  require work on the categories computation to give correct values
  (LP: #1284247)
* [about] display the free space value next to the storage label (LP:
  #1335144)
[ Albert Astals ]
* Add i18n.tr
[ jonas-drange ]
* [wifi] connect to hidden network is now a dialog (LP: #1366005)
[ Ken VanDine ]
* Provide more keywords to make search useful (LP: #1370219) (LP:
  #1370219)
* [background] set sourceSize in the image preview to work around an
  issue loading large images (LP: #1373462)
[ CI bot ]
* Resync trunk
[ Mathieu Trudel-Lapierre ]
* [bluetooth] Properly handle device types for connection and
  disconnection. (LP: #1369964)
[ Michael Terry ]
* Add a translator comment for what HERE means. (LP: #1368838) (LP:
  #1368838)
* Prevent a crash in unity8 when the wizard also crashes or stops
  early. (LP: #1355892) (LP: #1355892)
[ Michael Terry ]
* Prevent the buttons of the wizard's password page from overlapping
  its content when the OSK appears. (LP: #1368346) (LP: #1368346)
[ Ken VanDine ]
* Set the version information in the SystemUpdate constructor (LP:
  #1371810) (LP: #1371810)
* [reset] Don't bail out on an isValid() check on the SystemImage
  QDBusInterface, the docs say isValid() may not be reliable for
  remote interfaces (LP: #1370815) (LP: #1370815)
* Fixed reference error for count on the various device models (LP:
  #1362517) (LP: #1362517)
* [background] Use the ContentPeerPicker to select sources for
  backgrounds (LP: #1356542) (LP: #1356542)
[ Iain Lane ]
* Don't check if the timedated interface is valid before calling
  SetTime on it, it might have timed out and we should reactivate it
  in that case.
* [about] Fix developerMode property to be QMLish - read & write
  instead of separate "read" and "toggle" properties.
* [about] Don't display a frame for icons that can't be found,
  improving the visual appearance. Also return the correct path for
  click packages which use the icon theme.
[ Sebastien Bacher ]
* [storage] handle the scope click .ini and get the correct icons (LP:
  #1368920)
[ Albert Astals ]
* make pot
[ Oliver Grawert ]
* fix LP: #1365903, add a watch to Developer Mode page so the page
  gets refreshed when going back through the page stack, also fix the
  page id and bounds (LP: #1365903)
* Some packaging fixes
  - > is not a valid relationship. It should be >>
  - Don't recommend suru-icon-theme since we also depend on it
  - Bump S-V to 3.9.6 which for example allows the images we ship in
    /usr/lib/
  - Override binary-no-manpage lintian warnings. We're not going to get man
    pages for u-s-s any time soon
[ Ken VanDine ]
* Make UpdateManager a singleton and refresh the availableUpdates
  count when the model updates (LP: #1325629) (LP: #1325629)
[ Ken VanDine ]
* Include an icon instead of using the themed icon (LP: #1365408) (LP:
  #1365408)
[ Mathieu Trudel-Lapierre ]
* [bluetooth] don't try to enable Discoverable if the device isn't
  powered yet. (LP: #1355904)
[ Ken VanDine ]
* When activated by a url request for a specific panel, clear the
  pageStack to maintain the natural navigation instead of pushing a
  new page on top of a page from a the previous panel (LP: #1362025)
  (LP: #1362025, #1359953)
[ Lars Uebernickel ]
* Use Icon instead of StatusIcon
[ CI bot ]
* Resync trunk
[ John R. Lenton ]
* Take the system settings push helper closer to implementing the spec
  at https://wiki.ubuntu.com/SoftwareUpdates#Prompting (LP: #1363972)

1058. By Diego Sarmentero on 2014-10-17

improve resume for tracker

[Charles Kerr (charlesk)]

The code looks good for getting the checksum and making it available to QML, but unless I'm misreading, it doesn't take the final step of showing it to the user?

[Diego Sarmentero (diegosarmentero)]

> The code looks good for getting the checksum and making it available to QML,
> but unless I'm misreading, it doesn't take the final step of showing it to the
> user?

Yes, the Download Manager will check the checksum after the download is complete, and if that fails it will emit an Error signal with the text that is going to be displayed in the Update item in the UI.

[Sebastien Bacher (seb128)]

not sure why CI didn't do a build of the current revision, I gave it a retry...
the code looks fine other

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1153
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1690/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6212
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/882
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5833
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7464
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7464/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15063
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3556
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4567
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4567/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1690/rebuild

review: Approve (continuous-integration)

[Sebastien Bacher (seb128)]

running the testcase is not working, the test server displays those error

  File "/tmp/mock_update_click_server.py", line 31, in response_item_info
    self.wfile.write(bytes(json.dumps(response), 'UTF-8'))
  File "/usr/lib/python3.4/socket.py", line 391, in write
    return self._sock.send(b)
BrokenPipeError: [Errno 32] Broken pipe

The UI displays a bar going to 100% but no error

=== modified file 'plugins/system-update/PageComponent.qml'
--- plugins/system-update/PageComponent.qml	2014-10-08 15:51:44 +0000
+++ plugins/system-update/PageComponent.qml	2014-10-17 11:45:42 +0000
@@ -420,17 +420,18 @@
 
                     function resume () {
                         console.warn("RESUME: " + modelData.packageName);
-                        if (modelData.systemUpdate)
-                            return UpdateManager.startDownload(modelData.packageName);
-                        modelData.updateState = true;
-                        tracker.resume();
+                        UpdateManager.startDownload(modelData.packageName);
                     }
 
                     function start () {
                         console.warn("START: " + modelData.packageName);
+                        if (!modelData.selected || modelData.systemUpdate) {
+                            UpdateManager.startDownload(modelData.packageName);
+                        } else {
+                            tracker.resume();
+                        }
                         modelData.selected = true;
                         modelData.updateState = true;
-                        UpdateManager.startDownload(modelData.packageName);
                     }
                     Column {
                         id: textArea
@@ -561,6 +562,7 @@
                                 packageName: modelData.packageName
                                 clickToken: modelData.clickToken
                                 download: modelData.downloadUrl
+                                downloadSha512: modelData.downloadSha512
 
                                 onFinished: {
                                     progress.visible = false;

=== modified file 'plugins/system-update/download_tracker.cpp'
--- plugins/system-update/download_tracker.cpp	2014-09-30 02:05:36 +0000
+++ plugins/system-update/download_tracker.cpp	2014-10-17 11:45:42 +0000
@@ -27,6 +27,7 @@
 #define DOWNLOAD_COMMAND "post-download-command"
 #define APP_ID "app_id"
 #define PKCON_COMMAND "pkcon"
+#define DOWNLOAD_MANAGER_SHA512 "sha512"
 
 namespace UpdatePlugin {
 
@@ -81,7 +82,7 @@
         vmap[APP_ID] = m_packageName;
         StringMap map;
         map[X_CLICK_TOKEN] = m_clickToken;
-        DownloadStruct dstruct = DownloadStruct(m_downloadUrl, vmap, map);
+        DownloadStruct dstruct = DownloadStruct(m_downloadUrl, m_download_sha512, DOWNLOAD_MANAGER_SHA512, vmap, map);
         m_manager->createDownload(dstruct);
     }
 }

=== modified file 'plugins/system-update/download_tracker.h'
--- plugins/system-update/download_tracker.h	2014-09-30 02:05:36 +0000
+++ plugins/system-update/download_tracker.h	2014-10-17 11:45:42 +0000
@@ -42,6 +42,7 @@
     Q_PROPERTY(QString clickToken READ clickToken WRITE setClickToken)
     Q_PROPERTY(QString download READ download WRITE setDownload)
     Q_PROPERTY(QString packageName READ packageName WRITE setPackageName)
+    Q_PROPERTY(QString downloadSha512 READ downloadSha512 WRITE setDownloadSha512)
     Q_PROPERTY(int progress READ progress NOTIFY progressChanged)
 
 public:
@@ -54,10 +55,12 @@
     QString download() { return m_downloadUrl; }
     QString clickToken() { return m_clickToken; }
     QString packageName() { return m_packageName; }
+    QString downloadSha512() { return m_download_sha512; }
+    int progress() { return m_progress; }
     void setDownload(const QString& url);
     void setClickToken(const QString& token);
     void setPackageName(const QString& package);
-    int progress() { return m_progress; }
+    void setDownloadSha512(const QString &sha512) { m_download_sha512 = sha512; }
 
 public Q_SLOTS:
     void bindDownload(Download* download);
@@ -82,6 +85,7 @@
     Download* m_download;
     Manager* m_manager;
     int m_progress;
+    QString m_download_sha512;
 
     void startService();
     QString getPkconCommand();

=== modified file 'plugins/system-update/network/network.cpp'
--- plugins/system-update/network/network.cpp	2014-09-18 13:50:15 +0000
+++ plugins/system-update/network/network.cpp	2014-10-17 11:45:42 +0000
@@ -107,6 +107,7 @@
                     QString version = object.value("version").toString();
                     QString icon_url = object.value("icon_url").toString();
                     QString url = object.value("download_url").toString();
+                    QString download_sha512 = object.value("download_sha512").toString();
                     int size = object.value("binary_filesize").toVariant().toInt();
                     if (m_apps.contains(name)) {
                         m_apps[name]->setRemoteVersion(version);
@@ -114,6 +115,7 @@
                             m_apps[name]->setIconUrl(icon_url);
                             m_apps[name]->setDownloadUrl(url);
                             m_apps[name]->setBinaryFilesize(size);
+                            m_apps[name]->setDownloadSha512(download_sha512);
                             updates = true;
                         }
                     }

=== modified file 'plugins/system-update/update.cpp'
--- plugins/system-update/update.cpp	2014-09-12 23:47:39 +0000
+++ plugins/system-update/update.cpp	2014-10-17 11:45:42 +0000
@@ -29,6 +29,7 @@
     QObject(parent),
     m_binary_filesize(0),
     m_click_url(""),
+    m_clickToken(""),
     m_downloadUrl(""),
     m_download_progress(0),
     m_error(""),

=== modified file 'plugins/system-update/update.h'
--- plugins/system-update/update.h	2014-09-12 19:12:36 +0000
+++ plugins/system-update/update.h	2014-10-17 11:45:42 +0000
@@ -57,6 +57,7 @@
                NOTIFY downloadProgressChanged)
     Q_PROPERTY(QString downloadUrl READ downloadUrl NOTIFY downloadUrlChanged)
     Q_PROPERTY(QString clickToken READ clickToken NOTIFY clickTokenChanged)
+    Q_PROPERTY(QString downloadSha512 READ downloadSha512 NOTIFY downloadSha512Changed)
 
 Q_SIGNALS:
     void systemUpdateChanged();
@@ -75,6 +76,7 @@
     void downloadUrlChanged();
     void clickTokenChanged();
     void packageNameChanged();
+    void downloadSha512Changed();
 
 public:
     explicit Update(QObject *parent = 0);
@@ -97,6 +99,7 @@
     const QString& getClickUrl() const { return m_click_url; }
     QString downloadUrl() { return m_downloadUrl; }
     QString clickToken() { return m_clickToken; }
+    QString downloadSha512() { return m_download_sha512; }
 
     void setSystemUpdate(bool isSystem);
     void initializeApplication(QString packagename, QString title,
@@ -115,6 +118,7 @@
     void setClickUrl(const QString &url) { m_click_url = url; }
     void setDownloadUrl(const QString &url);
     void setClickToken(const QString &token) { m_clickToken = token; Q_EMIT clickTokenChanged(); }
+    void setDownloadSha512(const QString &sha512) { m_download_sha512 = sha512; Q_EMIT downloadSha512Changed(); }
 
 private:
     int m_binary_filesize;
@@ -134,6 +138,7 @@
     bool m_update;
     bool m_update_ready;
     bool m_update_state;
+    QString m_download_sha512;
 
     bool getIgnoreUpdates();
 };

=== modified file 'plugins/system-update/update_manager.cpp'
--- plugins/system-update/update_manager.cpp	2014-10-08 15:51:44 +0000
+++ plugins/system-update/update_manager.cpp	2014-10-17 11:45:42 +0000
@@ -321,7 +321,6 @@
 {
     app->setError("");
     app->setClickToken(clickToken);
-    app->setDownloadUrl(app->getClickUrl());
 }
 
 void UpdateManager::updateClickScope()

=== added file 'tests/autopilot/ubuntu_system_settings/utils/mock_update_click_server.py'
--- tests/autopilot/ubuntu_system_settings/utils/mock_update_click_server.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/ubuntu_system_settings/utils/mock_update_click_server.py	2014-10-17 11:45:42 +0000
@@ -0,0 +1,60 @@
+import json
+import threading
+from http.server import BaseHTTPRequestHandler, HTTPServer
+
+
+KEEP_ALIVE = True
+
+
+class MyHandler(BaseHTTPRequestHandler):
+
+    def do_HEAD(self):
+        self.send_response(200)
+        self.send_header("X-Click-Token", "X-Click-Token")
+        self.end_headers()
+
+    def response_item_info(self):
+        response = [{
+            "name": "com.ubuntu.calculator",
+            "version": "9.0",
+            "icon_url": ("https://raw.githubusercontent.com/ninja-ide/"
+                         "ninja-ide/master/ninja_ide/img/ninja_icon.png"),
+            "download_url": ("https://public.apps.ubuntu.com/download/com."
+                             "ubuntu/calculator/com.ubuntu.calculator_1"
+                             ".3.329_all.click"),
+            "binary_filesize": 3423,
+            "download_sha512": "343244fsdfdsffs"
+        }]
+        self.send_response(200)
+        self.send_header("Content-type", "application/json")
+        self.end_headers()
+        self.wfile.write(bytes(json.dumps(response), 'UTF-8'))
+
+    def do_POST(self):
+        """Respond to a POST request."""
+        self.do_GET()
+
+    def do_GET(self):
+        """Respond to a GET request."""
+        if self.path.find("iteminfo/") != -1:
+            self.response_item_info()
+        elif self.path.find("shutdown") != -1:
+            global KEEP_ALIVE
+            KEEP_ALIVE = False
+
+
+def run_click_server():
+    server_address = ('', 8000)
+    httpd = HTTPServer(server_address, MyHandler)
+    global KEEP_ALIVE
+    print('start')
+    while KEEP_ALIVE:
+        httpd.handle_request()
+
+
+def run_mocked_settings():
+    t = threading.Thread(target=run_click_server)
+    t.start()
+
+
+run_mocked_settings()