Ubuntu Netbook Remix launcher support for right-to-left languages is lacking

plz make this a wishlist with medium? priority

Hi,

I'm trying to write a patch for this. I uploaded my attempt at this branch:
  https://code.launchpad.net/~haggai-eran/netbook-remix-launcher/rtl

The patch currently attempts to fix the first problem: the arrows of the sidebar being in the wrong direction. Still it has a problem that the sidebar is positioned a little outside of the displayed area, so its right side is cropped.

I'd be glad if anyone who knows the code will try it out (just run it under a right to left locale).

Thanks,
Haggai

Thanks a lot for your work there.
I didn't have the time to test it yet, but your works seems good.
I just have a question on commit 474:
- in file netbook-launcher/nl-sidebar-item.c, you are replacing gtk_widget_get_default_direction() by ctk_actor_get_default_direction() which was what you added at commit 472. Does using ctk_actor_set_default_direction change something in clutk behavior?

I'll try to give it a test today or tomorrow and to integrate it in next Monday release.

Add and track it with a packaging task for beta1.

ctk_actor_set_default_direction does change clutk's behaviour. I think it is responsible for changing the layout of buttons and other widgets.
Anyway, I changed the gtk call to that because I noticed ctk_actor_set_default_direction was used in main, so I thought the code would be more consistent this way.

Do you know how can I move the sidebar a little bit to the left? I'm not sure it should be released before that, because right now its right side is cropped a little bit.

Hum, I'm not an expert of the code, but if I look at netbook-launcher/nl-scroll-view.c, I can see that:

static void
nl_scroll_view_constructed (GObject *object)
{
  ....
  slider = nl_texture_frame_new (CLUTTER_TEXTURE (slider_texture), 5, 5, 5, 5);
  clutter_actor_set_size (slider, 18, 18);

  ctk_scroll_view_set_scroll_bar (CTK_SCROLL_VIEW (object), trough, slider);
  ...
}

So, we are attaching there the slider to object, which is the view being constructed.
I would say that if you use the ctk_actor_set_default_direction on the clutk actor (object), it should do the right thing, that means, putting it into the left. But I'm not a clutk hacker :-)

Can you try this or look for other part in the same file?
In any case, thanks for your work there, it's really good ;)

Well, ctk_actor_set_default_direction is global, and not defined for a single clutk actor.
Still, I did find a solution in the function you mentioned: I changed the padding defined there for scroll view objects, and I think the sidebar is now positioned correctly.

Thanks.

Sweet!

Yeah, your solution seems good. Now, I have to install Hebrew on my laptop and give it a try, before merging in trunk :)
Thanks a lot for your work there. giving feedback later today or tomorrow.

Works very well, pushed in trunk, preparing the release now

Thanks for pushing the patch. This patch however only fixes the first item in this bug (maybe also the second, I'm not sure if the text alignment now is optimal). But still the third and forth issues remain. Should I open new bug/wishlist reports for them?

Yeah, 3 and 4 should be filled as another bug, and targeted to beta 2 (I think 4 is easy, not sure about 3).
If you are interested in fixing them, do not hesitate to ask :)

Thanks for your work there

This bug was fixed in the package netbook-launcher - 1:2.1.15-0ubuntu1

---------------
netbook-launcher (1:2.1.15-0ubuntu1) lucid; urgency=low

  * New upstream release:
    - Can't launch anything outside "Favourties" or "Files & Folders"
      using touchscreen (ilovemistakes) (LP: #434502)
    - Enhance support for right-to-left languages (Haggai Eran)
      (LP: #470454)
    - netbook launcher crashes when pressed arrow keys in 'files and folders'
      menu (LP: #512136)
    - Home folder should appear in UNR Files and Folders section
      (LP: #412030)
    - Examples from example-content don't show up on Files & Folders
      (LP: #423601)
 -- Didier Roche <email address hidden> Thu, 11 Mar 2010 17:53:09 +0100