Can't launch anything outside "Favourties" or "Files & Folders" using touchscreen

Bug #434502 reported by Nicholas Christian Langkjær Ipsen
42
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Ubuntu Netbook Remix Launcher
Fix Released
High
Unassigned
netbook-launcher (Ubuntu)
Fix Released
Medium
Didier Roche-Tolomelli
Nominated for Karmic by Nicholas Christian Langkjær Ipsen

Bug Description

Distro: Karmic Koala Testing
Package: netbook-launcher 2.1.9-0ubuntu2

When using my touchscreen, I can only launch stuff from "Favourites" & "Files & Folders." I think it could be related to the little "+" icon used to add something to the favourites menu, as its absence seems to be the only link between the launchers that work.

I can move between categories.
When I click on a normal application, it looks like I've tried to drag it a little. No permanent change though. It doesn't start, nor is it added to favourites.
I can launch a folder from "Files and Folders."

EDIT: Today, I noticed that this also happens if the mouse is not comepletly still when you try to activate one of the problematic icons. Two solution:

1. Either deactivate click-and-hold-to-drag in the netbook-launcher.
2. Add a "dead zone."

Revision history for this message
Neil J. Patel (njpatel) wrote :

Thanks for reporting this bug. When using the touch screen, can you move between the categories on the left? When you click on an normal application in, say, Internet, what happens? Does it just not start or does itn not start and get added to favorites? Also, can you launch a folder from the Files and Folders category?

Changed in netbook-remix-launcher:
status: New → Incomplete
Revision history for this message
Nicholas Christian Langkjær Ipsen (ncli) wrote :

1. Yes, I can move between categories.
2. When I click on a normal application, it looks like I've tried to drag it a little. No permanent change though. It doesn't start, nor is it added to favourites.
3. Yes, I can launch a folder from "Files and Folders."

I'll try getting a screencap tomorrow, it's just hard to record a low-powered device like my netbook.

description: updated
description: updated
description: updated
description: updated
Neil J. Patel (njpatel)
Changed in netbook-remix-launcher:
status: Incomplete → Triaged
importance: Undecided → High
assignee: nobody → Neil J. Patel (njpatel)
milestone: none → ubuntu-9.10
Revision history for this message
Hollman Enciso (hollman) wrote :

Yes, I have the same problem. Attached a video.

Revision history for this message
Nicholas Christian Langkjær Ipsen (ncli) wrote :

That video illustrates the bug I encountered perfectly.

Revision history for this message
ilovemistakes (ilovemistakes) wrote :

I can confirm this bug. Also the same problem appears when using VNC (vino) instead of touchscreen. Attached xev output shows the difference between VNC, touchscreen and mouse "clicks", maybe it's related, because netbook-launcher seems to think that i am going to drag a shortcut (but not to launch it) because of this Motion_Notify events.

Revision history for this message
ilovemistakes (ilovemistakes) wrote :
Revision history for this message
ilovemistakes (ilovemistakes) wrote :
Revision history for this message
ilovemistakes (ilovemistakes) wrote :

When clicking by TS/VNC, those Motion_Notify events call on_motion() handler in nl-icon-tile.c, which emits "begin-drag-move" signal if LMB is down. Maybe the easiest (and maybe the dirtiest) solution is to check if motion is happening at the same point (or near) where LMB was pressed. Attached file is an illustration of this idea (not a quality patch, i am not a coder). At least, now i can launch any app in any category with touchscreen (and still can drag it to Favourites).

Paul Larson (pwlars)
Changed in netbook-launcher (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
BeBoBli (bebobli) wrote :

I don't believe this happens with any specific hardware. I am using both a regular mouse and a touchpad. Both of them have this problem and it's been happening for as long as I can remember even on the old interface. As was said before it seems like there is absolutely no dead zone for dragging so it activates immediately even when the cursor is completely still.

Revision history for this message
francescomm (ubuntu-esurfers) wrote :

I can confirm this bug with touch screen panel. (mouse is ok, trackpad ok)

Installed touchscreen module on an Asus EeePC 901. All is working like a charm, UNR with its big icons, scrollbar to the right, categories buttons is the perfect touch screen experience, astonishing, but this bug renders the whole thing quite useless and mostly annoying.

What I really don't get is why on earth should we drag the icons? To add a favorite there is already a favorite button. The only place we can drag them to is Favorites, no rearranging or changing categories... This for me is quite useless.
There should at least be, in gconf-editor, an option to disable the dragging, in my opinion.

If this was Off Topic, sorry.

Can anyone tell me if the proposed patch works, how can it be applied, and to what?
Do I need to download the sources of nblauncher (from where?) to my 901, apply the patch (to what file?) and compile it? Thanks for any help you may give.

Revision history for this message
ilovemistakes (ilovemistakes) wrote :

cd # ChDir HOME
mkdir netbook-launcher # make directory for our code manipulations
cd netbook-launcher # chdir
apt-get source netbook-launcher # grab netbook-launcher sources from repo
cd netbook-launcher-2.1.12 # chdir to source dir
wget http://launchpadlibrarian.net/33315482/434502.patch # download my "patch"
patch -p1 < 434502.patch # apply patch to the source tree (1 file should be patched)

done. compile and install as usual:
sudo apt-get build-dep netbook-launcher ; ./configure --prefix=/usr ; make ; sudo make install ; killall netbook-launcher

now you should have this workaround applied, hope it'll be useful for you.

Revision history for this message
fitte23 (mailtofitte) wrote :

Hello,
@ ilovemistakes
thanks for your patch!
Works really well.

Revision history for this message
fitte23 (mailtofitte) wrote :
Revision history for this message
Stephan Peijnik (speijnik) wrote :

I can confirm this problem too. I just packaged ilovemistakes' workaround and put it in my Asus T91MT UNR PPA: https://launchpad.net/~speijnik/+archive/asus-t91mt-unr

-- Stephan

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Commited in trunk, thanks for your contribution and helping to make ubuntu better. This fix will be available in netbook-launcher 2.1.15 in lucid.

Changed in netbook-remix-launcher:
assignee: Neil J. Patel (njpatel) → nobody
milestone: ubuntu-9.10 → none
status: Triaged → Fix Committed
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

assigning the packaging task myself to ensure I list every bugs in next package upload

Changed in netbook-launcher (Ubuntu):
assignee: nobody → Didier Roche (didrocks)
Changed in netbook-launcher (Ubuntu):
milestone: none → ubuntu-10.04-beta-1
Changed in netbook-remix-launcher:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package netbook-launcher - 1:2.1.15-0ubuntu1

---------------
netbook-launcher (1:2.1.15-0ubuntu1) lucid; urgency=low

  * New upstream release:
    - Can't launch anything outside "Favourties" or "Files & Folders"
      using touchscreen (ilovemistakes) (LP: #434502)
    - Enhance support for right-to-left languages (Haggai Eran)
      (LP: #470454)
    - netbook launcher crashes when pressed arrow keys in 'files and folders'
      menu (LP: #512136)
    - Home folder should appear in UNR Files and Folders section
      (LP: #412030)
    - Examples from example-content don't show up on Files & Folders
      (LP: #423601)
 -- Didier Roche <email address hidden> Thu, 11 Mar 2010 17:53:09 +0100

Changed in netbook-launcher (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.