Merge lp:~vthompson/ubuntu-weather-app/reboot-location-qml into lp:ubuntu-weather-app
Proposed by
Victor Thompson
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Victor Thompson | ||||||||
Approved revision: | 46 | ||||||||
Merged at revision: | 44 | ||||||||
Proposed branch: | lp:~vthompson/ubuntu-weather-app/reboot-location-qml | ||||||||
Merge into: | lp:ubuntu-weather-app | ||||||||
Diff against target: |
110 lines (+73/-1) 4 files modified
app/components/CurrentLocation.qml (+62/-0) app/ubuntu-weather-app.qml (+4/-0) app/ui/LocationsPage.qml (+4/-0) ubuntu-weather-app.apparmor (+3/-1) |
||||||||
To merge this branch: | bzr merge lp:~vthompson/ubuntu-weather-app/reboot-location-qml | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Borho | Approve | ||
Andrew Hayzen | Approve | ||
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+259462@code.launchpad.net |
Commit message
* Implement QtLocation reverse geocoding
* Use Open Street Map plugin
* Update apparmor
Description of the change
* Implement QtLocation reverse geocoding
* Use Open Street Map plugin
* Update apparmor
This simply displays the reverse geocoded city name in the LocationsPage at the first item. This uses the QtLocations QML API for Location models and utilizes the OSM plugin for reverse geocoding. The Nokia HERE plugin did not appear to support reverse geocoding and also required an API key. It may take a bit for the "Undefined" text to change to your current GPS location.
To post a comment you must log in.
PASSED: Continuous integration, rev:44 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- ci/90/ 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- utopic- amd64-ci/ 60 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- vivid-amd64- ci/90
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- ci/90/rebuild
http://