Ubuntu Weather App

Code review comment for lp:~vthompson/ubuntu-weather-app/reboot-location-qml

  1. reboot-location-qml
  2. Merge into reboot
Revision history for this message
Martin Borho (martin-borho) wrote :

lgtm!

To get it work with the data backend, the current-location-object should follow the format like "location" in http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/view/head:/tests/autopilot/ubuntu_weather_app/files/1.json#L2

Important is here "location.coord" and "location.timezone". I don't know if the timezone is available by reverse geocoding. If not, a "searchByPoint" with lat/long is needed beforehand. (Timezone is needed to calculate the proper local time of the location)

review: Approve

« Back to merge proposal