Code review comment for lp:~vthompson/ubuntu-weather-app/reboot-location-qml

Revision history for this message
Victor Thompson (vthompson) wrote :

The intent of this MP is just to add location detection. We'll need more work for managing the current location. I also don't think we'll want to show "Undefined", but this MP does so because without explicitly managing the location that is being detected _something_ needs to be in the model. We could hide it in the future if it's invalid/undefined or add some different text. Right now this just displays the discovered location. This MP doesn't add enough of the discovered data to allow for the Weather API calls to work. So you'll always see 0 degrees. We'll need to determine the minimal set of data (and where it exists) in the GeocodeModel to add it to the weather locations model properly.

« Back to merge proposal