Code review comment for lp:~vthompson/ubuntu-weather-app/reboot-location-qml

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

After ensuring that the location service is actually working by using google/here maps. I was able to start weather, accept the location detection and it instantly added it to the top of the list :-)

However it always displays 0°C for the location and it hasn't actually added the location to the home page so this causes issues such as trying to remove the last location as the indexes are out of sync. Or is this what your TODO message is saying will be in a future mp?

Also maybe "undefined" is not the best word to use that could appear in the UI and this string should be translatable.

review: Needs Information

« Back to merge proposal