Merge lp:~mardy/unity-2d/rtl into lp:unity-2d

[Alberto Mardegan]

Mirror layouts and panels' placement for RTL locales

 * Move the launcher to the right of the screen, and mirror it.
 * Mirror the layout of the top panel.
 * Mirror the layout of the dash.

Original contribution by Haggai Eran.

[lp:~mardy/unity-2d/rtl]

650. By Florian Boucault on 2011-08-12

Removed mistakenly introduced dependency on libdee.

651. By Florian Boucault on 2011-08-12

Readded dependency on libdee as a workaround until the proper fix is made in UnityCore.

652. By Gerry Boland on 2011-08-12

[dash] Fix Lens bar icons so they scale correctly. Use correct Home lens icon.

653. By Florian Boucault on 2011-08-18

Merged lp:unity-2d

654. By Florian Boucault on 2011-08-22

* No change rebuild for the nux update abi break
* debian/control: update the nux requirement to be sure to pick the new one

655. By Gerry Boland on 2011-08-23

[dash] (Unity 4.0) Update Toggle buttons to latest design spec

656. By Alberto Mardegan on 2011-08-23

Add missing initializations of member variables

These were reported by valgrind complaining about "jump depends on value of uninitialized variable".

657. By Florian Boucault on 2011-08-23

[dash] Collapse categories by default.

658. By Ugo Riboni on 2011-08-23

[panel] Dynamically load applets

Each applet is now a plugin implementing the PanelAppletProviderInterface.
In addition to porting the existing applets as plugins, the Homebutton and
Separator applets have been brought back as optional panel applets.

659. By Florian Boucault on 2011-08-23

Merged lp:unity-2d

660. By Florian Boucault on 2011-08-23

Merged lp:unity-2d

661. By Alberto Mardegan on 2011-08-24

[panel] IndicatorsManager: deliver synthetic mouse motion events to Qt

By feeding mouse motion events to Qt while the panel-service is grabbing the
mouse, we ensure that Qt can generate correct enter/leave events for the panel
widgets (and especially for the IndicatorEntry widgets).

[Florian Boucault (fboucault)]

I see lots of warnings on the console. For example when starting the dash:

unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $leftMargin() { return leftRight(-5,0) })" depends on non-NOTIFYable properties:
unity-2d-places: [WARNING] DashDeclarativeView::layoutDirection
unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $rightMargin() { return rightLeft(-5,0) })" depends on non-NOTIFYable properties:
unity-2d-places: [WARNING] DashDeclarativeView::layoutDirection
unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $right() { return rightLeft(parent.right) })" depends on non-NOTIFYable properties:
unity-2d-places: [WARNING] DashDeclarativeView::layoutDirection
unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $left() { return leftRight(parent.left) })" depends on non-NOTIFYable properties:

review: Needs Fixing

[Florian Boucault (fboucault)]

Style: by convention all if statements use braces. For example:

if (true)
  do this
else
  do that

is actually written:

if (true) {
  do this
} else {
  do that
}

See CODING file.

[Florian Boucault (fboucault)]

In QML, there should be only one space between the property and its value. For example:

Item {
  x: 24
}

should be written:

Item {
  x: 24
}

[lp:~mardy/unity-2d/rtl]

662. By Florian Boucault on 2011-08-25

[dash] Removed unused tile renderers and simplified conversion of renderer name to QML file name.

663. By Florian Boucault on 2011-08-25

[launcher] Rename dash tile to 'Dash home'.

664. By Florian Boucault on 2011-08-25

Merged lp:unity-2d

665. By Florian Boucault on 2011-08-25

Merged lp:unity-2d

666. By Florian Boucault on 2011-08-25

[packaging] Install javascript files as well.

667. By Florian Boucault on 2011-08-25

[dash] New filters pane on the right hand side of the search results.

Implemented filters:
- multirange
- checkoption
- ratings

668. By Florian Boucault on 2011-08-25

[i18n] Updated translation catalog.

669. By Florian Boucault on 2011-08-25

[packaging] debian/changelog: added placeholder entry.

670. By Sebastien Bacher on 2011-08-25

* New upstream release:
  - [panel] application menus do not appear on first hover after dismissal
    (lp: #825262)
  - [dash] Lens icons badly scaled (lp: #825368)
  - [panel] indicators are shifted offscreen to the right (lp: #827673)
  - [panel] scrubbing from system indicators to menubar should be possible
    (lp: #706903)
  - [launcher] Closed applications don't get their launcher counts cleared
    (lp: #767367)
  - [dash] selected item should not be underlined but use the same
    treatment as unity (lp: #817456)
  - [dash] categories should be collapsed by default (lp: #827214)
  - [dash] Ratings filter (lp: #831855)
  - [dash] Multirange filter (lp: #831856)
  - [dash] ToggleButton filter (lp: #831857)
  - [dash] Icon size must be bigger to match the mockups (lp: #831858)
  - [dash] "Refine search" right margin should be 15 pixels (lp: #832058)
  - [dash] "Refine search" should be "Filter results" (lp: #832060)
  - [dash] Font sizes should match new design (lp: #832114)
  - [panel] Glitch: application menu appearing when pressing the BFB
    (lp: #825060)
  - [panel] Glitch: application menus are quickly opened after a drag gesture
    (lp: #825267)
  - [dash] File thumbnails aspect ratio is not respected (lp: #832204)

671. By Sebastien Bacher on 2011-08-25

debian/control: require current the current versions of nux and unity

672. By Sebastien Bacher on 2011-08-25

releasing version 4.2.0-0ubuntu1

[Alberto Mardegan (mardy)]

I fixed the style issues, but the warnings cannot be easily fixed.
I filed a bug against Qt for that: https://bugreports.qt.nokia.com/browse/QTBUG-21134

If my understanding is correct, these warnings don't point at any real problem; any ideas on how to suppress them is welcome (we could add a property layoutDirectionHack to the DashDeclarativeView class, having also a NOTIFY signal, but maybe there's something better?).

[lp:~mardy/unity-2d/rtl]

673. By Alberto Mardegan on 2011-08-30

[panel] Workaround QConf incomplete destruction

Ensure that the QConf object stays alive as long as the PanelManager is. This
is to workaround an issue with QConf's destructor, which doesn't disconnect
from the DConf's "notify" signal that can later be emitted while running the
event loop, and would therefore attempt to operate on an already destroyed
object.

674. By Gerry Boland on 2011-08-30

[dash] Rating Stars now cleared when "All" button pressed. Fixes bug:834640

675. By Alberto Mardegan on 2011-08-30

[panel] Padding for indicators should be 5 pixels

676. By Gerry Boland on 2011-08-30

[launcher] Context menu arrow has ugly blue edge. Harder to observe is that all the background graphics have blu-ish edges. This commit cleans up the graphics. Fixes bug:828386

677. By Alberto Mardegan on 2011-08-30

[dash] Convert UnityCore UTF-8 strings to QStrings

Add a tiny global function to perform the conversion, and use it throughout the project.

678. By Florian Boucault on 2011-08-31

[dash] Category header label changed from using literal to numeral: "See one more result" changed into "See 1 more result"

679. By Florian Boucault on 2011-08-31

[dash][launcher] When an application has no icon or the icon fails to load, display a placeholder icon.

680. By Florian Boucault on 2011-08-31

[dash] Use plural form in category header label 'See x more results'

681. By Florian Boucault on 2011-08-31

[dash] Fixed drag and drop of results from the dash (in particular applications to the launcher).

682. By Florian Boucault on 2011-08-31

[dash] Support loading lens' icon from theme in lens navigation bar.

683. By Florian Boucault on 2011-08-31

[dash] Fallback to using the default renderer if renderer requested by the lens is not found.

684. By Florian Boucault on 2011-08-31

[dash] Added horizontal renderer used by lenses such as Gwibber.

685. By Florian Boucault on 2011-08-31

[dash] Home buttons 'Media' and 'Internet' apps now also activate the right filter and open up the 'Filter results' pane.

[Alberto Mardegan (mardy)]

Here's a couple of changes to avoid the warnings: instead of using the layoutDirection property from the DashDeclarativeView, inject a new QtLayoutDirection property into the declarative context, and use that from the dash.

Files changed since last review: places/dash.qml, places/app/places.cpp

[lp:~mardy/unity-2d/rtl]

686. By Florian Boucault on 2011-09-01

[panel] legacytray applet: implement a whitelist of applications that are allowed to be shown.

Whitelist is shared with Unity 3D and stored in D-Conf.

687. By Gerry Boland on 2011-09-01

[launcher] Fix keyboard shortcuts to start counting applications at index 1.

688. By Florian Boucault on 2011-09-01

[packaging] Added placeholder entry to debian/changelog.

689. By Gerry Boland on 2011-09-01

[dash] HACK: the DropShadow effect on the Home lensButton causes visual artifacts as the list of lenses is being populated, when the inter-lensButton spacing is non-zero. Can work around this by removing spacing and instead add padding to each lensButton. Fixes bug:833805

690. By Florian Boucault on 2011-09-01

[dash] Make sure that a search with the empty string ("") is sent to the lenses
when connecting to them. This is part of the fix necessary for bug #834571, the
other part being in libunity.

691. By Didier Roche-Tolomelli on 2011-09-01

* New upstream release:
* debian/control:
  - require current nux and unity

692. By Didier Roche-Tolomelli on 2011-09-01

  - unity-2d-panel crashed with SIGSEGV in QConfSchema::findKey()
    (LP: #834045)
  - unity-2d-panel crashed with SIGSEGV in QConf::notify() (LP: #834001)
  - [panel] Implement whitelisting for legacy tray applet (LP: #707354)
  - [launcher] stops automatically hiding after some time using it
    (LP: #821180)
  - [panel] Empathy displays icon in deprecated systray (LP: #830017)
  - [dash] Invalid UTF-8 in the dash (LP: #836587)
  - [dash] Home buttons 'Media' and 'Internet' apps should not only take you
    to the apps lens but also activate the right filter (LP: #837360)
  - [dash] Drag&drop application from dash to launcher is broken
    (LP: #837361)
  - [launcher] contextual menu's corner has a blue line (LP: #828386)
  - [dash] Lens bar graphical layout glitches (LP: #833805)
  - [dash] Rating Filter: All button not clearing star highlighting
    (LP: #834640)
  - [dash] should be falling back to the default renderer if the renderer
    requested by the lens is not found (LP: #837356)
  - [dash] Gwibber lens icon doesn't show up in 2d unity (LP: #830728)
  - [dash] Lacks horizontal renderer used by lenses such as Gwibber
    (LP: #837712)
  - [dash] See %1 more result inconsistency (LP: #834226)
  - [launcher] When application has no icon, a question mark icon should be
    displayed (LP: #837351)
  - unity places should return a default icon when no matching icon is found
    (LP: #711200)
  - spacing between indicators should be 5 pixels (LP: #734010)

693. By Didier Roche-Tolomelli on 2011-09-01

releasing version 4.4.0-0ubuntu1

694. By Aurélien Gâteau on 2011-09-02

[Launcher] Use the same icon as Unity 3d for the BFB launcher item

695. By Florian Boucault on 2011-09-05

[dash] Fix encoding and decoding of strings coming from and passed to the backend so that searches containing non-ascii characters work.

Reverted revision 677. It was introducing QStringFromUtf8StdString that has
the same result as QString::fromStdString with the codec for C-strings set to UTF-8.

696. By Didier Roche-Tolomelli on 2011-09-05

[launcher] Migrate favorites as in unity before building the launcher applications list
(LP: #819733)

697. By Alberto Mardegan on 2011-09-05

[places] Use shotwell as default photo viewer

Extend GioDefaultApplication with a defaultDesktopFile property which can be
used to override the default application registered for the content-type.

698. By Gerry Boland on 2011-09-05

[launcher] Qt4.7.4 fixes a bug we were using, where ListView was not explicitly attached to the root of the delegate. (See https://bugreports.qt.nokia.com/browse/QTBUG-19557).

This commit fixes the launcher to work correctly with this change.

699. By Florian Boucault on 2011-09-05

[panel] Show window control buttons whenever the application menu is shown and the window is maximised.

700. By Andrea Grandi on 2011-09-07

Emptying the trash by right-clicking the trash icon in the unity sidebar and selecting the "Empty ..." option requires users to confirm the action, even if they have unchecked the "Ask before emptying ..." option in nautilus > Edit > Preferences > Behaviour. The option is correctly applied to emptying the trash from nautilus itself.

Now this behaviour is respected in Unity-2D too.

701. By Gerry Boland on 2011-09-07

[launcher] Unity uses the Trash icon supplied by the default theme. Unity2D now does the same.

702. By Ugo Riboni on 2011-09-07

Add a new proxy model class that excludes items matching the regexp instead of including them.

703. By Gerry Boland on 2011-09-08

[dash] RatingStars should only allow whole stars to be selected. See bug:839759

704. By Alberto Mardegan on 2011-09-08

[launcher, dash, workspace switcher] Added a configuration key to enable QML's OpenGL backend

705. By Gerry Boland on 2011-09-08

[dash] DropShadow can cause visual artifacts in the GridView while it is being moved. Work around this by disabling DropShadow while Grid is being moved.

706. By Florian Boucault on 2011-09-08

Simplify implementation of QSortFilterProxyModel's count property by overriding the filterAcceptRow method as recommended by the documentation.

707. By Marco Trevisan (Treviño) on 2011-09-08

To implement the Desktop DX Indicators Review blueprint [1] and to implement the system indicators ordering requested by design team [2], I've redesigned the way the indicators work in unity.

This need to change both unity-panel-service, UnityCore and unity-2d-panel, and basically it works by making the panel-service to compute a "priority" for each indicator entry and then making the panel to show the indicator entries in the correct order.

This needs the UnityCore code available in the lp:~3v1n0/unity/indicators-redesign branch.

More informations are available in the unity merge request:
 https://code.launchpad.net/~3v1n0/unity/indicators-redesign/+merge/70818

[1] https://blueprints.launchpad.net/ubuntu/+spec/desktop-dx-o-indicators-review
[2] https://wiki.ubuntu.com/MenuBar#System_status_menus_.28system_indicators.29

PS: Unfortunately I will go in holiday on August 11th, so I hope you could review it quickly to allow me to fix the eventual issues.

708. By Didier Roche-Tolomelli on 2011-09-08

* debian/control:
  - rebuild against current nux and unity (API change)

709. By Didier Roche-Tolomelli on 2011-09-08

* New upstream release
  - [dash] Apps lens shows no result by default (LP: #834571)
  - Metacity needs command line options to activate capture before unmap and
    compositing without effects (LP: #791205)
  - Bold fonts everywhere in the UI (dash, launcher, workspace switcher) but
    in the panel (LP: #808849)
  - the migration script needs to be run in unity-2d as well (LP: #819733)
  - [dash] "View photos" in the dash launches default image viewer instead
    of shotwell (LP: #822605)
  - Launcher tooltips sometimes leave holes in panel and windows
    (LP: #837277)
  - [dash] Search with non ascii characters fails (LP: #840010)
  - add a configuration key (dconf) to enable the opengl backend
    (LP: #809202)
  - [launcher] when pressing super key shortcuts numbering start at 2
    instead of 1 (LP: #830036)
  - [UIFe] Unity 2D should be using the same BFB icon as Unity (LP: #838829)
  - [launcher] trash icon needs to be the same as in Unity 3D (LP: #840025)
  - Pressing alt on maximized window does show menu but not window controls
    (LP: #836274)
  - [dash] DropShadow on "See X more results" can cause visual errors on
    scroll (LP: #843820)
  - Dash - In the App lens filters, users should only be able filter by
    'star' rating in one star increments (LP: #839759)
  - Emptying the trash from the unity sidebar should respect nautilus' "Ask
    before emptying" setting (LP: #730003)
  - UIFe: Panel - Indicators should be orderable regardless of their parent
    IndicatorObject (LP: #823061)

710. By Didier Roche-Tolomelli on 2011-09-08

macro release for unity

711. By Didier Roche-Tolomelli on 2011-09-08

releasing version 4.6.0-0ubuntu1

712. By Florian Boucault on 2011-09-09

[dash] Lenses Qt binding's querying of unity::dash::Lenses::count property caused
a SEGFAULT. Avoid using that property.

713. By Didier Roche-Tolomelli on 2011-09-09

Fix a segfault due to new unity service backend change.

714. By Didier Roche-Tolomelli on 2011-09-09

releasing version 4.6.1-0ubuntu1

715. By Florian Boucault on 2011-09-12

[dash] Fixed issue where no results are displayed by default in any lens.

Synchronized local states of lenses with their actual states when they become
connected.

716. By Marco Trevisan (Treviño) on 2011-09-13

[panel] Added support for the missing indicator removal feature.

When the on_object_removed signal is emitted, unity-2d should remove the given indicator and its entries from the panel.

717. By Florian Boucault on 2011-09-13

[panel] Fixed crash occuring in IndicatorsWidget::onEntryRemoved() when logging out.

During IndicatorsWidget's destruction, disconnect from indicators' signals that it was connected to.

718. By Michał Sawicz on 2011-09-14

[launcher] Fix interaction with the window manager

When launching a new application, we need to forward a proper timestamp from the X server so that the window manager can successfully do focus stealing prevention.

719. By Florian Boucault on 2011-09-14

[dash] Made lens navigation bar buttons accessible.

720. By Florian Boucault on 2011-09-14

[dash] Do not display the search hint in the search field when a partial input is available from an input method.

Only works with Qt Quick 1.1.

721. By Gerry Boland on 2011-09-14

[panel] Fix line of bad pixels above panel. See bug:846335

722. By Alberto Mardegan on 2011-09-15

Merge

723. By Alberto Mardegan on 2011-09-15

Use mirroring in LauncherItem

724. By Alberto Mardegan on 2011-09-15

remove debug line

725. By Alberto Mardegan on 2011-09-15

Remove empty line

726. By Alberto Mardegan on 2011-09-15

Use mirroring in dash

727. By Alberto Mardegan on 2011-09-15

Remove unused dependency

728. By Alberto Mardegan on 2011-09-15

Remove useless line

[Alberto Mardegan (mardy)]

Branch reworked a bit to take the Qt 4.7.4 layout mirroring into use.

[Florian Boucault (fboucault)]

* arrow_rtl.png is not an exact mirror of arrow.png because arrow.png has had an update recently
* panel/CMakeLists.txt lacks a directive to install panel/artwork (see launcher/CMakeLists.txt for reference; thinking about it divider_rtl.png is probably useless now :)
* Individual changes to places.cpp, launcher.cpp, etc. should be factored in Unity2dApplication:
    Unity2dTr::init("unity-2d", INSTALL_PREFIX "/share/locale");
    if (u2dTr("QT_LAYOUT_DIRECTION") == "RTL") {
        QApplication::setLayoutDirection(Qt::RightToLeft);
    }

review: Needs Fixing

[Florian Boucault (fboucault)]

This is great work! There is a couple of functional issues that we can either fix now or report as bugs:
- the launcher has a 1 pixel wide gray-ish vertical line on its right-handside which is fine in LTR but it should move to the left hand-side in RTL
- the workspace switcher leaves a space for the launcher always on the left even though in RTL the launcher is on the right

review: Needs Fixing

[lp:~mardy/unity-2d/rtl]

729. By Alberto Mardegan on 2011-09-20

Update arrow icon for RTL locales

730. By Alberto Mardegan on 2011-09-20

Remove unused artwork

731. By Alberto Mardegan on 2011-09-20

Remove code duplication

[Alberto Mardegan (mardy)]

I took care of the issues you mentioned, except the last two; it might take a longer time to fix those, and I'd rather have this basic support in first.

[Florian Boucault (fboucault)]

All good, please file bug reports for these when you have more time.

review: Approve

[Florian Boucault (fboucault)]

The release team agreed to merge it as a freeze exception given that it's not activated by default which I believe is the case.

=== modified file 'launcher/LauncherItem.qml'
--- launcher/LauncherItem.qml	2011-09-05 13:59:41 +0000
+++ launcher/LauncherItem.qml	2011-09-20 08:46:25 +0000
@@ -16,7 +16,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-import QtQuick 1.0
+import QtQuick 1.1
 import Unity2d 1.0
 
 /* This component represents a single "tile" in the launcher and the surrounding
@@ -95,6 +95,10 @@
         else return (index == 0) ? 0 : (index == 1) ? -4 : +4
     }
 
+    function isRightToLeft() {
+        return Qt.application.layoutDirection == Qt.RightToLeft
+    }
+
     signal clicked(variant mouse)
     signal entered
     signal exited
@@ -102,6 +106,8 @@
     Item {
         /* The actual item, reparented so its y coordinate can be animated. */
         id: looseItem
+        LayoutMirroring.enabled: isRightToLeft()
+        LayoutMirroring.childrenInherit: true
         parent: list
         width: item.width
         height: item.height
@@ -127,6 +133,7 @@
         Image {
             anchors.right: parent.right
             y: item.height - item.tileSize / 2 - height / 2
+            mirror: isRightToLeft()
 
             source: "image://blended/%1color=%2alpha=%3"
                   .arg("artwork/launcher_arrow_rtl.png")
@@ -151,6 +158,7 @@
                    problem, but I'm not sure if it should happen in the first place. */
                 anchors.left: (parent) ? parent.left : undefined
                 y: item.height - item.tileSize / 2 - height / 2 + getPipOffset(index)
+                mirror: isRightToLeft()
 
                 source: "image://blended/%1color=%2alpha=%3"
                         .arg(pipSource).arg("lightgrey").arg(1.0)

=== modified file 'launcher/app/launcher.cpp'
--- launcher/app/launcher.cpp	2011-08-09 17:06:35 +0000
+++ launcher/app/launcher.cpp	2011-09-20 08:46:25 +0000
@@ -90,6 +90,7 @@
 
     /* Panel containing the QML declarative view */
     Unity2dPanel panel(true);
+
     panel.setEdge(Unity2dPanel::LeftEdge);
     panel.setFixedWidth(LauncherClient::MaximumWidth);
     panel.setAccessibleName("Launcher");

=== added file 'libunity-2d-private/Unity2d/launchermenu/arrow_no_transparency_rtl.png'
Binary files libunity-2d-private/Unity2d/launchermenu/arrow_no_transparency_rtl.png	1970-01-01 00:00:00 +0000 and libunity-2d-private/Unity2d/launchermenu/arrow_no_transparency_rtl.png	2011-09-20 08:46:25 +0000 differ
=== added file 'libunity-2d-private/Unity2d/launchermenu/arrow_rtl.png'
Binary files libunity-2d-private/Unity2d/launchermenu/arrow_rtl.png	1970-01-01 00:00:00 +0000 and libunity-2d-private/Unity2d/launchermenu/arrow_rtl.png	2011-09-20 08:46:25 +0000 differ
=== added file 'libunity-2d-private/Unity2d/launchermenu/background_no_transparency_rtl.png'
Binary files libunity-2d-private/Unity2d/launchermenu/background_no_transparency_rtl.png	1970-01-01 00:00:00 +0000 and libunity-2d-private/Unity2d/launchermenu/background_no_transparency_rtl.png	2011-09-20 08:46:25 +0000 differ
=== added file 'libunity-2d-private/Unity2d/launchermenu/background_rtl.png'
Binary files libunity-2d-private/Unity2d/launchermenu/background_rtl.png	1970-01-01 00:00:00 +0000 and libunity-2d-private/Unity2d/launchermenu/background_rtl.png	2011-09-20 08:46:25 +0000 differ
=== modified file 'libunity-2d-private/Unity2d/launchermenu/launchermenu.qrc'
--- libunity-2d-private/Unity2d/launchermenu/launchermenu.qrc	2011-06-08 20:43:09 +0000
+++ libunity-2d-private/Unity2d/launchermenu/launchermenu.qrc	2011-09-20 08:46:25 +0000
@@ -7,5 +7,11 @@
         <file>check_default.png</file>
         <file>check_selected.png</file>
         <file>launchermenu.css</file>
+
+        <file>arrow_rtl.png</file>
+        <file>arrow_no_transparency_rtl.png</file>
+        <file>background_rtl.png</file>
+        <file>background_no_transparency_rtl.png</file>
+        <file>launchermenu_rtl.css</file>
     </qresource>
 </RCC>

=== added file 'libunity-2d-private/Unity2d/launchermenu/launchermenu_rtl.css'
--- libunity-2d-private/Unity2d/launchermenu/launchermenu_rtl.css	1970-01-01 00:00:00 +0000
+++ libunity-2d-private/Unity2d/launchermenu/launchermenu_rtl.css	2011-09-20 08:46:25 +0000
@@ -0,0 +1,82 @@
+/*
+ * Copyright (C) 2010 Canonical, Ltd.
+ *
+ * Authors:
+ *  Olivier Tilloy <[e-mail]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+QMenu {
+    border-width: 24px 15px 4px 5px;
+    padding-top: -4px;
+    padding-right: -15px;
+    min-width: 72px;
+    min-height: 13px;
+}
+
+QMenu[transparencyAvailable=true] {
+    border-image: url(:/launchermenu/background_rtl.png) 5px 15px 4px 5px Repeat Repeat;
+}
+
+QMenu[transparencyAvailable=false] {
+    border-image: url(:/launchermenu/background_no_transparency_rtl.png) 5px 15px 4px 5px Repeat Repeat;
+}
+
+
+QMenu::item {
+    color: white;
+    margin-left: 5px;
+    margin-right: 15px;
+    margin-top: 2px;
+    margin-bottom: 2px;
+    padding-left: 25px;
+    padding-right: 25px;
+    padding-top: 5px;
+    padding-bottom: 5px;
+}
+
+QMenu::item:selected:enabled {
+    border-radius: 4px;
+    border-color: rgb(109, 109, 109);
+    border-width: 1px;
+    border-style: solid;
+    color: rgba(41, 41, 41, 90%);
+    background-color: rgba(255, 255, 255, 90%);
+}
+
+QMenu::indicator {
+    width: 16px;
+    height: 13px;
+    margin-right: 3px;
+}
+
+QMenu::indicator:checked {
+    image: url(:/launchermenu/check_default.png);
+}
+
+QMenu::indicator:checked:selected {
+    image: url(:/launchermenu/check_selected.png);
+}
+
+QMenu::separator {
+    height: 1px;
+    margin-left: 4px;
+    margin-right: 14px;
+    background-color: rgba(255, 255, 255, 56%);
+    border-color: rgba(0, 0, 0, 55%);
+    border-style: solid;
+    border-top-width: 1px;
+    border-bottom-width: 1px;
+}
+

=== modified file 'libunity-2d-private/src/edgehitdetector.cpp'
--- libunity-2d-private/src/edgehitdetector.cpp	2011-06-11 11:33:52 +0000
+++ libunity-2d-private/src/edgehitdetector.cpp	2011-09-20 08:46:25 +0000
@@ -51,9 +51,15 @@
 
 void EdgeHitDetector::updateGeometryFromScreen()
 {
-    int leftScreen = QApplication::desktop()->screenNumber(QPoint());
-    QRect rect = QApplication::desktop()->screenGeometry(leftScreen);
-    m_mouseArea->setGeometry(rect.left(), rect.top(), 1, rect.height());
+    QPoint p = QApplication::isLeftToRight() ?
+        QPoint() :
+        QPoint(QApplication::desktop()->width() - 1, 0);
+    QRect rect = QApplication::desktop()->screenGeometry(p);
+    if (QApplication::isLeftToRight()) {
+        m_mouseArea->setGeometry(rect.left(), rect.top(), 1, rect.height());
+    } else {
+        m_mouseArea->setGeometry(rect.right() - 1, rect.top(), 1, rect.height());
+    }
 }
 
 #include "edgehitdetector.moc"

=== modified file 'libunity-2d-private/src/intellihidebehavior.cpp'
--- libunity-2d-private/src/intellihidebehavior.cpp	2011-06-27 13:43:05 +0000
+++ libunity-2d-private/src/intellihidebehavior.cpp	2011-09-20 08:46:25 +0000
@@ -13,6 +13,7 @@
 #include "intellihidebehavior.h"
 
 // Local
+#include "unity2dpanel.h"
 
 // libunity-2d
 #include <debug_p.h>
@@ -23,6 +24,7 @@
 #include <QEvent>
 #include <QTimer>
 #include <QWidget>
+#include <QDesktopWidget>
 
 // libwnck
 extern "C" {
@@ -131,7 +133,15 @@
     // Compute launcherRect, adjust "left" to the position where the launcher
     // is fully visible.
     QRect launcherRect = m_panel->geometry();
-    launcherRect.moveLeft(0);
+    // FIXME: the following code assumes that the launcher is on the left edge
+    // of the screen
+    if (QApplication::isLeftToRight()) {
+        launcherRect.moveLeft(0);
+    } else {
+        QDesktopWidget* desktop = QApplication::desktop();
+        const QRect screen = desktop->screenGeometry(m_panel);
+        launcherRect.moveRight(screen.right());
+    }
 
     WnckScreen* screen = wnck_screen_get_default();
     WnckWorkspace* workspace = wnck_screen_get_active_workspace(screen);

=== modified file 'libunity-2d-private/src/launchermenu.cpp'
--- libunity-2d-private/src/launchermenu.cpp	2011-08-01 13:04:32 +0000
+++ libunity-2d-private/src/launchermenu.cpp	2011-09-20 08:46:25 +0000
@@ -58,9 +58,17 @@
     /* Load the pixmap for the arrow. It is drawn separately as its position
        may vary depending on the position of the menu on the screen. */
     if (transparencyAvailable()) {
-        m_arrow.load(":/launchermenu/arrow.png");
+        if (QApplication::isLeftToRight()) {
+            m_arrow.load(":/launchermenu/arrow.png");
+        } else {
+            m_arrow.load(":/launchermenu/arrow_rtl.png");
+        }
     } else {
-        m_arrow.load(":/launchermenu/arrow_no_transparency.png");
+        if (QApplication::isLeftToRight()) {
+            m_arrow.load(":/launchermenu/arrow_no_transparency.png");
+        } else {
+            m_arrow.load(":/launchermenu/arrow_no_transparency_rtl.png");
+        }
     }
 
     /* First action used to display the title of the item */
@@ -77,6 +85,9 @@
 LauncherContextualMenu::loadCSS()
 {
     QString cssFilePath = ":/launchermenu/launchermenu.css";
+    if (QApplication::isRightToLeft()) {
+        cssFilePath = ":/launchermenu/launchermenu_rtl.css";
+    }
 
     QFile file(cssFilePath);
     if (!file.open(QIODevice::ReadOnly | QIODevice::Text))
@@ -154,6 +165,11 @@
         return;
 
     m_arrowY = 6;
+
+    if (QApplication::isRightToLeft()) {
+        x = QApplication::desktop()->width() - x - sizeHint().width();
+    }
+
     move(x, y - minimumSize().height() / 2);
     QMenu::show();
 
@@ -203,10 +219,15 @@
             }
         }
     } else {
+        int prevWidth = width();
+        int left = x(), top = y();
         addSeparator();
         m_launcherItem->createMenuActions();
 
         QRect screenGeometry = QApplication::desktop()->screenGeometry(this);
+        if (QApplication::isRightToLeft()) {
+            left -= width() - prevWidth;
+        }
         if (height() <= screenGeometry.height()) {
             /* Adjust the position of the menu only if it fits entirely on the screen. */
             int menuBottomEdge = y() + height();
@@ -214,13 +235,14 @@
             if (menuBottomEdge > screenBottomEdge) {
                 /* The menu goes offscreen, shift it upwards. */
                 m_arrowY += menuBottomEdge - screenBottomEdge;
-                move(x(), screenBottomEdge - height());
-                if (!transparencyAvailable()) {
-                    /* The arrow has moved relatively to the menu. */
-                    updateMask();
-                }
+                top = screenBottomEdge - height();
             }
         }
+        move(left, top);
+        if (!transparencyAvailable()) {
+            /* The arrow has moved relatively to the menu. */
+            updateMask();
+        }
     }
 
     m_folded = folded;
@@ -236,7 +258,11 @@
     /* Draw the arrow. */
     QPainter painter(this);
     painter.setCompositionMode(QPainter::CompositionMode_Source);
-    painter.drawPixmap(0, m_arrowY, m_arrow);
+    int left = 0;
+    if (QApplication::isRightToLeft()) {
+        left = width() - m_arrow.width();
+    }
+    painter.drawPixmap(left, m_arrowY, m_arrow);
 }
 
 LauncherItem*

=== modified file 'libunity-2d-private/src/unity2dapplication.cpp'
--- libunity-2d-private/src/unity2dapplication.cpp	2011-07-27 19:25:45 +0000
+++ libunity-2d-private/src/unity2dapplication.cpp	2011-09-20 08:46:25 +0000
@@ -28,6 +28,7 @@
 #include <gconnector.h>
 #include <gscopedpointer.h>
 #include <unity2ddebug.h>
+#include <unity2dtr.h>
 
 // Qt
 #include <QFont>
@@ -145,6 +146,12 @@
 : QApplication(argc, argv)
 , m_platformFontTracker(new PlatformFontTracker)
 {
+    /* Configure translations */
+    Unity2dTr::init("unity-2d", INSTALL_PREFIX "/share/locale");
+    if (u2dTr("QT_LAYOUT_DIRECTION") == "RTL") {
+        QApplication::setLayoutDirection(Qt::RightToLeft);
+    }
+
     /* Allow developers to run Unity 2D uninstalled by telling dconf-qt
        where to look for Unity 2D's schemas.
        It relies on the fact that the schema is compiled when running cmake.

=== modified file 'libunity-2d-private/src/unity2dpanel.cpp'
--- libunity-2d-private/src/unity2dpanel.cpp	2011-08-22 10:38:32 +0000
+++ libunity-2d-private/src/unity2dpanel.cpp	2011-09-20 08:46:25 +0000
@@ -67,9 +67,15 @@
         ulong struts[12] = {};
         switch (m_edge) {
         case Unity2dPanel::LeftEdge:
-            struts[0] = q->width();
-            struts[4] = available.top();
-            struts[5] = available.y() + available.height();
+            if (QApplication::isLeftToRight()) {
+                struts[0] = q->width();
+                struts[4] = available.top();
+                struts[5] = available.y() + available.height();
+            } else {
+                struts[1] = q->width();
+                struts[6] = available.top();
+                struts[7] = available.y() + available.height();
+            }
             break;
         case Unity2dPanel::TopEdge:
             struts[2] = q->height();
@@ -97,8 +103,13 @@
         QRect rect;
         switch (m_edge) {
         case Unity2dPanel::LeftEdge:
-            rect = QRect(screen.left(), available.top(), q->width(), available.height());
-            rect.moveLeft(m_delta);
+            if (QApplication::isLeftToRight()) {
+                rect = QRect(screen.left(), available.top(), q->width(), available.height());
+                rect.moveLeft(m_delta);
+            } else {
+                rect = QRect(screen.right() - q->width(), available.top(), q->width(), available.height());
+                rect.moveRight(screen.right() - m_delta);
+            }
             break;
         case Unity2dPanel::TopEdge:
             rect = QRect(screen.left(), screen.top(), screen.width(), q->height());
@@ -114,7 +125,7 @@
         QBoxLayout::Direction direction;
         switch(m_edge) {
         case Unity2dPanel::TopEdge:
-            direction = QApplication::isRightToLeft() ? QBoxLayout::RightToLeft : QBoxLayout::LeftToRight;
+            direction = QBoxLayout::LeftToRight;
             break;
         case Unity2dPanel::LeftEdge:
             direction = QBoxLayout::TopToBottom;

=== modified file 'panel/app/main.cpp'
--- panel/app/main.cpp	2011-07-27 19:25:45 +0000
+++ panel/app/main.cpp	2011-09-20 08:46:25 +0000
@@ -28,7 +28,6 @@
 #include <gnomesessionclient.h>
 #include <unity2ddebug.h>
 #include <unity2dapplication.h>
-#include <unity2dtr.h>
 
 // Qt
 #include <QAbstractFileEngineHandler>
@@ -62,9 +61,6 @@
     GnomeSessionClient client(INSTALL_PREFIX "/share/applications/unity-2d-panel.desktop");
     client.connectToSessionManager();
 
-    /* Configure translations */
-    Unity2dTr::init("unity-2d", INSTALL_PREFIX "/share/locale");
-
     PanelManager panels;
 
     return app.exec();

=== modified file 'panel/app/panelmanager.cpp'
--- panel/app/panelmanager.cpp	2011-08-30 10:41:50 +0000
+++ panel/app/panelmanager.cpp	2011-09-20 08:46:25 +0000
@@ -138,7 +138,11 @@
     panel->setEdge(Unity2dPanel::TopEdge);
     panel->setFixedHeight(24);
 
-    int leftmost = QApplication::desktop()->screenNumber(QPoint());
+    QPoint p;
+    if (QApplication::isRightToLeft()) {
+        p = QPoint(QApplication::desktop()->width() - 1, 0);
+    }
+    int leftmost = QApplication::desktop()->screenNumber(p);
 
     QHash<QString, PanelAppletProviderInterface*> plugins = loadPlugins();
 

=== modified file 'panel/applets/appname/appnameapplet.cpp'
--- panel/applets/appname/appnameapplet.cpp	2011-09-05 13:56:16 +0000
+++ panel/applets/appname/appnameapplet.cpp	2011-09-20 08:46:25 +0000
@@ -132,7 +132,11 @@
         m_label->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Minimum);
         m_label->setTextFormat(Qt::PlainText);
         // Align left of label with left of menubar
-        m_label->setContentsMargins(APPNAME_LABEL_LEFT_MARGIN, 0, 0, 0);
+        if (QApplication::isLeftToRight()) {
+            m_label->setContentsMargins(APPNAME_LABEL_LEFT_MARGIN, 0, 0, 0);
+        } else {
+            m_label->setContentsMargins(0, 0, APPNAME_LABEL_LEFT_MARGIN, 0);
+        }
         QFont font = m_label->font();
         font.setBold(true);
         m_label->setFont(font);

=== modified file 'panel/applets/appname/croppedlabel.cpp'
--- panel/applets/appname/croppedlabel.cpp	2011-09-15 08:33:23 +0000
+++ panel/applets/appname/croppedlabel.cpp	2011-09-20 08:46:25 +0000
@@ -32,6 +32,7 @@
 #include <gconfitem-qml-wrapper.h>
 
 // Qt
+#include <QApplication>
 #include <QImage>
 #include <QPainter>
 
@@ -61,10 +62,12 @@
 {
     QPainter painter(image);
     painter.setCompositionMode(QPainter::CompositionMode_DestinationIn);
-    QRect gradientRect(image->width() - FADEOUT_WIDTH, 0, FADEOUT_WIDTH, image->height());
+    bool isLeftToRight = QApplication::isLeftToRight();
+    QRect gradientRect(isLeftToRight ? image->width() - FADEOUT_WIDTH : 0, 0,
+                       FADEOUT_WIDTH, image->height());
     QLinearGradient gradient(gradientRect.topLeft(), gradientRect.topRight());
-    gradient.setColorAt(0, Qt::white);
-    gradient.setColorAt(1, Qt::transparent);
+    gradient.setColorAt(0, isLeftToRight ? Qt::white : Qt::transparent);
+    gradient.setColorAt(1, isLeftToRight ? Qt::transparent : Qt::white);
     painter.fillRect(gradientRect, gradient);
 }
 
@@ -117,7 +120,9 @@
     gtk_style_context_add_class(style_context, GTK_STYLE_CLASS_MENUITEM);
 
     gtk_render_layout(style_context, cr.data(),
-        contentsRect().left(),
+        QApplication::isLeftToRight() ?
+            contentsRect().left() :
+            contentsRect().right() - textWidth,
         contentsRect().top() + (height() - textHeight) / 2,
         layout.data());
 

=== modified file 'places/SearchEntry.qml'
--- places/SearchEntry.qml	2011-09-13 18:14:44 +0000
+++ places/SearchEntry.qml	2011-09-20 08:46:25 +0000
@@ -103,6 +103,7 @@
             anchors.leftMargin: -5
             anchors.right: parent.right
             anchors.verticalCenter: parent.verticalCenter
+            horizontalAlignment: Text.AlignLeft
 
             color: "#ffffff"
             font.pixelSize: 28
@@ -159,6 +160,8 @@
                 anchors.left: parent.left
                 anchors.right: parent.right
                 anchors.verticalCenter: parent.verticalCenter
+                LayoutMirroring.enabled: false
+                horizontalAlignment: isRightToLeft() ? Text.AlignRight : Text.AlignLeft
 
                 color: "white"
                 opacity: 0.5

=== modified file 'places/app/dashdeclarativeview.cpp'
--- places/app/dashdeclarativeview.cpp	2011-09-15 16:36:17 +0000
+++ places/app/dashdeclarativeview.cpp	2011-09-20 08:46:25 +0000
@@ -119,11 +119,16 @@
 DashDeclarativeView::resizeToDesktopModeSize()
 {
     QRect rect = availableGeometry();
+    int screenRight = rect.right();
 
     rect.setWidth(qMin(DASH_DESKTOP_WIDTH, rect.width()));
     rect.setHeight(qMin(m_expanded ? DASH_DESKTOP_EXPANDED_HEIGHT : DASH_DESKTOP_COLLAPSED_HEIGHT,
                         rect.height()));
 
+    if (QApplication::isRightToLeft()) {
+        rect.moveRight(screenRight);
+    }
+
     move(rect.topLeft());
     setFixedSize(rect.size());
 }
@@ -267,12 +272,16 @@
     QRect screenRect = QApplication::desktop()->screenGeometry(this);
     QRect availableRect = QApplication::desktop()->availableGeometry(this);
 
-    return QRect(
+    QRect availableGeometry(
         LauncherClient::MaximumWidth,
         availableRect.top(),
         screenRect.width() - LauncherClient::MaximumWidth,
         availableRect.height()
         );
+    if (QApplication::isRightToLeft()) {
+        availableGeometry.moveLeft(0);
+    }
+    return availableGeometry;
 }
 
 void

=== modified file 'places/dash.qml'
--- places/dash.qml	2011-09-16 13:07:35 +0000
+++ places/dash.qml	2011-09-20 08:46:25 +0000
@@ -16,7 +16,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-import QtQuick 1.0
+import QtQuick 1.1
 import Unity2d 1.0
 import Effects 1.0
 
@@ -24,9 +24,15 @@
     id: dash
 
     Accessible.name: "root"
+    LayoutMirroring.enabled: isRightToLeft()
+    LayoutMirroring.childrenInherit: true
 
     property variant currentPage
 
+    function isRightToLeft() {
+        return Qt.application.layoutDirection == Qt.RightToLeft
+    }
+
     Binding {
         target: dashView
         property: "expanded"
@@ -180,6 +186,7 @@
             anchors.fill: parent
             visible: dashView.dashMode == DashDeclarativeView.DesktopMode
             source: screen.isCompositingManagerRunning ? "artwork/desktop_dash_background.sci" : "artwork/desktop_dash_background_no_transparency.sci"
+            mirror: isRightToLeft()
         }
     }
 
@@ -289,6 +296,7 @@
         Image {
             id: fullScreenButtonImage
             source: "artwork/fullscreen_button.png"
+            mirror: isRightToLeft()
         }
 
         onClicked: {