unity-2d

Code review comment for lp:~mardy/unity-2d/rtl

  1. rtl
  2. Merge into trunk
Revision history for this message
Florian Boucault (fboucault) wrote :

I see lots of warnings on the console. For example when starting the dash:

unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $leftMargin() { return leftRight(-5,0) })" depends on non-NOTIFYable properties:
unity-2d-places: [WARNING] DashDeclarativeView::layoutDirection
unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $rightMargin() { return rightLeft(-5,0) })" depends on non-NOTIFYable properties:
unity-2d-places: [WARNING] DashDeclarativeView::layoutDirection
unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $right() { return rightLeft(parent.right) })" depends on non-NOTIFYable properties:
unity-2d-places: [WARNING] DashDeclarativeView::layoutDirection
unity-2d-places: [WARNING] QDeclarativeExpression: Expression "(function $left() { return leftRight(parent.left) })" depends on non-NOTIFYable properties:

review: Needs Fixing

« Back to merge proposal