Merge ~lucaskanashiro/ubuntu/+source/strongswan:re-enable-eap-plugins into ubuntu/+source/strongswan:ubuntu/devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Lucas Kanashiro | ||||
Approved revision: | 71090bca2d877bcb79c2193923f41dcb67c8ed2e | ||||
Merged at revision: | 71090bca2d877bcb79c2193923f41dcb67c8ed2e | ||||
Proposed branch: | ~lucaskanashiro/ubuntu/+source/strongswan:re-enable-eap-plugins | ||||
Merge into: | ubuntu/+source/strongswan:ubuntu/devel | ||||
Diff against target: |
107 lines (+34/-0) 5 files modified
debian/changelog (+15/-0) debian/control (+3/-0) debian/libcharon-extra-plugins.install (+6/-0) debian/libcharon-extra-plugins.maintscript (+8/-0) debian/rules (+2/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+384385@code.launchpad.net |
Description of the change
The proposed changes came from this bug:
https:/
They are:
- Re-enable the eap-dynamic and eap-peap libcharon plugins
- Remove some old conf files of some plugins removed from libcharon-
I submitted a MR to Debian to also re-enable those plugins there:
https:/
Here is a PPA with the proposed package:
https:/
autopkgtest is still happy:
autopkgtest [17:10:53]: @@@@@@@
admin-strongswa
admin-strongswa
daemon PASS
plugins PASS
Re-Addition of plugin - yes
Thanks for adding the commit with some details for the reasoning as we discussed it - that will help down the road even if Yves won't take it into Debian - at least we will remember the reasoning this time.
For the conffile handling I'm glad this was spotted and will now be fixed, but I'm not 100% +1 on the way to do it. I've myself learned the hard way that coding that up reads nicely but then next year someone spots there needs to be an action on e.g. abort-install and so on. extra-plugins. postrm :-)
Example of such issues - this MP misses libcharon-
Instead of the <pkg>.postinst/ prerm what usually works much much better is dropping d/<pgk>.maintscript with lines like .d/charon/ xauth-noauth. conf 5.8.4-1ubuntu2~
rm_conffile /etc/strongswan
I'd have other complains at the scripts, but since I'm suggesting to replace them anyway I don't need to go into that.
What do you think, any reason not to do this with the more reliable (just one place not getting out of sync, auto-covers all places needed, ...) .maintscript approach?