Code review comment for ~lucaskanashiro/ubuntu/+source/strongswan:re-enable-eap-plugins

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Re-Addition of plugin - yes
Thanks for adding the commit with some details for the reasoning as we discussed it - that will help down the road even if Yves won't take it into Debian - at least we will remember the reasoning this time.

For the conffile handling I'm glad this was spotted and will now be fixed, but I'm not 100% +1 on the way to do it. I've myself learned the hard way that coding that up reads nicely but then next year someone spots there needs to be an action on e.g. abort-install and so on.
Example of such issues - this MP misses libcharon-extra-plugins.postrm :-)

Instead of the <pkg>.postinst/prerm what usually works much much better is dropping d/<pgk>.maintscript with lines like
rm_conffile /etc/strongswan.d/charon/xauth-noauth.conf 5.8.4-1ubuntu2~

I'd have other complains at the scripts, but since I'm suggesting to replace them anyway I don't need to go into that.

What do you think, any reason not to do this with the more reliable (just one place not getting out of sync, auto-covers all places needed, ...) .maintscript approach?

review: Needs Fixing

« Back to merge proposal