Merge ~ilasc/launchpad:revision-status-submission-api into launchpad:master

[Ioana Lasc]

Add revision status submission API

[Ioana Lasc (ilasc)]

This is the branch in progress with the API test (test_newRevisionStatusReport) failing and the model test (test_findRevisionStatusReport) passing. There are quite a few pre-commit long lines truncated as part of the MP as well in order to be able to commit.

In parallel I will be working on further changes on the model side + Unit Tests (to cover updates and deletes and the RevisionStatusArtifact) - I won't be updating the MP so that input in current direction and failing unit test (test_newRevisionStatusReport) can be provided.

[Colin Watson (cjwatson)]

There is a *lot* of formatting noise in this MP; for example it isn't at all clear what substantive changes have been made to `lib/lp/testing/factory.py` because they're buried under a pile of indentation changes and similar. I expect to see all of these unrelated changes reverted before I take another look at this, because it's difficult to review otherwise. It's probably a good idea to run `git diff master...` and look over the output (effectively doing a self-review) before you push anything.

Some of the rest of my comments may collide with work you've already done locally; if so, sorry about that, and hopefully you can make sense of them. I think these comments should at least be enough to let you move forward, although they aren't a complete review yet.

[Ioana Lasc (ilasc)]

MP now ready for review.

[Colin Watson (cjwatson)]

Getting there, despite the large volume of comments here!

I think the main thing is to make sure that the API is the right sort of shape so that we don't paint ourselves into a corner. Consider making the API method that creates a new report check a feature rule for the time being, so that we can limit this to only authorized clients until we're sure that we're ready.

review: Needs Information

[Ioana Lasc (ilasc)]

While a large portion of comments have been updated on this MP there is still below set of things currently being worked on:

For this MP:

1: make the API method that creates a new report check a feature rule for the time being, so that we can limit this to only authorized clients until we're sure that we're ready.

2: export a method that takes the log as bytes, and creates the artifact object internally

3: Unit test for setLog over the API

4: on RevisionStatusArtifact while `log` needs to be in the interface for internal use, perhaps the exported API should be a `log_url` property

5: add at least a basic security adapter for the newky added IRevisionStatusArtifact

7: Unit Test for the result mutator

Next MP / Jira Issue:

1: putting `IRevisionStatus*` in a separate file (and the same for the implementation) rather than having it in the same module as `IGitRepository*`

[Colin Watson (cjwatson)]

I understand this is still work in progress, so I haven't done a full review, but I had a quick look through this today and had a couple of comments that might be useful to you at this stage.

[Ioana Lasc (ilasc)]

Indeed the comments were helpful Colin, thanks! This is now ready for review together with the DB patch (https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/409900).

[Colin Watson (cjwatson)]

Summary of the main points here, after which I think this will be good to go:

 * fix ambiguity in `RevisionStatusReport` items
 * export `IRevisionStatusReport.setLog` (or a variant of it that takes bytes rather than an artifact object) instead of `IGitRepository.setLogForStatusReport`
 * fix type of `IRevisionStatusReport.commit_sha1`
 * declare a proper feature rule exception
 * fix confusing definition of `EditRevisionStatusReport` security adapter

review: Needs Fixing

[Ioana Lasc (ilasc)]

Thanks Colin! Addressed all comments and when moving  TestRevisionStatusReportWebserviceFunctionalLayer started failing.

Added TestRevisionStatusReport to try to figure out what is wrong in the URL formatting but they are both failing with:

HTTP/1.1 404 Not Found
Content-Length: 112
Content-Type: text/plain;charset=utf-8

Object: <GitRepository '~person-name-100000/product-name-100005/+git/gitrepository-100002' (1)>, name: '+status'

Looks like I need to define traversal / navigation for reports.

[Ioana Lasc (ilasc)]

Navigation now works and DB patch changes are included in this version of the MP.

I do have however one last issue in test_setLogOnRevisionStatusReport failing with 401 "Current authentication does not allow access to this object." I need to investigate probably on Monday AM.

[Colin Watson (cjwatson)]

Iiiiiinteresting.

The problem here is that access tokens are scoped to a particular target, and if the context isn't exactly equal to the target then authenticating with an access token fails. We could work around this by moving the `setLog` method back to `IGitRepository` (with a more precise way to identify the correct revision status report), but I don't think that's really the best approach. Instead, I've proposed https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/412524, which allows access token targets to also be valid for objects subordinate to the target; that fixes this.

review: Approve

diff --git a/lib/lp/_schema_circular_imports.py b/lib/lp/_schema_circular_imports.py
index af21a01..e239ac2 100644
--- a/lib/lp/_schema_circular_imports.py
+++ b/lib/lp/_schema_circular_imports.py
@@ -64,7 +64,10 @@ from lp.code.interfaces.codereviewcomment import ICodeReviewComment
 from lp.code.interfaces.codereviewvote import ICodeReviewVoteReference
 from lp.code.interfaces.diff import IPreviewDiff
 from lp.code.interfaces.gitref import IGitRef
-from lp.code.interfaces.gitrepository import IGitRepository
+from lp.code.interfaces.gitrepository import (
+    IGitRepository,
+    IRevisionStatusReport,
+    )
 from lp.code.interfaces.gitrule import (
     IGitNascentRule,
     IGitNascentRuleGrant,
@@ -528,6 +531,10 @@ patch_collection_return_type(
 patch_list_parameter_type(
     IGitRepository, 'setRules', 'rules', InlineObject(schema=IGitNascentRule))
 
+# IRevisionStatusReport
+patch_reference_property(
+    IRevisionStatusReport, 'git_repository', IGitRepository)
+
 # ILiveFSFile
 patch_reference_property(ILiveFSFile, 'livefsbuild', ILiveFSBuild)
 
diff --git a/lib/lp/code/browser/configure.zcml b/lib/lp/code/browser/configure.zcml
index f7bab39..31b3938 100644
--- a/lib/lp/code/browser/configure.zcml
+++ b/lib/lp/code/browser/configure.zcml
@@ -963,6 +963,12 @@
         factory="lp.code.browser.gitrepository.GitRepositoryBreadcrumb"
         permission="zope.Public"/>
 
+  <browser:url
+        for="lp.code.interfaces.gitrepository.IRevisionStatusReport"
+        path_expression="string:+status/${id}"
+        attribute_to_parent="git_repository"
+        rootsite="code"/>
+
     <browser:defaultView
         for="lp.code.interfaces.gitref.IGitRef"
         name="+index"/>
diff --git a/lib/lp/code/browser/gitrepository.py b/lib/lp/code/browser/gitrepository.py
index 92a1b14..ddd79ca 100644
--- a/lib/lp/code/browser/gitrepository.py
+++ b/lib/lp/code/browser/gitrepository.py
@@ -106,6 +106,7 @@ from lp.code.interfaces.gitrepository import (
     ContributorGitIdentity,
     IGitRepository,
     IGitRepositorySet,
+    IRevisionStatusReportSet,
     )
 from lp.code.vocabularies.gitrule import GitPermissionsVocabulary
 from lp.registry.interfaces.person import (
@@ -190,6 +191,18 @@ class GitRepositoryNavigation(WebhookTargetNavigationMixin, Navigation):
 
     usedfor = IGitRepository
 
+    @stepthrough('+status')
+    def traverse_status(self, id):
+        try:
+            report_id = int(id)
+        except ValueError:
+            raise NotFoundError(report_id)
+        report = getUtility(
+            IRevisionStatusReportSet).getByID(report_id)
+        if report is None:
+            raise NotFoundError(report_id)
+        return report
+
     @stepto("+ref")
     def traverse_ref(self):
         segments = list(self.request.getTraversalStack())
diff --git a/lib/lp/code/configure.zcml b/lib/lp/code/configure.zcml
index 6417c89..fb8e0d5 100644
--- a/lib/lp/code/configure.zcml
+++ b/lib/lp/code/configure.zcml
@@ -953,6 +953,40 @@
     <allow interface="lp.code.interfaces.gitref.IGitRefRemoteSet" />
   </securedutility>
 
+  <!-- RevisionStatusReport -->
+
+  <class class="lp.code.model.gitrepository.RevisionStatusReport">
+    <require
+        permission="launchpad.View"
+        interface="lp.code.interfaces.gitrepository.IRevisionStatusReportView
+                   lp.code.interfaces.gitrepository.IRevisionStatusReportEditableAttributes" />
+    <require
+        permission="launchpad.Edit"
+        interface="lp.code.interfaces.gitrepository.IRevisionStatusReportEdit"
+        set_schema="lp.code.interfaces.gitrepository.IRevisionStatusReportEditableAttributes" />
+  </class>
+  <class class="lp.code.model.gitrepository.RevisionStatusArtifact">
+    <require
+        permission="launchpad.View"
+        interface="lp.code.interfaces.gitrepository.IRevisionStatusArtifact" />
+  </class>
+  <class class="lp.code.model.gitrepository.RevisionStatusReportSet">
+    <allow interface="lp.code.interfaces.gitrepository.IRevisionStatusReportSet" />
+  </class>
+  <securedutility
+      class="lp.code.model.gitrepository.RevisionStatusReportSet"
+      provides="lp.code.interfaces.gitrepository.IRevisionStatusReportSet">
+     <allow interface="lp.code.interfaces.gitrepository.IRevisionStatusReportSet" />
+  </securedutility>
+  <class class="lp.code.model.gitrepository.RevisionStatusArtifactSet">
+    <allow interface="lp.code.interfaces.gitrepository.IRevisionStatusArtifactSet" />
+  </class>
+  <securedutility
+      class="lp.code.model.gitrepository.RevisionStatusArtifactSet"
+      provides="lp.code.interfaces.gitrepository.IRevisionStatusArtifactSet">
+     <allow interface="lp.code.interfaces.gitrepository.IRevisionStatusArtifactSet" />
+  </securedutility>
+
   <!-- Git repository access rules -->
 
   <class class="lp.code.model.gitrule.GitRule">
diff --git a/lib/lp/code/enums.py b/lib/lp/code/enums.py
index 3765754..2dbd287 100644
--- a/lib/lp/code/enums.py
+++ b/lib/lp/code/enums.py
@@ -29,6 +29,8 @@ __all__ = [
     'GitRepositoryType',
     'NON_CVS_RCS_TYPES',
     'RevisionControlSystems',
+    'RevisionStatusArtifactType',
+    'RevisionStatusResult',
     'TargetRevisionControlSystems',
     ]
 
@@ -252,6 +254,54 @@ class GitPermissionType(EnumeratedType):
     CAN_FORCE_PUSH = Item("Can force-push")
 
 
+class RevisionStatusArtifactType(DBEnumeratedType):
+    LOG = DBItem(0, """
+        Log
+
+        The log produced by the check job.
+        """)
+
+
+class RevisionStatusResult(DBEnumeratedType):
+    """Revision Status Result"""
+
+    WAITING = DBItem(0, """
+        Waiting
+
+        The check job is waiting to be run.
+        """)
+
+    RUNNING = DBItem(1, """
+        Running
+
+        The check job is currently running.
+        """)
+
+    SUCCEEDED = DBItem(2, """
+        Succeeded
+
+        The check job ran successfully.
+        """)
+
+    FAILED = DBItem(3, """
+        Failed
+
+        The check job failed.
+        """)
+
+    SKIPPED = DBItem(4, """
+        Skipped
+
+        The check job was skipped.
+        """)
+
+    CANCELLED = DBItem(5, """
+        Cancelled
+
+        The check job was cancelled.
+        """)
+
+
 class BranchLifecycleStatusFilter(EnumeratedType):
     """Branch Lifecycle Status Filter
 
diff --git a/lib/lp/code/interfaces/gitrepository.py b/lib/lp/code/interfaces/gitrepository.py
index cb12a5d..47fb9a6 100644
--- a/lib/lp/code/interfaces/gitrepository.py
+++ b/lib/lp/code/interfaces/gitrepository.py
@@ -13,9 +13,15 @@ __all__ = [
     'IGitRepositoryExpensiveRequest',
     'IGitRepositorySet',
     'IHasGitRepositoryURL',
+    'IRevisionStatusArtifact',
+    'IRevisionStatusArtifactSet',
+    'IRevisionStatusReport',
+    'IRevisionStatusReportSet',
+    'RevisionStatusReportsFeatureDisabled',
     'user_has_special_git_repository_access',
     ]
 
+import http.client
 import re
 from textwrap import dedent
 
@@ -23,6 +29,7 @@ from lazr.lifecycle.snapshot import doNotSnapshot
 from lazr.restful.declarations import (
     call_with,
     collection_default_content,
+    error_status,
     export_destructor_operation,
     export_factory_operation,
     export_operation_as,
@@ -37,6 +44,7 @@ from lazr.restful.declarations import (
     operation_returns_collection_of,
     operation_returns_entry,
     REQUEST_USER,
+    scoped,
     )
 from lazr.restful.fields import (
     CollectionField,
@@ -50,6 +58,7 @@ from zope.interface import (
     )
 from zope.schema import (
     Bool,
+    Bytes,
     Choice,
     Datetime,
     Int,
@@ -57,10 +66,12 @@ from zope.schema import (
     Text,
     TextLine,
     )
+from zope.security.interfaces import Unauthorized
 
 from lp import _
 from lp.app.enums import InformationType
 from lp.app.validators import LaunchpadValidationError
+from lp.app.validators.attachment import attachment_size_constraint
 from lp.code.enums import (
     BranchMergeProposalStatus,
     BranchSubscriptionDiffSize,
@@ -69,6 +80,8 @@ from lp.code.enums import (
     GitListingSort,
     GitRepositoryStatus,
     GitRepositoryType,
+    RevisionStatusArtifactType,
+    RevisionStatusResult,
     )
 from lp.code.interfaces.defaultgit import ICanHasDefaultGitRepository
 from lp.code.interfaces.hasgitrepositories import IHasGitRepositories
@@ -91,6 +104,7 @@ from lp.services.fields import (
     InlineObject,
     PersonChoice,
     PublicPersonChoice,
+    URIField,
     )
 from lp.services.webhooks.interfaces import IWebhookTarget
 
@@ -813,6 +827,152 @@ class IGitRepositoryExpensiveRequest(Interface):
         that is not an admin or a registry expert."""
 
 
+@error_status(http.client.UNAUTHORIZED)
+class RevisionStatusReportsFeatureDisabled(Unauthorized):
+    """Only certain users can access APIs for revision status reports."""
+
+    def __init__(self):
+        super(RevisionStatusReportsFeatureDisabled, self).__init__(
+            "You do not have permission to create revision status reports")
+
+
+class IRevisionStatusReportView(Interface):
+    """`IRevisionStatusReport` attributes that require launchpad.View."""
+
+    id = Int(title=_("ID"), required=True, readonly=True)
+
+    date_created = exported(Datetime(
+        title=_("When the report was created."), required=True, readonly=True))
+    date_started = exported(Datetime(
+        title=_("When the report was started.")), readonly=False)
+    date_finished = exported(Datetime(
+        title=_("When the report has finished.")), readonly=False)
+
+
+class IRevisionStatusReportEditableAttributes(Interface):
+    """`IRevisionStatusReport` attributes that can be edited.
+
+    These attributes need launchpad.View to see, and launchpad.Edit to change.
+    """
+
+    title = exported(TextLine(
+        title=_("A short title for the report."), required=True))
+
+    git_repository = exported(Reference(
+        title=_("The Git repository for which this report is built."),
+        # Really IGitRepository, patched in _schema_circular_imports.py.
+        schema=Interface, required=True, readonly=True))
+
+    commit_sha1 = exported(TextLine(
+        title=_("The Git commit for which this report is built."),
+        required=True, readonly=True))
+
+    url = exported(URIField(title=_("URL"), required=False, readonly=True,
+                            description=_("The external url of the report.")))
+
+    result_summary = exported(TextLine(
+        title=_("A short summary of the result."), required=False))
+
+    result = exported(Choice(
+        title=_('Result of the report'),  readonly=True,
+        required=False, vocabulary=RevisionStatusResult))
+
+    @mutator_for(result)
+    @operation_parameters(result=copy_field(result))
+    @export_write_operation()
+    @operation_for_version("devel")
+    def transitionToNewResult(result):
+        """Set the RevisionStatusReport result.
+
+        Set the revision status report result."""
+
+
+class IRevisionStatusReportEdit(Interface):
+    """`IRevisionStatusReport` attributes that require launchpad.Edit."""
+
+    @operation_parameters(
+        log_data=Bytes(title=_("The content of the artifact in bytes."),
+                       constraint=attachment_size_constraint))
+    @scoped(AccessTokenScope.REPOSITORY_BUILD_STATUS.title)
+    @export_write_operation()
+    @export_operation_as(name="setLog")
+    @operation_for_version("devel")
+    def api_setLog(log_data):
+        """Set a new log on an existing status report.
+
+        :param log_data: The contents (in bytes) of the log.
+        """
+
+
+@exported_as_webservice_entry(as_of="beta")
+class IRevisionStatusReport(IRevisionStatusReportView,
+                            IRevisionStatusReportEditableAttributes,
+                            IRevisionStatusReportEdit):
+    """An revision status report for a Git commit."""
+
+
+class IRevisionStatusReportSet(Interface):
+    """The set of all revision status reports."""
+
+    def new(creator, title, git_repository, commit_sha1, date_created=None,
+            url=None, result_summary=None, result=None, date_started=None,
+            date_finished=None, log=None):
+        """Return a new revision status report.
+
+        :param title: A text string.
+        :param git_repository: An `IGitRepository` for which the report
+            is being created.
+        :param commit_sha1: The sha1 of the commit for which the report
+            is being created.
+        :param date_created: The date when the report is being created.
+        :param url: External URL to view result of report.
+        :param result_summary: A short summary of the result.
+        :param result: The result of the check job for this revision.
+        :param date_started: DateTime that report was started.
+        :param date_finished: DateTime that report was completed.
+        :param log: Stores the content of the artifact for this report.
+        """
+
+    def getByID(id):
+        """Returns the RevisionStatusReport for a given ID."""
+
+    def findByRepository(repository):
+        """Returns the set of RevisionStatusReport for a repository."""
+
+
+class IRevisionStatusArtifactSet(Interface):
+    """The set of all revision status artifacts."""
+
+    def new(lfa, report):
+        """Return a new revision status artifact.
+
+        :param lfa: An `ILibraryFileAlias`.
+        :param report: An `IRevisionStatusReport` for which the
+            artifact is being created.
+        """
+
+    def getByID(id):
+        """Returns the RevisionStatusArtifact for a given ID."""
+
+    def findByReport(report):
+        """Returns the set of artifacts for a given report."""
+
+
+class IRevisionStatusArtifact(Interface):
+    id = Int(title=_("ID"), required=True, readonly=True)
+
+    report = Attribute(
+        "The `RevisionStatusReport` that this artifact is linked to.")
+
+    library_file = Attribute(
+        "The `LibraryFileAlias` object containing information for "
+        "a revision status report.")
+
+    artifact_type = Choice(
+        title=_('The type of artifact, only log for now.'),
+        vocabulary=RevisionStatusArtifactType)
+
+
 class IGitRepositoryEdit(IWebhookTarget, IAccessTokenTarget):
     """IGitRepository methods that require launchpad.Edit permission."""
 
@@ -1015,6 +1175,26 @@ class IGitRepositoryEdit(IWebhookTarget, IAccessTokenTarget):
         :raise: CannotDeleteGitRepository if the repository cannot be deleted.
         """
 
+    @operation_parameters(
+        title=copy_field(IRevisionStatusReport["title"]),
+        commit_sha1=copy_field(IRevisionStatusReport["commit_sha1"]),
+        url=copy_field(IRevisionStatusReport["url"]),
+        result_summary=copy_field(IRevisionStatusReport["result_summary"]),
+        result=copy_field(IRevisionStatusReport["result"]))
+    @scoped(AccessTokenScope.REPOSITORY_BUILD_STATUS.title)
+    @call_with(user=REQUEST_USER)
+    @export_factory_operation(IRevisionStatusReport, [])
+    @operation_for_version("devel")
+    def newStatusReport(title, commit_sha1, url, result_summary, result, user):
+        """Create a new status report.
+
+        :param title: The name of the new report.
+        :param commit_sha1: The commit sha1 for the report.
+        :param url: The external link of the status report.
+        :param result_summary: The description of the new report.
+        :param result: The result of the new report.
+        """
+
 
 # XXX cjwatson 2015-01-19 bug=760849: "beta" is a lie to get WADL
 # generation working.  Individual attributes must set their version to
diff --git a/lib/lp/code/interfaces/webservice.py b/lib/lp/code/interfaces/webservice.py
index 02546e9..bd94298 100644
--- a/lib/lp/code/interfaces/webservice.py
+++ b/lib/lp/code/interfaces/webservice.py
@@ -31,6 +31,7 @@ __all__ = [
     'IGitSubscription',
     'IHasGitRepositories',
     'IPreviewDiff',
+    'IRevisionStatusReport',
     'ISourcePackageRecipe',
     'ISourcePackageRecipeBuild',
     ]
@@ -66,6 +67,7 @@ from lp.code.interfaces.gitref import IGitRef
 from lp.code.interfaces.gitrepository import (
     IGitRepository,
     IGitRepositorySet,
+    IRevisionStatusReport,
     )
 from lp.code.interfaces.gitsubscription import IGitSubscription
 from lp.code.interfaces.hasgitrepositories import IHasGitRepositories
diff --git a/lib/lp/code/model/gitrepository.py b/lib/lp/code/model/gitrepository.py
index 812f1d7..501ef29 100644
--- a/lib/lp/code/model/gitrepository.py
+++ b/lib/lp/code/model/gitrepository.py
@@ -6,6 +6,7 @@ __all__ = [
     'GitRepository',
     'GitRepositorySet',
     'parse_git_commits',
+    'RevisionStatusReport',
     ]
 
 from collections import (
@@ -19,6 +20,7 @@ from datetime import (
 import email
 from fnmatch import fnmatch
 from functools import partial
+import io
 from itertools import (
     chain,
     groupby,
@@ -102,6 +104,8 @@ from lp.code.enums import (
     GitPermissionType,
     GitRepositoryStatus,
     GitRepositoryType,
+    RevisionStatusArtifactType,
+    RevisionStatusResult,
     )
 from lp.code.errors import (
     CannotDeleteGitRepository,
@@ -131,6 +135,10 @@ from lp.code.interfaces.gitrepository import (
     GitIdentityMixin,
     IGitRepository,
     IGitRepositorySet,
+    IRevisionStatusArtifactSet,
+    IRevisionStatusReport,
+    IRevisionStatusReportSet,
+    RevisionStatusReportsFeatureDisabled,
     user_has_special_git_repository_access,
     )
 from lp.code.interfaces.gitrule import (
@@ -205,6 +213,7 @@ from lp.services.identity.interfaces.account import (
     )
 from lp.services.job.interfaces.job import JobStatus
 from lp.services.job.model.job import Job
+from lp.services.librarian.interfaces import ILibraryFileAliasSet
 from lp.services.macaroons.interfaces import IMacaroonIssuer
 from lp.services.macaroons.model import MacaroonIssuerBase
 from lp.services.mail.notificationrecipientset import NotificationRecipientSet
@@ -219,8 +228,9 @@ from lp.services.webhooks.model import WebhookTargetMixin
 from lp.snappy.interfaces.snap import ISnapSet
 
 
-logger = logging.getLogger(__name__)
+REVISION_STATUS_REPORT_ALLOW_CREATE = 'revision_status_report.allow_create'
 
+logger = logging.getLogger(__name__)
 
 object_type_map = {
     "commit": GitObjectType.COMMIT,
@@ -292,6 +302,132 @@ def git_repository_modified(repository, event):
     send_git_repository_modified_notifications(repository, event)
 
 
+@implementer(IRevisionStatusReport)
+class RevisionStatusReport(StormBase):
+    __storm_table__ = 'RevisionStatusReport'
+
+    id = Int(primary=True)
+
+    creator_id = Int(name="creator", allow_none=False)
+    creator = Reference(creator_id, "Person.id")
+
+    title = Unicode(name='name', allow_none=False)
+
+    git_repository_id = Int(name='git_repository', allow_none=False)
+    git_repository = Reference(git_repository_id, 'GitRepository.id')
+
+    commit_sha1 = Unicode(name='commit_sha1', allow_none=False)
+
+    url = Unicode(name='url', allow_none=True)
+
+    result_summary = Unicode(name='description', allow_none=True)
+
+    result = DBEnum(name='result', allow_none=True, enum=RevisionStatusResult)
+
+    date_created = DateTime(
+        name='date_created', tzinfo=pytz.UTC, allow_none=False)
+
+    date_started = DateTime(name='date_started', tzinfo=pytz.UTC,
+                            allow_none=True)
+    date_finished = DateTime(name='date_finished', tzinfo=pytz.UTC,
+                             allow_none=True)
+
+    def __init__(self, git_repository, user, title, commit_sha1,
+                 url, result_summary, result):
+        super().__init__()
+        self.creator = user
+        self.git_repository = git_repository
+        self.title = title
+        self.commit_sha1 = commit_sha1
+        self.url = url
+        self.result_summary = result_summary
+        self.result = result
+        self.date_created = UTC_NOW
+
+    def api_setLog(self, log_data):
+        filename = '%s-%s.txt' % (self.title, self.commit_sha1)
+
+        lfa = getUtility(ILibraryFileAliasSet).create(
+            name=filename, size=len(log_data),
+            file=io.BytesIO(log_data), contentType='text/plain')
+
+        getUtility(IRevisionStatusArtifactSet).new(lfa, self)
+
+    def transitionToNewResult(self, result):
+        if self.result == RevisionStatusResult.WAITING:
+            if result == RevisionStatusResult.RUNNING:
+                self.date_started == UTC_NOW
+        else:
+            self.date_finished = UTC_NOW
+        self.result = result
+
+
+@implementer(IRevisionStatusReportSet)
+class RevisionStatusReportSet:
+
+    def new(self, creator, title, git_repository, commit_sha1,
+            url=None, result_summary=None, result=None,
+            date_started=None, date_finished=None, log=None):
+        """See `IRevisionStatusReportSet`."""
+        store = IStore(RevisionStatusReport)
+        report = RevisionStatusReport(git_repository, creator, title,
+                                      commit_sha1, url, result_summary,
+                                      result)
+        store.add(report)
+        return report
+
+    def getByID(self, id):
+        return IStore(
+            RevisionStatusReport).find(RevisionStatusReport, id=id).one()
+
+    def findByRepository(self, repository):
+        return IStore(RevisionStatusReport).find(
+            RevisionStatusReport,
+            RevisionStatusReport.git_repository == repository)
+
+
+class RevisionStatusArtifact(StormBase):
+    __storm_table__ = 'RevisionStatusArtifact'
+
+    id = Int(primary=True)
+
+    library_file_id = Int(name='library_file', allow_none=False)
+    library_file = Reference(library_file_id, 'LibraryFileAlias.id')
+
+    report_id = Int(name='report', allow_none=False)
+    report = Reference(report_id, 'RevisionStatusReport.id')
+
+    artifact_type = DBEnum(name='type', allow_none=False,
+                           enum=RevisionStatusArtifactType)
+
+    def __init__(self, library_file, report):
+        super().__init__()
+        self.library_file = library_file
+        self.report = report
+        self.artifact_type = RevisionStatusArtifactType.LOG
+
+
+@implementer(IRevisionStatusArtifactSet)
+class RevisionStatusArtifactSet:
+
+    def new(self, lfa, report):
+        """See `IRevisionStatusArtifactSet`."""
+        store = IStore(RevisionStatusArtifact)
+        artifact = RevisionStatusArtifact(lfa, report)
+        store.add(artifact)
+        return artifact
+
+    def getById(self, id):
+        return IStore(RevisionStatusArtifact).find(
+            RevisionStatusArtifact,
+            RevisionStatusArtifact.id == id).one()
+
+    def findByReport(self, report):
+        return IStore(RevisionStatusArtifact).find(
+            RevisionStatusArtifact,
+            RevisionStatusArtifact.report == report)
+
+
 @implementer(IGitRepository, IHasOwner, IPrivacy, IInformationType)
 class GitRepository(StormBase, WebhookTargetMixin, AccessTokenTargetMixin,
                     GitIdentityMixin):
@@ -501,6 +637,16 @@ class GitRepository(StormBase, WebhookTargetMixin, AccessTokenTargetMixin,
     def collectGarbage(self):
         getUtility(IGitHostingClient).collectGarbage(self.getInternalPath())
 
+    def newStatusReport(self, user, title, commit_sha1, url=None,
+                        result_summary=None, result=None):
+
+        if not getFeatureFlag(REVISION_STATUS_REPORT_ALLOW_CREATE):
+            raise RevisionStatusReportsFeatureDisabled()
+
+        report = RevisionStatusReport(self, user, title, commit_sha1,
+                                      url, result_summary, result)
+        return report
+
     @property
     def namespace(self):
         """See `IGitRepository`."""
diff --git a/lib/lp/code/model/tests/test_gitrepository.py b/lib/lp/code/model/tests/test_gitrepository.py
index 252b535..764d13c 100644
--- a/lib/lp/code/model/tests/test_gitrepository.py
+++ b/lib/lp/code/model/tests/test_gitrepository.py
@@ -10,6 +10,7 @@ from datetime import (
 import email
 from functools import partial
 import hashlib
+import io
 import json
 
 from breezy import urlutils
@@ -65,6 +66,7 @@ from lp.code.enums import (
     GitObjectType,
     GitRepositoryStatus,
     GitRepositoryType,
+    RevisionStatusResult,
     TargetRevisionControlSystems,
     )
 from lp.code.errors import (
@@ -95,6 +97,8 @@ from lp.code.interfaces.gitrepository import (
     IGitRepository,
     IGitRepositorySet,
     IGitRepositoryView,
+    IRevisionStatusArtifactSet,
+    IRevisionStatusReportSet,
     )
 from lp.code.interfaces.gitrule import (
     IGitNascentRule,
@@ -121,6 +125,7 @@ from lp.code.model.gitrepository import (
     DeletionCallable,
     DeletionOperation,
     GitRepository,
+    REVISION_STATUS_REPORT_ALLOW_CREATE,
     )
 from lp.code.tests.helpers import GitHostingFixture
 from lp.code.xmlrpc.git import GitAPI
@@ -571,6 +576,24 @@ class TestGitRepository(TestCaseWithFactory):
         self.assertThat(recorder2, HasQueryCount.byEquality(recorder1))
         self.assertEqual(7, recorder1.count)
 
+    def test_findRevisionStatusReport(self):
+        repository = removeSecurityProxy(self.factory.makeGitRepository())
+        title = self.factory.getUniqueUnicode('report-title')
+        commit_sha1 = hashlib.sha1(b"Some content").hexdigest()
+        result_summary = "120/120 tests passed"
+
+        report = self.factory.makeRevisionStatusReport(
+            user=repository.owner, git_repository=repository,
+            title=title, commit_sha1=commit_sha1,
+            result_summary=result_summary,
+            result=RevisionStatusResult.SUCCEEDED)
+
+        with person_logged_in(repository.owner):
+            result = getUtility(
+                IRevisionStatusReportSet).getByID(
+                report.id)
+            self.assertEqual(report, result)
+
 
 class TestGitIdentityMixin(TestCaseWithFactory):
     """Test the defaults and identities provided by GitIdentityMixin."""
@@ -4241,6 +4264,66 @@ class TestGitRepositoryWebservice(TestCaseWithFactory):
             self.assertEqual(
                 InformationType.PUBLIC, repository_db.information_type)
 
+    def test_newRevisionStatusReport_featureFlagDisabled(self):
+        repository = self.factory.makeGitRepository()
+        requester = repository.owner
+        webservice = webservice_for_person(None, default_api_version="devel")
+        with person_logged_in(requester):
+            repository_url = api_url(repository)
+
+            secret, _ = self.factory.makeAccessToken(
+                owner=requester, target=repository,
+                scopes=[AccessTokenScope.REPOSITORY_BUILD_STATUS])
+            header = {'Authorization': 'Token %s' % secret}
+
+        response = webservice.named_post(
+            repository_url, "newStatusReport",
+            headers=header, title="CI",
+            commit_sha1=hashlib.sha1(
+                self.factory.getUniqueBytes()).hexdigest(),
+            url='https://launchpad.net/',
+            result_summary="120/120 tests passed",
+            result="Succeeded")
+
+        self.assertEqual(401, response.status)
+        self.assertIn(
+            b'You do not have permission to create revision status reports',
+            response.body)
+
+    def test_newRevisionStatusReport(self):
+        repository = self.factory.makeGitRepository()
+        requester = repository.owner
+        webservice = webservice_for_person(None, default_api_version="devel")
+        with person_logged_in(requester):
+            repository_url = api_url(repository)
+
+            secret, _ = self.factory.makeAccessToken(
+                owner=requester, target=repository,
+                scopes=[AccessTokenScope.REPOSITORY_BUILD_STATUS])
+            header = {'Authorization': 'Token %s' % secret}
+
+        self.useFixture(FeatureFixture(
+            {REVISION_STATUS_REPORT_ALLOW_CREATE: "on"}))
+
+        response = webservice.named_post(
+            repository_url, "newStatusReport",
+            headers=header, title="CI",
+            commit_sha1=hashlib.sha1(
+                self.factory.getUniqueBytes()).hexdigest(),
+            url='https://launchpad.net/',
+            result_summary="120/120 tests passed",
+            result="Succeeded")
+        self.assertEqual(201, response.status)
+
+        with person_logged_in(requester):
+            results = getUtility(
+                IRevisionStatusReportSet).findByRepository(repository)
+            reports = list(results)
+            urls = [webservice.getAbsoluteUrl('%s/+status/%s' % (
+                api_url(repository),
+                report.id)) for report in reports]
+            self.assertIn(response.getHeader("Location"), urls)
+
     def test_set_target(self):
         # The repository owner can move the repository to another target;
         # this redirects to the new location.
@@ -4831,6 +4914,60 @@ class TestGitRepositoryWebservice(TestCaseWithFactory):
             response.body)
 
 
+class TestRevisionStatusReportWebservice(TestCaseWithFactory):
+    layer = LaunchpadFunctionalLayer
+
+    def setUp(self):
+        super(TestRevisionStatusReportWebservice, self).setUp()
+        self.repository = self.factory.makeGitRepository()
+        self.requester = self.repository.owner
+        title = self.factory.getUniqueUnicode('report-title')
+        commit_sha1 = hashlib.sha1(b"Some content").hexdigest()
+        result_summary = "120/120 tests passed"
+
+        self.report = self.factory.makeRevisionStatusReport(
+            user=self.repository.owner, git_repository=self.repository,
+            title=title, commit_sha1=commit_sha1,
+            result_summary=result_summary,
+            result=RevisionStatusResult.SUCCEEDED)
+
+        self.webservice = webservice_for_person(
+            None, default_api_version="devel")
+        with person_logged_in(self.requester):
+            self.report_url = api_url(self.report)
+
+            secret, _ = self.factory.makeAccessToken(
+                owner=self.requester, target=self.repository,
+                scopes=[AccessTokenScope.REPOSITORY_BUILD_STATUS])
+            self.header = {'Authorization': 'Token %s' % secret}
+
+    def test_setLogOnRevisionStatusReport(self):
+        content = b'log_content_data'
+        filesize = len(content)
+        sha1 = hashlib.sha1(content).hexdigest()
+        md5 = hashlib.md5(content).hexdigest()
+        response = self.webservice.named_post(
+            self.report_url, "setLog",
+            headers=self.header,
+            log_data=io.BytesIO(content))
+        self.assertEqual(200, response.status)
+
+        # A report may have multiple artifacts.
+        # We verify that the content we just submitted via API now
+        # matches one of the artifacts in the DB for the report.
+        with person_logged_in(self.requester):
+            artifacts = list(getUtility(
+                IRevisionStatusArtifactSet).findByReport(self.report))
+            lfcs = [artifact.library_file.content for artifact in artifacts]
+            sha1_of_all_artifacts = [lfc.sha1 for lfc in lfcs]
+            md5_of_all_artifacts = [lfc.md5 for lfc in lfcs]
+            filesizes_of_all_artifacts = [lfc.filesize for lfc in lfcs]
+
+            self.assertIn(sha1, sha1_of_all_artifacts)
+            self.assertIn(md5, md5_of_all_artifacts)
+            self.assertIn(filesize, filesizes_of_all_artifacts)
+
+
 class TestGitRepositoryMacaroonIssuer(MacaroonTestMixin, TestCaseWithFactory):
     """Test GitRepository macaroon issuing and verification."""
 
diff --git a/lib/lp/security.py b/lib/lp/security.py
index 8f66fbb..8435167 100644
--- a/lib/lp/security.py
+++ b/lib/lp/security.py
@@ -99,6 +99,8 @@ from lp.code.interfaces.gitcollection import IGitCollection
 from lp.code.interfaces.gitref import IGitRef
 from lp.code.interfaces.gitrepository import (
     IGitRepository,
+    IRevisionStatusArtifact,
+    IRevisionStatusReport,
     user_has_special_git_repository_access,
     )
 from lp.code.interfaces.gitrule import (
@@ -683,6 +685,23 @@ class EditSpecificationByRelatedPeople(AuthorizationBase):
                     self.obj, ['owner', 'drafter', 'assignee', 'approver']))
 
 
+class EditRevisionStatusReport(AuthorizationBase):
+    """The owner of a Git repository can edit its status reports."""
+    permission = 'launchpad.Edit'
+    usedfor = IRevisionStatusReport
+
+    def checkAuthenticated(self, user):
+        return user.isOwner(self.obj.git_repository)
+
+
+class EditRevisionStatusArtifact(DelegatedAuthorization):
+    permission = 'launchpad.Edit'
+    usedfor = IRevisionStatusArtifact
+
+    def __init__(self, obj):
+        super().__init__(obj, obj.report, 'launchpad.Edit')
+
+
 class AdminSpecification(AuthorizationBase):
     permission = 'launchpad.Admin'
     usedfor = ISpecification
diff --git a/lib/lp/testing/factory.py b/lib/lp/testing/factory.py
index 9d59ba8..db48ed3 100644
--- a/lib/lp/testing/factory.py
+++ b/lib/lp/testing/factory.py
@@ -131,7 +131,10 @@ from lp.code.interfaces.gitref import (
     IGitRef,
     IGitRefRemoteSet,
     )
-from lp.code.interfaces.gitrepository import IGitRepository
+from lp.code.interfaces.gitrepository import (
+    IGitRepository,
+    IRevisionStatusArtifactSet,
+    )
 from lp.code.interfaces.linkedbranch import ICanHasLinkedBranch
 from lp.code.interfaces.revision import IRevisionSet
 from lp.code.interfaces.sourcepackagerecipe import (
@@ -146,6 +149,7 @@ from lp.code.model.diff import (
     Diff,
     PreviewDiff,
     )
+from lp.code.model.gitrepository import IRevisionStatusReportSet
 from lp.oci.interfaces.ocipushrule import IOCIPushRuleSet
 from lp.oci.interfaces.ocirecipe import IOCIRecipeSet
 from lp.oci.interfaces.ocirecipebuild import IOCIRecipeBuildSet
@@ -1843,6 +1847,30 @@ class BareLaunchpadObjectFactory(ObjectFactory):
                 grantee, grantor, can_create=can_create, can_push=can_push,
                 can_force_push=can_force_push)
 
+    def makeRevisionStatusReport(self, user=None, title=None,
+                                 git_repository=None, commit_sha1=None,
+                                 result_summary=None, url=None, result=None):
+        """Create a new RevisionStatusReport."""
+        if title is None:
+            title = self.getUniqueUnicode()
+        if git_repository is None:
+            git_repository = self.makeGitRepository()
+        if user is None:
+            user = git_repository.owner
+        if commit_sha1 is None:
+            commit_sha1 = hashlib.sha1(self.getUniqueBytes()).hexdigest()
+        return getUtility(IRevisionStatusReportSet).new(
+            user, title, git_repository, commit_sha1, result_summary,
+            url, result)
+
+    def makeRevisionStatusArtifact(self, lfa=None, report=None):
+        """Create a new RevisionStatusArtifact."""
+        if lfa is None:
+            lfa = self.makeLibraryFileAlias()
+        if report is None:
+            report = self.makeRevisionStatusReport()
+        return getUtility(IRevisionStatusArtifactSet).new(lfa, report)
+
     def makeBug(self, target=None, owner=None, bug_watch_url=None,
                 information_type=None, date_closed=None, title=None,
                 date_created=None, description=None, comment=None,