Code review comment for ~ilasc/launchpad:revision-status-submission-api

Revision history for this message
Ioana Lasc (ilasc) wrote :

While a large portion of comments have been updated on this MP there is still below set of things currently being worked on:

For this MP:

1: make the API method that creates a new report check a feature rule for the time being, so that we can limit this to only authorized clients until we're sure that we're ready.

2: export a method that takes the log as bytes, and creates the artifact object internally

3: Unit test for setLog over the API

4: on RevisionStatusArtifact while `log` needs to be in the interface for internal use, perhaps the exported API should be a `log_url` property

5: add at least a basic security adapter for the newky added IRevisionStatusArtifact

7: Unit Test for the result mutator

Next MP / Jira Issue:

1: putting `IRevisionStatus*` in a separate file (and the same for the implementation) rather than having it in the same module as `IGitRepository*`

« Back to merge proposal