Code review comment for ~ilasc/launchpad:revision-status-submission-api

Revision history for this message
Colin Watson (cjwatson) wrote :

Summary of the main points here, after which I think this will be good to go:

 * fix ambiguity in `RevisionStatusReport` items
 * export `IRevisionStatusReport.setLog` (or a variant of it that takes bytes rather than an artifact object) instead of `IGitRepository.setLogForStatusReport`
 * fix type of `IRevisionStatusReport.commit_sha1`
 * declare a proper feature rule exception
 * fix confusing definition of `EditRevisionStatusReport` security adapter

review: Needs Fixing

« Back to merge proposal