Code review comment for ~ilasc/launchpad:revision-status-submission-api

Revision history for this message
Colin Watson (cjwatson) wrote :

Iiiiiinteresting.

The problem here is that access tokens are scoped to a particular target, and if the context isn't exactly equal to the target then authenticating with an access token fails. We could work around this by moving the `setLog` method back to `IGitRepository` (with a more precise way to identify the correct revision status report), but I don't think that's really the best approach. Instead, I've proposed https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/412524, which allows access token targets to also be valid for objects subordinate to the target; that fixes this.

review: Approve

« Back to merge proposal