Merge lp:~xnox/ubuntu-seeds/touch-content-hub into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic

[Dimitri John Ledkov]

[Dimitri John Ledkov (xnox)]

content-hub is already in touch seed, but it's missing from the sdk.

[Loïc Minier (lool)]

Purely cosmetic but would you mind listing libcontent-hub0 in a separate section about C libs? qtdeclarative5-ubuntu-content0.1 is already listed for the QML API/ABI. Thanks!

[Dimitri John Ledkov (xnox)]

On 3 June 2014 11:48, Loïc Minier <email address hidden> wrote:
> Purely cosmetic but would you mind listing libcontent-hub0 in a separate section about C libs? qtdeclarative5-ubuntu-content0.1 is already listed for the QML API/ABI. Thanks!

Like for example, in some kind of a "Platform API" section which we
don't seem to have at the moment? Shouldn't e.g.
libplatform-api-headers/libplatform-hardware-api-headers be seeded in
the SDK or are those not meant to be exposed as stable app-developer
interfaces?

--
Regards,

Dimitri.

[Loïc Minier (lool)]

Yup, exactly

On Tue, Jun 3, 2014 at 12:54 PM, Dimitri John Ledkov <<email address hidden>
> wrote:

> On 3 June 2014 11:48, Loïc Minier <email address hidden> wrote:
> > Purely cosmetic but would you mind listing libcontent-hub0 in a separate
> section about C libs? qtdeclarative5-ubuntu-content0.1 is already listed
> for the QML API/ABI. Thanks!
>
> Like for example, in some kind of a "Platform API" section which we
> don't seem to have at the moment? Shouldn't e.g.
> libplatform-api-headers/libplatform-hardware-api-headers be seeded in
> the SDK or are those not meant to be exposed as stable app-developer
> interfaces?
>
> --
> Regards,
>
> Dimitri.
>
>
> https://code.launchpad.net/~xnox/ubuntu-seeds/touch-content-hub/+merge/221856
> You are requested to review the proposed merge of
> lp:~xnox/ubuntu-seeds/touch-content-hub into
> lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic.
>

[lp:~xnox/ubuntu-seeds/touch-content-hub]

196. By Dimitri John Ledkov on 2014-06-03

Seed content-hub native apis

[Iain Lane (laney)]

It seems weird to seed the shared library like that - shouldn't it be pulled in by dependencies?

[Dimitri John Ledkov (xnox)]

On 4 June 2014 17:43, Iain Lane <email address hidden> wrote:
> It seems weird to seed the shared library like that - shouldn't it be pulled in by dependencies?

it is currently pulled in:
* into touch, by content-hub
* into dev, by libcontent-dev

However, libcontent-hub0 is part of the ABI contract, and if clicks
use it, it must be present in sdk-libs directly & not dropped without
changing framework. (forexample if/when content-hub starts using
libcontent-hub1 for example).
Maybe, I'm wrong, I'll be ok with dropping the extra explicit seed, if
that's the consensus.

--
Regards,

Dimitri.

[Loïc Minier (lool)]

Exactly; the point is that C apps in Click packages might link directly to
libcontent-hub0 and we should; this is different from using the content hub
QML bindings which we might be able to keep stable for different (probably
longer) periods of time. Only a couple of apps link directly to content-hub
today though (at least gallery-app does).

Cheers,

On Wed, Jun 4, 2014 at 6:54 PM, Dimitri John Ledkov <email address hidden>
wrote:

> On 4 June 2014 17:43, Iain Lane <email address hidden> wrote:
> > It seems weird to seed the shared library like that - shouldn't it be
> pulled in by dependencies?
>
> it is currently pulled in:
> * into touch, by content-hub
> * into dev, by libcontent-dev
>
> However, libcontent-hub0 is part of the ABI contract, and if clicks
> use it, it must be present in sdk-libs directly & not dropped without
> changing framework. (forexample if/when content-hub starts using
> libcontent-hub1 for example).
> Maybe, I'm wrong, I'll be ok with dropping the extra explicit seed, if
> that's the consensus.
>
> --
> Regards,
>
> Dimitri.
>
>
> https://code.launchpad.net/~xnox/ubuntu-seeds/touch-content-hub/+merge/221856
> You are requested to review the proposed merge of
> lp:~xnox/ubuntu-seeds/touch-content-hub into
> lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic.
>

[Oliver Grawert (ogra)]

seems this was merged a while ago

=== modified file 'sdk'
--- sdk	2014-04-04 10:52:41 +0000
+++ sdk	2014-06-03 11:51:14 +0000
@@ -15,6 +15,7 @@
  * qtscript5-doc
  * qtsvg5-doc
  * qttools5-doc
+ * libcontent-hub-doc
 
 = Ubuntu UI Toolkit =
 

=== modified file 'sdk-libs'
--- sdk-libs	2014-05-29 12:30:01 +0000
+++ sdk-libs	2014-06-03 11:51:14 +0000
@@ -38,6 +38,10 @@
  * qtdeclarative5-ubuntu-mediascanner0.1
  * qtdeclarative5-ubuntu-syncmonitor0.1
 
+= Platform APIs =
+
+ * libcontent-hub0
+
 = Multimedia =
 
 Preferred set of codecs for oxide.

=== modified file 'sdk-libs-dev'
--- sdk-libs-dev	2014-04-04 10:52:41 +0000
+++ sdk-libs-dev	2014-06-03 11:51:14 +0000
@@ -27,6 +27,10 @@
  # forces Qt5 as the default; conflicts with Qt4 -- XXX should be a Recommends?
  * qt5-default
 
+= Platform APIs =
+
+ * libcontent-hub-dev
+
 = Documentation and example code =
 
  * (ubuntu-html5-theme-examples)