Code review comment for lp:~xnox/ubuntu-seeds/touch-content-hub

Exactly; the point is that C apps in Click packages might link directly to
libcontent-hub0 and we should; this is different from using the content hub
QML bindings which we might be able to keep stable for different (probably
longer) periods of time. Only a couple of apps link directly to content-hub
today though (at least gallery-app does).

Cheers,

On Wed, Jun 4, 2014 at 6:54 PM, Dimitri John Ledkov <email address hidden>
wrote:

> On 4 June 2014 17:43, Iain Lane <email address hidden> wrote:
> > It seems weird to seed the shared library like that - shouldn't it be
> pulled in by dependencies?
>
> it is currently pulled in:
> * into touch, by content-hub
> * into dev, by libcontent-dev
>
> However, libcontent-hub0 is part of the ABI contract, and if clicks
> use it, it must be present in sdk-libs directly & not dropped without
> changing framework. (forexample if/when content-hub starts using
> libcontent-hub1 for example).
> Maybe, I'm wrong, I'll be ok with dropping the extra explicit seed, if
> that's the consensus.
>
> --
> Regards,
>
> Dimitri.
>
>
> https://code.launchpad.net/~xnox/ubuntu-seeds/touch-content-hub/+merge/221856
> You are requested to review the proposed merge of
> lp:~xnox/ubuntu-seeds/touch-content-hub into
> lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic.
>