Code review comment for lp:~xnox/ubuntu-seeds/touch-content-hub

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 4 June 2014 17:43, Iain Lane <email address hidden> wrote:
> It seems weird to seed the shared library like that - shouldn't it be pulled in by dependencies?

it is currently pulled in:
* into touch, by content-hub
* into dev, by libcontent-dev

However, libcontent-hub0 is part of the ABI contract, and if clicks
use it, it must be present in sdk-libs directly & not dropped without
changing framework. (forexample if/when content-hub starts using
libcontent-hub1 for example).
Maybe, I'm wrong, I'll be ok with dropping the extra explicit seed, if
that's the consensus.

--
Regards,

Dimitri.

« Back to merge proposal