Code review comment for ~vultaire/charm-sysconfig:lp1841809

Revision history for this message
Paul Goins (vultaire) wrote :

Most comments addressed. Did not use set_flag(...) since cpufrequtils also handles a service restart in the same way (in the lib module rather than via a flag-based reactive hook); if we change it for resolved, I think we should change it for cpufrequtils as well - and that starts to work its way out of scope in my opinion.

« Back to merge proposal