~vultaire/charm-sysconfig:lp1841809

Last commit made on 2020-02-12
Get this branch:
git clone -b lp1841809 https://git.launchpad.net/~vultaire/charm-sysconfig
Only Paul Goins can upload to this branch. If you are Paul Goins please log in for upload directions.

Branch merges

Branch information

Name:
lp1841809
Repository:
lp:~vultaire/charm-sysconfig

Recent commits

d732035... by Paul Goins

Removing unneeded hashlib import

5b29afe... by Paul Goins

any_file_changed takes a list, not *args

504be02... by Paul Goins

Reworked/refactored to use any_file_changed helper method

961b480... by Paul Goins

Adding tests for code using checksums

96dff31... by Paul Goins

Adding checksum check to determine whether we restart resolved.

75ec951... by Paul Goins

Addressing most of Alvaro's concerns per code review

* Reformatted to 120 chars max per line.

* Small tweak made to template.

* Fixed resolved-cache-mode default value: intended to be "" (system
  default), but was left as "yes" as it was set before I added the ""
  option.

* Changes to resolved.conf don't require a reboot; they just require a
  service restart. Thus, am using _render_resource() (new helper
  function) instead of _render_boot_resource() for rendering the file,
  and have added a service restart as a side effect of the config
  changes, the same as is done for cpufrequtils.

  The restart ideally should only be done if there were actually any
  changes to the config file; I will add this in the next commit.

b2b150e... by Paul Goins

Refactored and added case for resolved-cache-mode.

83916be... by Paul Goins

Fixed unit tests which my changes broke.

aa522f2... by Paul Goins

Refactored repetitive code, fixed log message

Note: the raid-autodetection log message logged that "off" was a valid
value, but that is incorrect based upon the set of values actually
checked against.

44b9156... by Paul Goins

Implemented systemd-resolved cache config feature

* Copied the systemd.conf-related code and reworked to fit controlling
  resolved.conf.

* Updated the test from the previous commit and added extra tests to
  cover the new code.

* Removed "cosmic" from the list of test series'; while expected to
  fail, this failing test added considerable time to running the whole
  functional test suite due to the 10 minute TIMEOUT constant.

* Refactored 2 tests related to testing invalid config values into one
  parameterized test, then added values to test the resolved-cache-mode
  config value.

* Fixed a few trivially-inaccurate docstrings.