Code review comment for lp:~townsend/compiz/fix-lp1092323

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Playing devil's advocate here (and my opinion doesn't count for much
because I don't work on or use compiz anymore) - the reason I added this
behavior is because of the impreciseness that comes with viewports
generally. There's not much of a practical use for a window being both
active and on two viewports at the same time. (Why would you only want to
use half a window?). If a user has activated their window and we've changed
viewports because the majority of it was on another viewport, then moving
the window so that it is completely on-screen saves the extra step of
having to place the window manually.

I don't care much about how this goes either way, but it is some food for
thought at least.

On Tue, Aug 27, 2013 at 5:43 PM, MC Return <email address hidden> wrote:

> IMHO changing the viewport if the center of the window is on the new
> viewport makes some sense, but the window should *!never!* be moved around
> by Compiz when the user just switches to it -> that is really nasty, ugly
> behaviour.
> --
> https://code.launchpad.net/~townsend/compiz/fix-lp1092323/+merge/181334
> Your team Compiz Maintainers is subscribed to branch lp:compiz.
>

--
Sam Spilsbury

« Back to merge proposal