Merge lp:~townsend/compiz/fix-lp1092323 into lp:compiz/0.9.11

[Christopher Townsend]

Alt-Tabbing or Launcher selecting a window that is over 50% in a different viewport should not switch the viewport nor change the placement of the window. The fix is to add an option to turn this behavior on or off. By default, the option is on, but Ubuntu is patched to turn it off to fix this bug.

Ayatana Design has requested that when Alt-Tabbing to a window that is more than 50% contained in a different viewport, that:
1. The viewport does not switch and;
2. The window's position stays where it currently is.

This fix adds an option to either enable of disable this behavior. By default, the behavior is enabled, meaning nothing changes from current behavior. An Ubuntu patch is included to disable this behavior to match what Design wants.

[Brandon Schaefer (brandontschaefer)]

Looks good, but after talking with duflu, we should do this:

Create an option to turn this off/on. Then create a patch that turns this on for ubuntu, and leave it off by default.

This way users outside of ubuntu don't get hit by this, while making the patch very small.

review: Needs Fixing

[MC Return (mc-return)]

IMHO changing the viewport if the center of the window is on the new viewport makes some sense, but the window should *!never!* be moved around by Compiz when the user just switches to it -> that is really nasty, ugly behaviour.

[Sam Spilsbury (smspillaz)]

Playing devil's advocate here (and my opinion doesn't count for much
because I don't work on or use compiz anymore) - the reason I added this
behavior is because of the impreciseness that comes with viewports
generally. There's not much of a practical use for a window being both
active and on two viewports at the same time. (Why would you only want to
use half a window?). If a user has activated their window and we've changed
viewports because the majority of it was on another viewport, then moving
the window so that it is completely on-screen saves the extra step of
having to place the window manually.

I don't care much about how this goes either way, but it is some food for
thought at least.

On Tue, Aug 27, 2013 at 5:43 PM, MC Return <email address hidden> wrote:

> IMHO changing the viewport if the center of the window is on the new
> viewport makes some sense, but the window should *!never!* be moved around
> by Compiz when the user just switches to it -> that is really nasty, ugly
> behaviour.
> --
> https://code.launchpad.net/~townsend/compiz/fix-lp1092323/+merge/181334
> Your team Compiz Maintainers is subscribed to branch lp:compiz.
>

--
Sam Spilsbury

[Christopher Townsend (townsend)]

Setting this a WIP to make this an option instead of just ripping out the code. Then patch Ubuntu to disable the code path so the viewport switch/window move will not occur.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:3786
http://jenkins.qa.ubuntu.com/job/compiz-ci/291/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-amd64-ci/104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-armhf-ci/104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-i386-ci/104/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-ci/291/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:3786
http://jenkins.qa.ubuntu.com/job/compiz-ci/293/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-amd64-ci/107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-armhf-ci/106/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-i386-ci/106/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-ci/293/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3786
http://jenkins.qa.ubuntu.com/job/compiz-ci/294/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-amd64-ci/108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-armhf-ci/107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-i386-ci/107

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-ci/294/rebuild

review: Approve (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

LGTM

review: Approve

[Gerhard Radatz (gerhard-radatz)]

Folks. I have updated to the latest compiz which contains this "bug fix". Afterwards, I Alt-Tabbed (or selected with Alt-<Num> via the Unity side bar) a window which was COMPLETELY on another viewport. Just nothing happend, I had to switch manually to this other viewport.

So for a naive user, this appears to be a new bug then!

I don't think its a good decision to introduce unwanted and obiously buggy behaviour for the common case ("switch to another window which is completely on another viewport"), whilst fixing a bug for the rare case ("switch to another window which is partially on another viewport").

[Christopher Townsend (townsend)]

Hi Gerhard,

I understand why you put a comment in this merge proposal, but if you think there may be a regression or a bug you discover, please open a new bug so we can track it easier.

That said, the default behavior is to Alt-Tab only windows on the current workspace. This default behavior has been present for some time in Unity. This behavior has nothing to do with this fix. If you don't like this default behavior, then it is quite easy to change it.

Open ccsm, choose the Unity plugin, select the Switcher tab, and then deselect "Bias alt-tab to prefer windows on the current viewport". This will allow you to Alt-Tab to windows contained in other workspaces.

Perhaps you had this set and an update somehow reset this value, but that is just a guess.

Thanks!

[Gerhard Radatz (gerhard-radatz)]

Hi Christopher,

I had intentionally changed the Alt-Tab behaviour to include all windows on all workspaces for a long time. With the new fix, this behaviour effectively didn't work anymore. I had to check the new "auto switch vp and window" setting to make it work again.

[Christopher Townsend (townsend)]

Hi Gerhard,

My apologies for misunderstanding your use case. I see the regression you are describing. I'll enter a new bug and see about getting it fixed.

Thanks!

=== modified file 'debian/patches/ubuntu-config.patch'
--- debian/patches/ubuntu-config.patch	2013-07-23 23:30:23 +0000
+++ debian/patches/ubuntu-config.patch	2013-08-28 12:18:58 +0000
@@ -653,7 +653,16 @@
  						</default>
  					</option>
  				</subgroup>
-@@ -351,7 +351,7 @@
+@@ -201,7 +201,7 @@
+ 				<option name="auto_switch_vp_and_window" type="bool">
+ 					<_short>Auto Switch Vp And Window</_short>
+ 					<_long>Auto switch the viewport and move window when Alt-Tab to window that is more than half contained in another viewport</_long>
+-					<default>true</default>
++					<default>false</default>
+ 				</option>
+ 			</group>
+ 			<group>
+@@ -356,7 +356,7 @@
  				<option name="edgeflip_move" type="bool">
  					<_short>Edge Flip Move</_short>
  					<_long>Flip viewport when moving a window to a screen edge</_long>

=== modified file 'plugins/wall/src/wall.cpp'
--- plugins/wall/src/wall.cpp	2013-05-15 10:38:49 +0000
+++ plugins/wall/src/wall.cpp	2013-08-28 12:18:58 +0000
@@ -553,7 +553,7 @@
 {
     WALL_SCREEN (screen);
 
-    if (window->placed () && !screen->otherGrabExist ("wall", "switcher", 0))
+    if (ws->optionGetAutoSwitchVpAndWindow () && window->placed () && !screen->otherGrabExist ("wall", "switcher", 0))
     {
 	int       dx, dy;
 	CompPoint viewport;

=== modified file 'plugins/wall/wall.xml.in'
--- plugins/wall/wall.xml.in	2013-04-27 03:18:27 +0000
+++ plugins/wall/wall.xml.in	2013-08-28 12:18:58 +0000
@@ -198,6 +198,11 @@
 					<_long>Windows that should not slide during the slide animation</_long>
 					<default>type=Dock | type=Desktop | state=Sticky</default>
 				</option>
+				<option name="auto_switch_vp_and_window" type="bool">
+					<_short>Auto Switch Vp And Window</_short>
+					<_long>Auto switch the viewport and move window when Alt-Tab to window that is more than half contained in another viewport</_long>
+					<default>true</default>
+				</option>
 			</group>
 			<group>
 				<_short>Bindings</_short>