lp:~townsend/compiz/fix-lp1092323

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.11 at revision 3788

Brandon Schaefer (community): Approve on 2013-09-06

PS Jenkins bot (community): Approve (continuous-integration) on 2013-08-29

Diff: 50 lines (+16/-2)

3 files modified

debian/patches/ubuntu-config.patch (+10/-1)
plugins/wall/src/wall.cpp (+1/-1)
plugins/wall/wall.xml.in (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1092323: Window management - Switching to windows placed on two work spaces causes the workspace to switch

High

Fix Released

Link a bug report

Related blueprints

3786. By Christopher Townsend on 2013-08-28

Instead of ripping out the code to change the auto viewport switch a window move when Alt-Tabbing to a window that is more than 50% in another viewport, use an option instead where this behavior will occur by default and patch Ubuntu to turn this behavior off.

3785. By Christopher Townsend on 2013-08-28

Revert the previous commit in order to change this into using an option instead of ripping out the code.

3784. By Christopher Townsend on 2013-08-21

Alt-Tabbing or Launcher selecting a window that is over 50% in a different viewport should not switch the viewport nor change the placement of the window. The fix is to remove the WallWindow::activate() function since it is what causes the undesired behavior.

3783. By Andrea Azzarone on 2013-08-20

Use Glib::RefPtr<Glib::Source> in glib_integration_test. After the fix of bug https://bugzilla.gnome.org/show_bug.cgi?id=561885 Glib::Source::~Source is called when both Source::unreference() and SourceCallbackData::destroy_notify_callback() are called. Fixes: https://bugs.launchpad.net/bugs/1214459.

Approved by PS Jenkins bot, Stephen M. Webb.

3782. By Michail Bitzes on 2013-07-25

Wizard plugin:

No more segfaults/crashes when changing options in CCSM. (LP: #1195996)
Gradual fade out of particles when terminating. (LP: #1196010)
Typo fixed in wizard.xml.in.
optionNotify added for some options that were missing it.

Code cleanup:

Declare variables outside of loops.

Functions moved from class WizardScreen to class ParticleSystem.
(similar to firepaint/showmouse)

We just enable GL_BLEND if it is disabled and
we just disable GL_BLEND if it was disabled before.

Many other style and indentation fixes. Fixes: https://bugs.launchpad.net/bugs/1195996, https://bugs.launchpad.net/bugs/1196010.

Approved by PS Jenkins bot, MC Return.

3781. By MC Return on 2013-07-25

Animation code cleanup:

Return ASAP, do not calculate stuff you might not need.
Declare CompWindow *w, AnimWindow *animWin, PrivateAnimWindow *aw
and Animation *curAnim outside the for loop.
grid.cpp: Declare float x, y, topiyFloat outside the for loop.
options.cpp: Declare unsigned int nOptions outside the foreach loop.
Use pre- instead of postfix de- and increments.
Declaration and assignment of variables in one line.
Merged if condition checks.
Added and removed brackets.
Added and removed newlines.
Fixed indentation.
Also initialize the non-static class members "mGridWidth" and
"mGridHeight" in the GridAnim::GridAnim ctor. (LP: #1101618). Fixes: https://bugs.launchpad.net/bugs/1101618.

Approved by Sami Jaktholm, PS Jenkins bot.

3780. By Andrea Azzarone on 2013-07-25

Disable show_desktop_key by default on ubuntu. Will provide the same option under the unityshell panel. Fixes: https://bugs.launchpad.net/bugs/1204664.

Approved by PS Jenkins bot, Sam Spilsbury.

3779. By MC Return on 2013-07-25

gears.cpp, gears.h:

Do not render the gears if we are viewing the cube from the inside -
the gears are otherwise obstructing the users' view on his workspaces.

Print a warning to the console once in this case.

(LP: #1185819). Fixes: https://bugs.launchpad.net/bugs/1185819.

Approved by Sam Spilsbury, PS Jenkins bot.

3778. By Daniel van Vugt on 2013-07-23

This branch is 0.9.11

3777. By MC Return on 2013-07-22

plugins/ezoom/src/ezoom.cpp:
Also initialize xtrans and ytrans in the ctors.
Just just enable blending if it is disabled and just
disable it if it was disabled before.
Introduced the variables oWidth, oHeight, halfOWidth and
halfOHeight to speed up following calculations.
Return ASAP, do not calculate possibly redundant stuff.
Declaration and assignment of local variables in one line.
Improved readability.
Added and removed newlines.
Minor indentation fixes.

plugins/ezoom/ezoom.xml.in:
Removed redundant whitespaces from a tooltip.

(LP: #1101572). Fixes: https://bugs.launchpad.net/bugs/1101572.

Approved by Sam Spilsbury, PS Jenkins bot.