lp:~sjakthol/compiz/fix-1066187

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3419

Daniel van Vugt: Approve on 2012-10-16

MC Return: Approve on 2012-10-15

PS Jenkins bot: Pending (continuous-integration) requested 2012-10-16

Diff: 84 lines (+30/-7)

2 files modified

plugins/ezoom/src/ezoom.cpp (+22/-6)
plugins/ezoom/src/ezoom.h (+8/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1066187: Enhanced Desktop Zoom: Specific Zoom Factor ignored

Low

Fix Released

Link a bug report

Related blueprints

3416. By Sami Jaktholm on 2012-10-15

Fix brackets.

3415. By Sami Jaktholm on 2012-10-13

Problem:
Specific Zoom Factor settings were ignored by the Enhanced Zoom Desktop (LP: #1066187) because the values were only read once during initial load of the plugin probably before the user defined configuration was read (and thus it always used the default values).

Fix:
Instead of sending the (original) value of the initiated zoom level, send a zoom level identifier. The identifier is used to determine which zoom level the user wants and a fresh setting for that zoom level is used.

3414. By Daniel van Vugt on 2012-10-12

Don't try writing to const static memory. Any sane compiler like clang will
put const static data into a read-only memory section. This means any write
to it will segfault.
(LP: #1065814)
. Fixes: https://bugs.launchpad.net/bugs/1065814. Approved by Sam Spilsbury, jenkins.

3413. By Sam Spilsbury on 2012-10-11

Added tests for the StringToModifiers and ModifiersToString code, move the
code which detects <Primary> as ControlMask upstream and use two functions to
ensure that duplicates aren't added.

Fixes Jenkins failures. (LP: #1058577). Fixes: https://bugs.launchpad.net/bugs/936840, https://bugs.launchpad.net/bugs/1058577. Approved by Daniel van Vugt, Sam Spilsbury.

3412. By Sam Spilsbury on 2012-10-09

Fix numerous problems with invalid C/C++ code that prevent us from building
with clang/clang++.
(LP: #1060804). Fixes: https://bugs.launchpad.net/bugs/1060804. Approved by Daniel van Vugt.

3411. By Daniel van Vugt on 2012-10-06

Fix leakage of destroyed_pixmaps_table, containing pointers to freed decor_t's
which could result in a freed GHashTable being passed into g_hash_table_remove
and causing a crash.
(LP: #1060171). Fixes: https://bugs.launchpad.net/bugs/1060171. Approved by Sam Spilsbury.

3410. By Sam Spilsbury on 2012-10-03

Check the return value of pkg_check_modules and don't check for
libcompizconfig_internal (LP: #1060708). Fixes: https://bugs.launchpad.net/bugs/1060708. Approved by Daniel van Vugt.

3409. By Sam Spilsbury on 2012-10-03

Slightly more verbose matchers for CCSSettingValue so we can see what's going wrong in the tests.. Fixes: . Approved by Daniel van Vugt.

3408. By Brandon Schaefer on 2012-10-03

Added a new template that will check tap_detection. If it is false then add
CompAction::StateTapIgnore to the actions state.

If StateTapIgnore is set then in grabUngrabManyKeys ignore grabbing all
modifier+<keys>, because we don't care if the modifier is a tap or not.

This allows for Super+P to work with this unity branch:
https://code.launchpad.net/~brandontschaefer/unity/disable-tap-for-super/+merge/127407. Fixes: https://bugs.launchpad.net/bugs/950160. Approved by Daniel van Vugt.

3407. By Sam Spilsbury on 2012-10-02

Check for equality of string not pointer. Passing char * makes the template overload invoke opearator== on two pointers, which almost always fails.
(LP: #1058638). Fixes: https://bugs.launchpad.net/bugs/1058638. Approved by Daniel van Vugt.