Merge lp:~brandontschaefer/unity/disable-tap-for-super into lp:unity

Proposed by Brandon Schaefer on 2012-10-02
Status: Rejected
Rejected by: Brandon Schaefer on 2012-10-03
Proposed branch: lp:~brandontschaefer/unity/disable-tap-for-super
Merge into: lp:unity
Diff against target: 12 lines (+1/-0)
1 file modified
plugins/unityshell/unityshell.xml.in (+1/-0)
To merge this branch: bzr merge lp:~brandontschaefer/unity/disable-tap-for-super
Reviewer Review Type Date Requested Status
Daniel van Vugt 2012-10-02 Approve on 2012-10-03
Review via email: mp+127407@code.launchpad.net

Commit message

Disable reliable compiz tap detection for the Super key, so other programs
can still bind to Super+other_keys.
(LP: #950160)

Description of the change

A new option to disable tap detection in compiz. This sets it true for Super/show_launcher key.

Depends on this branch:
https://code.launchpad.net/~brandontschaefer/compiz/disable-tap-detection/+merge/127370

To post a comment you must log in.
Daniel van Vugt (vanvugt) wrote :

Looks good to me. But it won't work until you have the requisite compiz change.

review: Approve
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1457/console reported an error when processing this lp:~brandontschaefer/unity/disable-tap-for-super branch.
Not merging it.

Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1466/console reported an error when processing this lp:~brandontschaefer/unity/disable-tap-for-super branch.
Not merging it.

Daniel van Vugt (vanvugt) wrote :

Rejected why?

Daniel van Vugt (vanvugt) wrote :
Brandon Schaefer (brandontschaefer) wrote :

Sorry I didn't make a comment. This branch has a criss-cross problem, which messes up/confuses the merger. The easiest thing was just to make a new branch :)

Unmerged revisions

2777. By Brandon Schaefer on 2012-10-02

* Renamed

2776. By Brandon Schaefer on 2012-10-01

* Disable tap detection for the Super key

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/unityshell.cpp'
2=== modified file 'plugins/unityshell/unityshell.xml.in'
3--- plugins/unityshell/unityshell.xml.in 2012-09-07 15:49:40 +0000
4+++ plugins/unityshell/unityshell.xml.in 2012-10-02 17:06:38 +0000
5@@ -79,6 +79,7 @@
6 <option name="show_launcher" type="key">
7 <_short>Key to show the launcher</_short>
8 <_long>Make the launcher appear with that key</_long>
9+ <tap_detection>false</tap_detection>
10 <default>&lt;Super&gt;</default>
11 </option>
12 <option name="keyboard_focus" type="key">