Compiz

CCSGNOMEMediaKeys/CCSGNOMEIntegrationTestWriteIntegratedMediaKeys.TestWriteIntegratedMediaKey/* fail in jenkins

Bug #1058577 reported by Sam Spilsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
High
Sam Spilsbury
Compiz 0.9.9.0
0.9.8
Fix Released
High
Sam Spilsbury
Compiz 0.9.8.6 "SRU-1"
0.9.9
Fix Released
High
Sam Spilsbury
Compiz 0.9.9.0
compiz (Ubuntu)
Fix Released
High
Sam Spilsbury

Bug Description

These tests fail in pbuilder environments:

[ RUN ] CCSGNOMEMediaKeys/CCSGNOMEIntegrationTestWriteIntegratedMediaKeys.TestWriteIntegratedMediaKey/1
unknown file: Failure

Unexpected mock function call - returning directly.
    Function call: writeValue(0x1e5bcb0, 3)
Google Mock tried the following 1 expectation, but it didn't match:

/tmp/buildd/compiz-0.9.8.2+bzr3377/compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp:853: EXPECT_CALL(Mock (*mIntegratedSetting), writeValue (Pointee (SettingValueMatch (*gnomeValue, TypeString, &info)), TypeString))...
  Expected arg #0: points to a value that Value Matches <Control><Alt>Print
           Actual: 0x1e5bcb0, which points to Possible values in CCSSetting :
31833344
31833344
8.43925e-38
<Control><Primary><Alt>Print
Red: bd00Blue: 0Green: 1e5Alpha: 0

An action value
Keysym: 31833344 KeyModMask 0

Button 31833344Button Key Mask: 0Edge Mask: 0

31833344
31833344
<Control><Primary><Alt>Print
A list value
 (of type _CCSSettingValue)
         Expected: to be called once
           Actual: never called - unsatisfied and active
/tmp/buildd/compiz-0.9.8.2+bzr3377/compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp:853: Failure
Actual function call count doesn't match EXPECT_CALL(Mock (*mIntegratedSetting), writeValue (Pointee (SettingValueMatch (*gnomeValue, TypeString, &info)), TypeString))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[ FAILED ] CCSGNOMEMediaKeys/CCSGNOMEIntegrationTestWriteIntegratedMediaKeys.TestWriteIntegratedMediaKey/1, where GetParam() = 32-byte object <88-EA E5-01 00-00 00-00 08-D5 E5-01 00-00 00-00 D8-CD E5-01 00-00 00-00 61-FF 00-00 04-00 01-00> (0 ms)
[ RUN ] CCSGNOMEMediaKeys/CCSGNOMEIntegrationTestWriteIntegratedMediaKeys.TestWriteIntegratedMediaKey/2
unknown file: Failure

Unexpected mock function call - returning directly.
    Function call: writeValue(0x1e5ad70, 3)
Google Mock tried the following 1 expectation, but it didn't match:

/tmp/buildd/compiz-0.9.8.2+bzr3377/compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp:853: EXPECT_CALL(Mock (*mIntegratedSetting), writeValue (Pointee (SettingValueMatch (*gnomeValue, TypeString, &info)), TypeString))...
  Expected arg #0: points to a value that Value Matches <Control><Alt>t
           Actual: 0x1e5ad70, which points to Possible values in CCSSetting :
31840912
31840912
8.44349e-38
<Control><Primary><Alt>t
Red: da90Blue: 0Green: 1e5Alpha: 0

An action value
Keysym: 31840912 KeyModMask 0

Button 31840912Button Key Mask: 0Edge Mask: 0

31840912
31840912
<Control><Primary><Alt>t
A list value
 (of type _CCSSettingValue)
         Expected: to be called once
           Actual: never called - unsatisfied and active
/tmp/buildd/compiz-0.9.8.2+bzr3377/compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp:853: Failure
Actual function call count doesn't match EXPECT_CALL(Mock (*mIntegratedSetting), writeValue (Pointee (SettingValueMatch (*gnomeValue, TypeString, &info)), TypeString))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[ FAILED ] CCSGNOMEMediaKeys/CCSGNOMEIntegrationTestWriteIntegratedMediaKeys.TestWriteIntegratedMediaKey/2, where GetParam() = 32-byte object <E8-CE E5-01 00-00 00-00 48-F4 E5-01 00-00 00-00 28-CD E5-01 00-00 00-00 74-00 00-00 04-00 01-00> (1 ms)

The problem appears to be that we add <Primary> to keybinding strings indiscriminately. We should only be converting from <Primary> to ControlMask and not the other way around. This patch should also really be upstreamed

Related branches

lp:~compiz-team/compiz/compiz.fix_1058577
Daniel van Vugt: Approve
jenkins (community): Needs Fixing (continuous-integration)
Sam Spilsbury: Approve
Diff: 500 lines (+371/-26)
5 files modified
compizconfig/libcompizconfig/src/bindings.c (+52/-26)
compizconfig/libcompizconfig/src/ccs-modifier-list-inl.h (+50/-0)
compizconfig/libcompizconfig/src/ccs-private.h (+19/-0)
compizconfig/libcompizconfig/tests/CMakeLists.txt (+12/-0)
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_util.cpp (+238/-0)
lp:~compiz-team/compiz/compiz.0.9.8.disable_failing_tests_due_to_distro_patch
Daniel van Vugt: Approve
Diff: 12 lines (+1/-1)
1 file modified
compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp (+1/-1)
Superseded for merging into lp:compiz/0.9.9
Compiz Maintainers: Pending requested
Diff: 22 lines (+5/-1) (has conflicts)
2 files modified
VERSION (+4/-0)
compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp (+1/-1)
lp:~timo-jyrinki/ubuntu/quantal/compiz/ubuntu.0984bzr3407
lp:ubuntu/raring/compiz
Sam Spilsbury (smspillaz)
Changed in compiz:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Sam Spilsbury (smspillaz)
milestone: none → 0.9.9.0
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Fix committed into lp:compiz/0.9.8 at revision 3406

jenkins (martin-mrazik+qa)
Changed in compiz:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed into lp:compiz at revision 3413, scheduled for release in Compiz 0.9.9.0

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Is the full fix really committed to 0.9.8??

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Only disabling of the failing test in 0.9.8.

Didier Roche-Tolomelli (didrocks)
no longer affects: compiz (Ubuntu)
Daniel van Vugt (vanvugt)
Changed in compiz (Ubuntu):
assignee: nobody → Sam Spilsbury (smspillaz)
importance: Undecided → High
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.6 KiB)

This bug was fixed in the package compiz - 1:0.9.9~daily12.12.05-0ubuntu1

---------------
compiz (1:0.9.9~daily12.12.05-0ubuntu1) raring; urgency=low

  [ Michael Terry ]
  * debian/control:
    - Update Vcs-Bzr
  * debian/patches/100_expo_layout.patch:
    - Fix to apply
  * Automatic snapshot from revision 3451 (bootstrap)
    - Fix crash from writing to static memory (LP: #1065814)
    - Fix maximized windows changing workspaces (LP: #1071791)
    - Respect Zoom Factor setting (LP: #1066187)
    - Respect Show Window Title setting (LP: #1009999)
    - Restore text background transparency (LP: #1042132)
    - Restore screenshot selection rectangle transparency (LP: #1047788)
    - Restore top and bottom cube transparency (LP: #1048272)
    - Fix scaleaddon window highlighting being solid (LP #1068503)
    - Make resize hint overlay disappear when changing edges (LP: #839602)
    - Preserve grid IDs during drag (LP: #1067812, LP: #1048855)
    - Save current display before doing snap preview (LP: #1068173)
    - Ignore inactive keybindings (LP: #1053280)
    - Handle <primary> in keyboard shortcuts (LP: #936840)
    - Make sure showdesktop plugin is loaded after unityshell (LP: #1067534)
    - Fix grid build failure (LP: #1067577)
    - Fix Jenkins test failures (LP: #1058577)
    - Don't allow duplicate static symbols when linking (LP: #1067964)
    - Make external templates C++0x compatible (LP: #1067598)
    - Make sure to initialize class members (LP: #1033877)
    - Don't duplicate templates in plugins (LP: #1066793, LP: #1066803,
      LP: #1066804, LP: #1066805, LP: #1066799, LP: #1066796,
      LP: #1066795, LP: #1066798, LP: #1067218, LP: #1067219)
    - Don't needlessly set gsettings keys (LP: #1064791)
    - Remove unused code (LP: #1037142, LP: #1067234)
    - Fix syntax highlighting for trunk xml files (LP: #1066823)
    - Fix documentation for building with python2 (LP: #1070211)

  [ Stephen M. Webb ]
  * Windows open below panel and launcher, grid does not work at all,
    window animations missing, and general plugin chaos if built on
    raring (cmake >= 2.8.10) (LP: #1085581)

  [ Iven Hsu ]
  * KDE Appmenu doesn't work with compiz decorators (LP: #1082265)
  * compiz 0.9.8.6 fails to build from source in KDE4-window-decorator
    with latest KDE 4.10 beta (LP: #1082152)
  * kde4-window-decorator crashes when starting up with oxygen theme
    (LP: #1050776)

  [ sampo555 ]
  * Grid: Window management - resize preview does not show when moving a
    window from the semi-maximised state to the maximised state in a
    single action (LP: #1071689)

  [ Timo Jyrinki ]
  * HTML5 video in Firefox continues to tear (LP: #1086337)

  [ MC Return ]
  * Workspacenames Plug-in: Wishlist: Default Appearance values not
    ideal (LP: #1075600)
  * Resizeinfo Plug-in: No possibility to change the color and
    transparency of the rounded background outline (LP: #1070297)
  * Resizeinfo Plug-in: Gradient color 2 and 3 settings are ignored and
    no background gradient is rendered (LP: #1070233)
  * Expo animations "Fade + Zoom" & "Vortex" result in a black screen
    (LP: #875311)
  * Workspacenames Plug-in: Wishlist: No default values...

Read more...

Changed in compiz (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.