Compiz

Redundant check for libcompizconfig_internal in compizconfig gsettings tests

Bug #1060708 reported by Sam Spilsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Medium
Sam Spilsbury
Compiz 0.9.9.0
compiz (Ubuntu)
Fix Released
Medium
Sam Spilsbury

Bug Description

Currently we are checking for libcompizconfig_internal to ensure that we link to the correct libcompizconfig - this is unnecessary, as cmake sets the rpath to our binary dirs anyways, so the tests will always be run with the correct libcompizconfig linked in. We didn't check the return value for the pkg config test so it was silently failing.

Related branches

lp:~compiz-team/compiz/compiz.fix_1060708
Daniel van Vugt: Approve
jenkins (community): Needs Fixing (continuous-integration)
Diff: 150 lines (+72/-67)
1 file modified
compizconfig/gsettings/tests/CMakeLists.txt (+72/-67)
Sam Spilsbury (smspillaz)
Changed in compiz:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Sam Spilsbury (smspillaz)
milestone: none → 0.9.9.0
Unity Merger (unity-merger)
Changed in compiz:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in compiz (Ubuntu):
assignee: nobody → Sam Spilsbury (smspillaz)
importance: Undecided → Medium
status: New → Fix Committed
Daniel van Vugt (vanvugt)
Changed in compiz:
status: Fix Committed → Fix Released
Alberts Muktupāvels (muktupavels)
Changed in compiz (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.