Merge lp:~sergiusens/unity8/gallery-and-camera-to-click into lp:unity8

Proposed by Sergio Schvezov
Status: Superseded
Proposed branch: lp:~sergiusens/unity8/gallery-and-camera-to-click
Merge into: lp:unity8
Diff against target: 58 lines (+8/-8)
2 files modified
qml/Dash/Apps/FrequentlyUsedAppsModel.qml (+6/-6)
tests/autopilot/unity8/shell/tests/test_hud.py (+2/-2)
To merge this branch: bzr merge lp:~sergiusens/unity8/gallery-and-camera-to-click
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Sergio Schvezov Pending
Review via email: mp+207501@code.launchpad.net

This proposal supersedes a proposal from 2014-02-14.

Commit message

Convert gallery and camera to click

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote : Posted in a previous version of this proposal

 * Are there any related MPs required for this MP to build/function as expected? Please list.
YES
https://code.launchpad.net/~bfiller/unity8/gallery-and-camera-to-click/+merge/206534 https://code.launchpad.net/~bfiller/ubuntu/trusty/ubuntu-settings/touch-settings-click/+merge/206530 https://code.launchpad.net/~ken-vandine/content-hub/defaults_triplet/+merge/203841 https://code.launchpad.net/~bfiller/gallery-app/click-support/+merge/201238
https://code.launchpad.net/~bfiller/camera-app/click-support/+merge/200889
https://code.launchpad.net/~bfiller/ubuntu-seeds/ubuntu-touch.trusty-remove-gallery-camera/+merge/206537

* Did you perform an exploratory manual test run of your code change and any related functionality?
YES

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:715
http://jenkins.qa.ubuntu.com/job/unity8-ci/2330/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3253
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2923/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1200
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/851
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/855
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/855/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/851
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2861
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3255
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3255/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2925
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2925/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5329/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3977

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2330/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:715
http://jenkins.qa.ubuntu.com/job/unity8-ci/2335/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3275
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2943/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1205
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/856
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/860
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/860/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/856
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2883
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3277
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3277/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2945
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2945/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5349/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4018

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2335/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote : Posted in a previous version of this proposal

I approve

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:716
http://jenkins.qa.ubuntu.com/job/unity8-ci/2364/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3362/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3020/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1234
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/885
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/889
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/889/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/885
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2962/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3364
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3364/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3022
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3022/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5418/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4140

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2364/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:716
http://jenkins.qa.ubuntu.com/job/unity8-ci/2368/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3379
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3033/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1238
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/889
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/893
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/893/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/889
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2976
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3381
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3381/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3035
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3035/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5431/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4160

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2368/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/unity8-ci/2386/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3432
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3075/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1256
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/907
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/911
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/911/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/907
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3021
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3435
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3435/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3077
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3077/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5468/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4212

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2386/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/unity8-ci/2387/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3435
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3078/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1257
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/908
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/912
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/912/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/908
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3024
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3438
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3438/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3080
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3080/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5471/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4215

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2387/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/unity8-ci/2392/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3440
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3083/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1262
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/913
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/917
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/917/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/913
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3029
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3443
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3443/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3085
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3085/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5476/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4224

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2392/rebuild

review: Needs Fixing (continuous-integration)
716. By Sergio Schvezov

Fixing appid for camera and gallery

717. By Sergio Schvezov

changing test app to webbrowser

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Dash/Apps/FrequentlyUsedAppsModel.qml'
--- qml/Dash/Apps/FrequentlyUsedAppsModel.qml 2013-10-14 15:19:35 +0000
+++ qml/Dash/Apps/FrequentlyUsedAppsModel.qml 2014-02-24 20:57:21 +0000
@@ -48,24 +48,24 @@
48 metadata: "subscope:applications.scope/applications-non-click.scope"48 metadata: "subscope:applications.scope/applications-non-click.scope"
49 }49 }
50 ListElement {50 ListElement {
51 uri: "application://camera-app.desktop"51 uri: "appid://com.ubuntu.camera/camera/current-user-version"
52 icon: "../../graphics/applicationIcons/camera.png"52 icon: "../../graphics/applicationIcons/camera.png"
53 category: 053 category: 0
54 mimetype: "application/x-desktop"54 mimetype: "application/x-desktop"
55 title: "Camera"55 title: "Camera"
56 comment: ""56 comment: ""
57 dndUri: "file:///usr/share/applications/camera-app.desktop"57 dndUri: "appid://com.ubuntu.camera/camera/current-user-version"
58 metadata: "subscope:applications.scope/applications-non-click.scope"58 metadata: "subscope:applications.scope/applications-click.scope?app_id=com.ubuntu.camera"
59 }59 }
60 ListElement {60 ListElement {
61 uri: "application://gallery-app.desktop"61 uri: "appid://com.ubuntu.gallery/gallery/current-user-version"
62 icon: "../../graphics/applicationIcons/gallery.png"62 icon: "../../graphics/applicationIcons/gallery.png"
63 category: 063 category: 0
64 mimetype: "application/x-desktop"64 mimetype: "application/x-desktop"
65 title: "Gallery"65 title: "Gallery"
66 comment: ""66 comment: ""
67 dndUri: "file:///usr/share/applications/gallery.desktop"67 dndUri: "appid://com.ubuntu.gallery/gallery/current-user-version"
68 metadata: "subscope:applications.scope/applications-non-click.scope"68 metadata: "subscope:applications.scope/applications-click.scope?app_id=com.ubuntu.gallery"
69 }69 }
70 ListElement {70 ListElement {
71 uri: "appid://com.ubuntu.developer.webapps.webapp-facebook/webapp-facebook/current-user-version"71 uri: "appid://com.ubuntu.developer.webapps.webapp-facebook/webapp-facebook/current-user-version"
7272
=== modified file 'tests/autopilot/unity8/shell/tests/test_hud.py'
--- tests/autopilot/unity8/shell/tests/test_hud.py 2014-02-13 04:13:36 +0000
+++ tests/autopilot/unity8/shell/tests/test_hud.py 2014-02-24 20:57:21 +0000
@@ -163,7 +163,7 @@
163 self.assertThat(hud.shown, Eventually(Equals(False)))163 self.assertThat(hud.shown, Eventually(Equals(False)))
164164
165 def _launch_test_app_from_app_screen(self):165 def _launch_test_app_from_app_screen(self):
166 """Launches the camera app using the Dash UI.166 """Launches the browser app using the Dash UI.
167167
168 Because when testing on the desktop running168 Because when testing on the desktop running
169 self.launch_application() will launch the application on the desktop169 self.launch_application() will launch the application on the desktop
@@ -171,7 +171,7 @@
171171
172 """172 """
173 dash = self.main_window.get_dash()173 dash = self.main_window.get_dash()
174 icon = dash.get_application_icon('Camera')174 icon = dash.get_application_icon('Browser')
175 self.touch.tap_object(icon)175 self.touch.tap_object(icon)
176176
177 # Ensure application is open177 # Ensure application is open
178178
=== renamed file 'tests/mocks/data/applications/camera-app.desktop' => 'tests/mocks/data/applications/webbrowser-app.desktop'

Subscribers

People subscribed via source and target branches