Merge lp:~bfiller/ubuntu/trusty/ubuntu-settings/touch-settings-click into lp:ubuntu/trusty/ubuntu-settings

Proposed by Bill Filler
Status: Needs review
Proposed branch: lp:~bfiller/ubuntu/trusty/ubuntu-settings/touch-settings-click
Merge into: lp:ubuntu/trusty/ubuntu-settings
Diff against target: 10 lines (+1/-1)
1 file modified
debian/ubuntu-touch-settings.gsettings-override (+1/-1)
To merge this branch: bzr merge lp:~bfiller/ubuntu/trusty/ubuntu-settings/touch-settings-click
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing
Review via email: mp+206530@code.launchpad.net

Commit message

Change the launcher favorite to reference the click package for gallery and camera rather than the legacy desktop file.

Description of the change

Change the launcher favorite to reference the click package for gallery and camera rather than the legacy desktop file.
Note, this is a hardcoded path that includes the click version, as that is the only thing currently supported in the launcher. See bug https://bugs.launchpad.net/unity8/+bug/1239750 for details.

IMPORTANT: requires multiple other branches to load at the same time. See CI Train request for details.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work there ... it seems those click have a version hardcoded, does it mean we are going to need to do an upload of the default every time the click is updated? That seems like something that's not going to work great...

review: Needs Information
Revision history for this message
Bill Filler (bfiller) wrote :

yes that is the case until the Launcher supports favorites that don't require version number per https://bugs.launchpad.net/unity8/+bug/1239750

Revision history for this message
Sebastien Bacher (seb128) wrote :

Well, I guess unity8 needs to be fixed then, we just can't play catchup with the clicks every time they get an update

review: Needs Fixing

Unmerged revisions

22. By Bill Filler

change the launcher defaults for camera and gallery to point at click pacakge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/ubuntu-touch-settings.gsettings-override'
2--- debian/ubuntu-touch-settings.gsettings-override 2014-01-28 17:16:52 +0000
3+++ debian/ubuntu-touch-settings.gsettings-override 2014-02-14 17:14:02 +0000
4@@ -1,5 +1,5 @@
5 [com.canonical.Unity.Launcher]
6-favorites=['application://dialer-app.desktop', 'application://messaging-app.desktop', 'application://address-book-app.desktop', 'application://ubuntu-system-settings.desktop', 'application://camera-app.desktop', 'application://gallery-app.desktop', 'application://webbrowser-app.desktop']
7+favorites=['application://dialer-app.desktop', 'application://messaging-app.desktop', 'application://address-book-app.desktop', 'application://ubuntu-system-settings.desktop', 'application://com.ubuntu.camera_camera_2.9.1.223.desktop', 'application://com.ubuntu.gallery_gallery_2.9.1.910.desktop', 'application://webbrowser-app.desktop']
8
9 [com.canonical.Unity.Dash]
10 scopes=['music.scope', 'home.scope', 'applications.scope', 'video.scope']

Subscribers

People subscribed via source and target branches

to all changes: