Merge lp:~bfiller/unity8/gallery-and-camera-to-click into lp:unity8

Proposed by Bill Filler
Status: Superseded
Proposed branch: lp:~bfiller/unity8/gallery-and-camera-to-click
Merge into: lp:unity8
Diff against target: 34 lines (+6/-6)
1 file modified
qml/Dash/Apps/FrequentlyUsedAppsModel.qml (+6/-6)
To merge this branch: bzr merge lp:~bfiller/unity8/gallery-and-camera-to-click
Reviewer Review Type Date Requested Status
Sergio Schvezov Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+206534@code.launchpad.net

This proposal has been superseded by a proposal from 2014-02-20.

Commit message

convert gallery and camera to click

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

 * Are there any related MPs required for this MP to build/function as expected? Please list.
YES
https://code.launchpad.net/~bfiller/unity8/gallery-and-camera-to-click/+merge/206534 https://code.launchpad.net/~bfiller/ubuntu/trusty/ubuntu-settings/touch-settings-click/+merge/206530 https://code.launchpad.net/~ken-vandine/content-hub/defaults_triplet/+merge/203841 https://code.launchpad.net/~bfiller/gallery-app/click-support/+merge/201238
https://code.launchpad.net/~bfiller/camera-app/click-support/+merge/200889
https://code.launchpad.net/~bfiller/ubuntu-seeds/ubuntu-touch.trusty-remove-gallery-camera/+merge/206537

* Did you perform an exploratory manual test run of your code change and any related functionality?
YES

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:715
http://jenkins.qa.ubuntu.com/job/unity8-ci/2330/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3253
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2923/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1200
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/851
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/855
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/855/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/851
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2861
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3255
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3255/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2925
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2925/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5329/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3977

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2330/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:715
http://jenkins.qa.ubuntu.com/job/unity8-ci/2335/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3275
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2943/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1205
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/856
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/860
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/860/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/856
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2883
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3277
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3277/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2945
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2945/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5349/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4018

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2335/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

I approve

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) :
review: Needs Fixing

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/Apps/FrequentlyUsedAppsModel.qml'
2--- qml/Dash/Apps/FrequentlyUsedAppsModel.qml 2013-10-14 15:19:35 +0000
3+++ qml/Dash/Apps/FrequentlyUsedAppsModel.qml 2014-02-14 17:24:44 +0000
4@@ -48,24 +48,24 @@
5 metadata: "subscope:applications.scope/applications-non-click.scope"
6 }
7 ListElement {
8- uri: "application://camera-app.desktop"
9+ uri: "appid://com.ubuntu.camera/camera/current-user-version"
10 icon: "../../graphics/applicationIcons/camera.png"
11 category: 0
12 mimetype: "application/x-desktop"
13 title: "Camera"
14 comment: ""
15- dndUri: "file:///usr/share/applications/camera-app.desktop"
16- metadata: "subscope:applications.scope/applications-non-click.scope"
17+ dndUri: "appid://com.ubuntu.camera/camera/current-user-version"
18+ metadata: "subscope:applications.scope/applications-click.scope?app_id=com.ubuntu.camera/camera/current-user-version"
19 }
20 ListElement {
21- uri: "application://gallery-app.desktop"
22+ uri: "appid://com.ubuntu.gallery/gallery/current-user-version"
23 icon: "../../graphics/applicationIcons/gallery.png"
24 category: 0
25 mimetype: "application/x-desktop"
26 title: "Gallery"
27 comment: ""
28- dndUri: "file:///usr/share/applications/gallery.desktop"
29- metadata: "subscope:applications.scope/applications-non-click.scope"
30+ dndUri: "appid://com.ubuntu.gallery/gallery/current-user-version"
31+ metadata: "subscope:applications.scope/applications-click.scope?app_id=com.ubuntu.gallery/gallery/current-user-version"
32 }
33 ListElement {
34 uri: "appid://com.ubuntu.developer.webapps.webapp-facebook/webapp-facebook/current-user-version"

Subscribers

People subscribed via source and target branches