Merge lp:~salgado/launchpad/fix-distro-bug-reporting-test into lp:~launchpad-committers/launchpad/python-migration
Proposed by
Guilherme Salgado
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~salgado/launchpad/fix-distro-bug-reporting-test |
Merge into: | lp:~launchpad-committers/launchpad/python-migration |
Diff against target: |
23 lines 1 file modified
lib/lp/soyuz/scripts/tests/test_copypackage.py (+2/-4) |
To merge this branch: | bzr merge lp:~salgado/launchpad/fix-distro-bug-reporting-test |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
Looks like the librarian socket, in 2.5, is garbage collected right after an upload_ file_does_ not_leak_ file_descriptor s. This
upload, thus breaking test_re_
changes the test to not expect the socket to be open. We should probably not
rely on the garbage collector to do this, but fixing the librarian is out of
scope for this.