Code review comment for lp:~salgado/launchpad/fix-distro-bug-reporting-test

Revision history for this message
Guilherme Salgado (salgado) wrote :

Thanks Gary, this is the change I did to the test.

=== modified file 'lib/lp/soyuz/scripts/tests/test_copypackage.py'
--- lib/lp/soyuz/scripts/tests/test_copypackage.py 2009-10-16 15:11:05 +0000
+++ lib/lp/soyuz/scripts/tests/test_copypackage.py 2009-10-16 16:41:07 +0000
@@ -161,6 +161,9 @@
         previously_open_files = number_of_open_files()

         public_file = re_upload_file(private_file)
+ # The above call would've raised an error if the upload failed, but
+ # better safe than sorry.
+ self.assertIsNot(None, public_file)

         open_files = number_of_open_files() - previously_open_files
         self.assertEqual(0, open_files)

« Back to merge proposal