Code review comment for lp:~salgado/launchpad/fix-distro-bug-reporting-test

Revision history for this message
Gary Poster (gary) wrote :

merge-conditional

Hi Salgado. This looks good.

It's not obvious looking at the test in isolation that the re-upload actually worked. You told me on IRC that there is an assertion in getUtility(ILibraryFileAliasSet).create() that the file is created, so we are covered practically. I'd just like a comment in that regard in the test.

Thank you

Gary

review: Approve

« Back to merge proposal