Merge ~sahnaseredini/ubuntu-cve-tracker:amir-dev into ubuntu-cve-tracker:master
Status: | Merged |
---|---|
Merged at revision: | 7ee79311d2e75dbdb5eb7ef7ee2ae6f9c9f1faf7 |
Proposed branch: | ~sahnaseredini/ubuntu-cve-tracker:amir-dev |
Merge into: | ubuntu-cve-tracker:master |
Diff against target: |
20 lines (+9/-0) 1 file modified
scripts/git-hooks/pre-commit (+9/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Murray | Approve | ||
Review via email: mp+457262@code.launchpad.net |
Commit message
Adding changes in order to catch unwanted unstaged errors!
Description of the change
There's a situation where the pre-commit-
This happens if one makes changes to CVE files in active, makes them staged and tries to commit them, but the pre-commit-
Whilst I like the purpose of this change, I wonder if it may be too invasive as it breaks the ability to easily break up one large change into multiple smaller commits (without then having to 'ignore' each until the last one is reached).
I wonder if we should instead move our hooks to `pre-push` rathar than `pre-commit` since then we can try and ensure the entire set of changes is consistent?